| Message ID | 782a5658022cf91415f8ef168d57616ebab276f0.1543348078.git.dsterba@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Switch defines to enums | expand |
On Tue, Nov 27, 2018 at 08:53:52PM +0100, David Sterba wrote: > We can use simple enum for values that are not part of on-disk format: > extent map flags. Reviewed-by: Omar Sandoval <osandov@fb.com> > Signed-off-by: David Sterba <dsterba@suse.com> > --- > fs/btrfs/extent_map.h | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/fs/btrfs/extent_map.h b/fs/btrfs/extent_map.h > index 31977ffd6190..ef05a0121652 100644 > --- a/fs/btrfs/extent_map.h > +++ b/fs/btrfs/extent_map.h > @@ -11,13 +11,20 @@ > #define EXTENT_MAP_INLINE ((u64)-2) > #define EXTENT_MAP_DELALLOC ((u64)-1) > > -/* bits for the flags field */ > -#define EXTENT_FLAG_PINNED 0 /* this entry not yet on disk, don't free it */ > -#define EXTENT_FLAG_COMPRESSED 1 > -#define EXTENT_FLAG_PREALLOC 3 /* pre-allocated extent */ > -#define EXTENT_FLAG_LOGGING 4 /* Logging this extent */ > -#define EXTENT_FLAG_FILLING 5 /* Filling in a preallocated extent */ > -#define EXTENT_FLAG_FS_MAPPING 6 /* filesystem extent mapping type */ > +/* bits for the extent_map::flags field */ > +enum { > + /* this entry not yet on disk, don't free it */ > + EXTENT_FLAG_PINNED, > + EXTENT_FLAG_COMPRESSED, > + /* pre-allocated extent */ > + EXTENT_FLAG_PREALLOC, > + /* Logging this extent */ > + EXTENT_FLAG_LOGGING, > + /* Filling in a preallocated extent */ > + EXTENT_FLAG_FILLING, > + /* filesystem extent mapping type */ > + EXTENT_FLAG_FS_MAPPING, > +}; > > struct extent_map { > struct rb_node rb_node; > -- > 2.19.1 >
On 2018/11/28 上午3:53, David Sterba wrote: > We can use simple enum for values that are not part of on-disk format: > extent map flags. > > Signed-off-by: David Sterba <dsterba@suse.com> Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > --- > fs/btrfs/extent_map.h | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/fs/btrfs/extent_map.h b/fs/btrfs/extent_map.h > index 31977ffd6190..ef05a0121652 100644 > --- a/fs/btrfs/extent_map.h > +++ b/fs/btrfs/extent_map.h > @@ -11,13 +11,20 @@ > #define EXTENT_MAP_INLINE ((u64)-2) > #define EXTENT_MAP_DELALLOC ((u64)-1) > > -/* bits for the flags field */ > -#define EXTENT_FLAG_PINNED 0 /* this entry not yet on disk, don't free it */ > -#define EXTENT_FLAG_COMPRESSED 1 > -#define EXTENT_FLAG_PREALLOC 3 /* pre-allocated extent */ > -#define EXTENT_FLAG_LOGGING 4 /* Logging this extent */ > -#define EXTENT_FLAG_FILLING 5 /* Filling in a preallocated extent */ > -#define EXTENT_FLAG_FS_MAPPING 6 /* filesystem extent mapping type */ > +/* bits for the extent_map::flags field */ > +enum { > + /* this entry not yet on disk, don't free it */ > + EXTENT_FLAG_PINNED, > + EXTENT_FLAG_COMPRESSED, > + /* pre-allocated extent */ > + EXTENT_FLAG_PREALLOC, > + /* Logging this extent */ > + EXTENT_FLAG_LOGGING, > + /* Filling in a preallocated extent */ > + EXTENT_FLAG_FILLING, > + /* filesystem extent mapping type */ > + EXTENT_FLAG_FS_MAPPING, > +}; > > struct extent_map { > struct rb_node rb_node; >
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff --git a/fs/btrfs/extent_map.h b/fs/btrfs/extent_map.h index 31977ffd6190..ef05a0121652 100644 --- a/fs/btrfs/extent_map.h +++ b/fs/btrfs/extent_map.h @@ -11,13 +11,20 @@ #define EXTENT_MAP_INLINE ((u64)-2) #define EXTENT_MAP_DELALLOC ((u64)-1) -/* bits for the flags field */ -#define EXTENT_FLAG_PINNED 0 /* this entry not yet on disk, don't free it */ -#define EXTENT_FLAG_COMPRESSED 1 -#define EXTENT_FLAG_PREALLOC 3 /* pre-allocated extent */ -#define EXTENT_FLAG_LOGGING 4 /* Logging this extent */ -#define EXTENT_FLAG_FILLING 5 /* Filling in a preallocated extent */ -#define EXTENT_FLAG_FS_MAPPING 6 /* filesystem extent mapping type */ +/* bits for the extent_map::flags field */ +enum { + /* this entry not yet on disk, don't free it */ + EXTENT_FLAG_PINNED, + EXTENT_FLAG_COMPRESSED, + /* pre-allocated extent */ + EXTENT_FLAG_PREALLOC, + /* Logging this extent */ + EXTENT_FLAG_LOGGING, + /* Filling in a preallocated extent */ + EXTENT_FLAG_FILLING, + /* filesystem extent mapping type */ + EXTENT_FLAG_FS_MAPPING, +}; struct extent_map { struct rb_node rb_node;
We can use simple enum for values that are not part of on-disk format: extent map flags. Signed-off-by: David Sterba <dsterba@suse.com> --- fs/btrfs/extent_map.h | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)