| Message ID | 9cfb7fb05fb474cf5c39ff71340db9c1f6a652aa.1700673354.git.josef@toxicpanda.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: don't test -o norecovery in btrfs/220 | expand |
On Wed, Nov 22, 2023 at 5:16 PM Josef Bacik <josef@toxicpanda.com> wrote: > > This is a deprecated option and it's going away with the new mount api > patches, so remove this from the test. > > Signed-off-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: Filipe Manana <fdmanana@suse.com> Makes sense, thanks. > --- > tests/btrfs/220 | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/tests/btrfs/220 b/tests/btrfs/220 > index b092f40b..60b42b6a 100755 > --- a/tests/btrfs/220 > +++ b/tests/btrfs/220 > @@ -212,20 +212,14 @@ test_non_revertible_options() > # nologreplay should be used only with readonly > test_should_fail "nologreplay" > > - # norecovery should be used only with readonly. > - # This options is an alias to nologreplay > - test_should_fail "norecovery" > - > if [ "$enable_rescue_nologreplay" = true ]; then > #rescue=nologreplay should be used only with readonly > test_should_fail "rescue=nologreplay" > > test_mount_opt "nologreplay,ro" "ro,rescue=nologreplay" > - test_mount_opt "norecovery,ro" "ro,rescue=nologreplay" > test_mount_opt "rescue=nologreplay,ro" "ro,rescue=nologreplay" > else > test_mount_opt "nologreplay,ro" "ro,nologreplay" > - test_mount_opt "norecovery,ro" "ro,nologreplay" > fi > > test_mount_opt "rescan_uuid_tree" "rescan_uuid_tree" > -- > 2.41.0 > >
diff --git a/tests/btrfs/220 b/tests/btrfs/220 index b092f40b..60b42b6a 100755 --- a/tests/btrfs/220 +++ b/tests/btrfs/220 @@ -212,20 +212,14 @@ test_non_revertible_options() # nologreplay should be used only with readonly test_should_fail "nologreplay" - # norecovery should be used only with readonly. - # This options is an alias to nologreplay - test_should_fail "norecovery" - if [ "$enable_rescue_nologreplay" = true ]; then #rescue=nologreplay should be used only with readonly test_should_fail "rescue=nologreplay" test_mount_opt "nologreplay,ro" "ro,rescue=nologreplay" - test_mount_opt "norecovery,ro" "ro,rescue=nologreplay" test_mount_opt "rescue=nologreplay,ro" "ro,rescue=nologreplay" else test_mount_opt "nologreplay,ro" "ro,nologreplay" - test_mount_opt "norecovery,ro" "ro,nologreplay" fi test_mount_opt "rescan_uuid_tree" "rescan_uuid_tree"
This is a deprecated option and it's going away with the new mount api patches, so remove this from the test. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- tests/btrfs/220 | 6 ------ 1 file changed, 6 deletions(-)