| Message ID | 9e38c9daf9d330ad2c3a180df13c4bcc0f115416.1738844738.git.fdmanana@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | generic/631: suggest xfs fix only if the tested filesystem is xfs | expand |
On 6/2/25 20:26, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > It's odd when a test fails on a filesystem that is not xfs and it suggests > that a xfs specific fix may be missing, which obviously is irrelevant. > So suggest the fix only if we are running on xfs. > > Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: Anand Jain <anand.jain@oracle.com> > --- > tests/generic/631 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/631 b/tests/generic/631 > index 8e2cf9c6..c38ab771 100755 > --- a/tests/generic/631 > +++ b/tests/generic/631 > @@ -41,7 +41,7 @@ _require_attrs trusted > _exclude_fs overlay > _require_extra_fs overlay > > -_fixed_by_kernel_commit 6da1b4b1ab36 \ > +[ "$FSTYP" = "xfs" ] && _fixed_by_kernel_commit 6da1b4b1ab36 \ > "xfs: fix an ABBA deadlock in xfs_rename" > > _scratch_mkfs >> $seqres.full
On Thu, Feb 6, 2025 at 12:26 PM <fdmanana@kernel.org> wrote: > > From: Filipe Manana <fdmanana@suse.com> > > It's odd when a test fails on a filesystem that is not xfs and it suggests > that a xfs specific fix may be missing, which obviously is irrelevant. > So suggest the fix only if we are running on xfs. > > Signed-off-by: Filipe Manana <fdmanana@suse.com> Scratch that, there are more generic tests doing this, so replacing this patch with another one to fix all of them: https://lore.kernel.org/linux-btrfs/8c64ba21953b44b682c72b448bebe273dba64013.1738847088.git.fdmanana@suse.com/ Thanks. > --- > tests/generic/631 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/631 b/tests/generic/631 > index 8e2cf9c6..c38ab771 100755 > --- a/tests/generic/631 > +++ b/tests/generic/631 > @@ -41,7 +41,7 @@ _require_attrs trusted > _exclude_fs overlay > _require_extra_fs overlay > > -_fixed_by_kernel_commit 6da1b4b1ab36 \ > +[ "$FSTYP" = "xfs" ] && _fixed_by_kernel_commit 6da1b4b1ab36 \ > "xfs: fix an ABBA deadlock in xfs_rename" > > _scratch_mkfs >> $seqres.full > -- > 2.45.2 > >
diff --git a/tests/generic/631 b/tests/generic/631 index 8e2cf9c6..c38ab771 100755 --- a/tests/generic/631 +++ b/tests/generic/631 @@ -41,7 +41,7 @@ _require_attrs trusted _exclude_fs overlay _require_extra_fs overlay -_fixed_by_kernel_commit 6da1b4b1ab36 \ +[ "$FSTYP" = "xfs" ] && _fixed_by_kernel_commit 6da1b4b1ab36 \ "xfs: fix an ABBA deadlock in xfs_rename" _scratch_mkfs >> $seqres.full