From patchwork Sun Nov 30 13:37:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shriramana Sharma X-Patchwork-Id: 5408061 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C5AB9BEEA8 for ; Sun, 30 Nov 2014 13:39:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6DCB720172 for ; Sun, 30 Nov 2014 13:39:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AA852015E for ; Sun, 30 Nov 2014 13:39:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752099AbaK3Nhz (ORCPT ); Sun, 30 Nov 2014 08:37:55 -0500 Received: from mail-qc0-f177.google.com ([209.85.216.177]:48050 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbaK3Nhy (ORCPT ); Sun, 30 Nov 2014 08:37:54 -0500 Received: by mail-qc0-f177.google.com with SMTP id x3so6438691qcv.22 for ; Sun, 30 Nov 2014 05:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=HjNffCBFXWSlAMDi70vvMlVsGC2FBVCPcfMDyQvih1U=; b=xAcmAa9rWkIcekXu2EQLFC+rUCdALkUPz3H8bV5wU9937/d2CaXEyE59honPNK/gZL ms+CwC7O2xUOR9JNrYr0dRq+pHx2PrjqJ+s2YWEcaA9CYYG9tLvK/sWtDd5puFNjtUkb qVjJwb4LMIon2IHuPqLZyOvCiOlvNs3MeK78MkCmtttEkHGBJVWcwp3Td5Mvkpf301B2 +kNvQtPdOUQeW+uowcplRtIQaAXTM0GjzCgeLCXdPkz5PXYY4Vum7/jGt6/hPWa8xQ9m Uw2DtZO4bTmmc6SZFuR22uKYZNrRvMWZ8z+3iKKDpJOQyMVMtwceRXPq8MuPFe4kMn2k O/FQ== X-Received: by 10.140.92.134 with SMTP id b6mr75444133qge.25.1417354673315; Sun, 30 Nov 2014 05:37:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.155.13 with HTTP; Sun, 30 Nov 2014 05:37:33 -0800 (PST) In-Reply-To: References: From: Shriramana Sharma Date: Sun, 30 Nov 2014 19:07:33 +0530 Message-ID: Subject: Re: Change "total" in btrfs filesystem df output to "alloc" To: linux-btrfs Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Attached patch. On Sun, Nov 30, 2014 at 9:30 AM, Shriramana Sharma wrote: > On Sun, Aug 31, 2014 at 7:25 AM, Shriramana Sharma wrote: >> Hello. There seem to be lots of questions in various forums re the >> output of btrfs fi df -- especially w.r.t. the usage of the word >> "total". For example see https://community.oracle.com/thread/2459838 >> >> I feel it would make the intent clearer if "total" were changed to >> "alloc" or "allocated" (if the short form is felt unclear). It would >> also help people understand the output of regular df on a btrfs system >> since one can understand easier that pre-allocated space would count >> as "used" space as it is not free! > > Where should I report a bug to get this fixed? Thanks. > > -- > Shriramana Sharma ???????????? ???????????? From 3d386053105ef7c2dba3643530dffe3ecd4dcf49 Mon Sep 17 00:00:00 2001 From: Shriramana Sharma Date: Sun, 30 Nov 2014 19:00:38 +0530 Subject: [PATCH] df: change "total" to "alloc" --- cmds-filesystem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-filesystem.c b/cmds-filesystem.c index cd6b3c6..05f6235 100644 --- a/cmds-filesystem.c +++ b/cmds-filesystem.c @@ -233,7 +233,7 @@ static void print_df(struct btrfs_ioctl_space_args *sargs, unsigned unit_mode) struct btrfs_ioctl_space_info *sp = sargs->spaces; for (i = 0; i < sargs->total_spaces; i++, sp++) { - printf("%s, %s: total=%s, used=%s\n", + printf("%s, %s: alloc=%s, used=%s\n", group_type_str(sp->flags), group_profile_str(sp->flags), pretty_size_mode(sp->total_bytes, unit_mode), -- 2.1.3