From patchwork Thu Dec 18 14:27:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sterba X-Patchwork-Id: 5514191 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CAFFF9F326 for ; Thu, 18 Dec 2014 14:28:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 03B5F209DD for ; Thu, 18 Dec 2014 14:28:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15BB6209C7 for ; Thu, 18 Dec 2014 14:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752093AbaLRO14 (ORCPT ); Thu, 18 Dec 2014 09:27:56 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40372 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbaLRO1z (ORCPT ); Thu, 18 Dec 2014 09:27:55 -0500 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C3C75AD2F for ; Thu, 18 Dec 2014 14:27:54 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 40544DAA27; Thu, 18 Dec 2014 15:27:54 +0100 (CET) From: David Sterba To: linux-btrfs@vger.kernel.org Cc: David Sterba Subject: [PATCH 4/6] btrfs-progs: dev usage, add switches to set output units Date: Thu, 18 Dec 2014 15:27:54 +0100 Message-Id: X-Mailer: git-send-email 2.1.3 In-Reply-To: References: Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Same set of options as 'fi df': binary and decimal bases, human readable options etc. Signed-off-by: David Sterba --- cmds-device.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 50 insertions(+), 10 deletions(-) diff --git a/cmds-device.c b/cmds-device.c index 33f1311a546c..13458d850c26 100644 --- a/cmds-device.c +++ b/cmds-device.c @@ -451,10 +451,17 @@ out: } const char * const cmd_device_usage_usage[] = { - "btrfs device usage [-b] [..]", - "Show which chunks are in a device.", - "", - "-b\tSet byte as unit", + "btrfs device usage [options] [..]", + "Show detailed information about internal allocations in devices.", + "-b|--raw raw numbers in bytes", + "-h human friendly numbers, base 1024 (default)", + "-H human friendly numbers, base 1000", + "--iec use 1024 as a base (KiB, MiB, GiB, TiB)", + "--si use 1000 as a base (kB, MB, GB, TB)", + "-k|--kbytes show sizes in KiB, or kB with --si", + "-m|--mbytes show sizes in MiB, or MB with --si", + "-g|--gbytes show sizes in GiB, or GB with --si", + "-t|--tbytes show sizes in TiB, or TB with --si", NULL }; @@ -489,21 +496,54 @@ out: int cmd_device_usage(int argc, char **argv) { - - int mode = UNITS_HUMAN; + unsigned unit_mode = UNITS_DEFAULT; int ret = 0; int i, more_than_one = 0; optind = 1; while (1) { - int c = getopt(argc, argv, "b"); + int long_index; + static const struct option long_options[] = { + { "raw", no_argument, NULL, 'b'}, + { "kbytes", no_argument, NULL, 'k'}, + { "mbytes", no_argument, NULL, 'm'}, + { "gbytes", no_argument, NULL, 'g'}, + { "tbytes", no_argument, NULL, 't'}, + { "si", no_argument, NULL, 256}, + { "iec", no_argument, NULL, 257}, + }; + int c = getopt_long(argc, argv, "bhHkmgt", long_options, + &long_index); if (c < 0) break; - switch (c) { case 'b': - mode = UNITS_RAW; + unit_mode = UNITS_RAW; + break; + case 'k': + units_set_base(&unit_mode, UNITS_KBYTES); + break; + case 'm': + units_set_base(&unit_mode, UNITS_MBYTES); + break; + case 'g': + units_set_base(&unit_mode, UNITS_GBYTES); + break; + case 't': + units_set_base(&unit_mode, UNITS_TBYTES); + break; + case 'h': + unit_mode = UNITS_HUMAN_BINARY; + break; + case 'H': + unit_mode = UNITS_HUMAN_DECIMAL; + break; + case 256: + units_set_mode(&unit_mode, UNITS_DECIMAL); + break; + case 257: + units_set_mode(&unit_mode, UNITS_BINARY); break; default: usage(cmd_device_usage_usage); @@ -527,7 +567,7 @@ int cmd_device_usage(int argc, char **argv) goto out; } - ret = _cmd_device_usage(fd, argv[i], mode); + ret = _cmd_device_usage(fd, argv[i], unit_mode); close_file_or_dir(fd, dirstream); if (ret)