@@ -340,7 +340,7 @@ static int clear_uuid_tree(struct btrfs_fs_info *fs_info)
if (ret < 0)
goto out;
list_del(&uuid_root->dirty_list);
- ret = clean_tree_block(uuid_root->node);
+ ret = btrfs_clear_buffer_dirty(uuid_root->node);
if (ret < 0)
goto out;
ret = btrfs_free_tree_block(trans, uuid_root, uuid_root->node, 0, 1);
@@ -433,7 +433,7 @@ static noinline int update_ref_for_cow(struct btrfs_trans_handle *trans,
ret = btrfs_dec_ref(trans, root, buf, 1);
BUG_ON(ret);
}
- clean_tree_block(buf);
+ btrfs_clear_buffer_dirty(buf);
}
return 0;
}
@@ -936,7 +936,7 @@ static int balance_level(struct btrfs_trans_handle *trans,
root->node = child;
add_root_to_dirty_list(root);
path->nodes[level] = NULL;
- clean_tree_block(mid);
+ btrfs_clear_buffer_dirty(mid);
/* once for the path */
free_extent_buffer(mid);
@@ -991,7 +991,7 @@ static int balance_level(struct btrfs_trans_handle *trans,
u64 bytenr = right->start;
u32 blocksize = right->len;
- clean_tree_block(right);
+ btrfs_clear_buffer_dirty(right);
free_extent_buffer(right);
right = NULL;
wret = btrfs_del_ptr(root, path, level + 1, pslot + 1);
@@ -1039,7 +1039,7 @@ static int balance_level(struct btrfs_trans_handle *trans,
/* we've managed to empty the middle node, drop it */
u64 bytenr = mid->start;
u32 blocksize = mid->len;
- clean_tree_block(mid);
+ btrfs_clear_buffer_dirty(mid);
free_extent_buffer(mid);
mid = NULL;
wret = btrfs_del_ptr(root, path, level + 1, pslot);
@@ -3012,7 +3012,7 @@ int btrfs_del_items(struct btrfs_trans_handle *trans, struct btrfs_root *root,
if (leaf == root->node) {
btrfs_set_header_level(leaf, 0);
} else {
- clean_tree_block(leaf);
+ btrfs_clear_buffer_dirty(leaf);
wret = btrfs_del_leaf(trans, root, path, leaf);
BUG_ON(ret);
if (wret)
@@ -3048,7 +3048,7 @@ int btrfs_del_items(struct btrfs_trans_handle *trans, struct btrfs_root *root,
}
if (btrfs_header_nritems(leaf) == 0) {
- clean_tree_block(leaf);
+ btrfs_clear_buffer_dirty(leaf);
path->slots[1] = slot;
ret = btrfs_del_leaf(trans, root, path, leaf);
BUG_ON(ret);
@@ -2255,11 +2255,6 @@ skip_commit:
return err;
}
-int clean_tree_block(struct extent_buffer *eb)
-{
- return clear_extent_buffer_dirty(eb);
-}
-
void btrfs_mark_buffer_dirty(struct extent_buffer *eb)
{
set_extent_buffer_dirty(eb);
@@ -2303,7 +2298,7 @@ int btrfs_delete_and_free_root(struct btrfs_trans_handle *trans,
return ret;
list_del(&root->dirty_list);
- ret = clean_tree_block(root->node);
+ ret = btrfs_clear_buffer_dirty(root->node);
if (ret)
return ret;
ret = btrfs_free_tree_block(trans, root, root->node, 0, 1);
@@ -1902,7 +1902,7 @@ static int pin_down_bytes(struct btrfs_trans_handle *trans, u64 bytenr,
if (header_owner != BTRFS_TREE_LOG_OBJECTID &&
header_transid == trans->transid &&
!btrfs_header_flag(buf, BTRFS_HEADER_FLAG_WRITTEN)) {
- clean_tree_block(buf);
+ btrfs_clear_buffer_dirty(buf);
free_extent_buffer(buf);
return 1;
}
@@ -579,7 +579,7 @@ int set_extent_buffer_dirty(struct extent_buffer *eb)
return 0;
}
-int clear_extent_buffer_dirty(struct extent_buffer *eb)
+int btrfs_clear_buffer_dirty(struct extent_buffer *eb)
{
struct extent_io_tree *tree = &eb->fs_info->dirty_buffers;
if (eb->flags & EXTENT_BUFFER_DIRTY) {
@@ -124,7 +124,7 @@ void memset_extent_buffer(const struct extent_buffer *eb, char c,
int extent_buffer_test_bit(const struct extent_buffer *eb, unsigned long start,
unsigned long nr);
int set_extent_buffer_dirty(struct extent_buffer *eb);
-int clear_extent_buffer_dirty(struct extent_buffer *eb);
+int btrfs_clear_buffer_dirty(struct extent_buffer *eb);
int read_data_from_disk(struct btrfs_fs_info *info, void *buf, u64 logical,
u64 *len, int mirror);
int write_data_to_disk(struct btrfs_fs_info *info, void *buf, u64 offset,
@@ -161,7 +161,7 @@ again:
goto cleanup;
}
start += eb->len;
- clear_extent_buffer_dirty(eb);
+ btrfs_clear_buffer_dirty(eb);
free_extent_buffer(eb);
}
}
@@ -184,7 +184,7 @@ cleanup:
eb = find_first_extent_buffer(fs_info, start);
BUG_ON(!eb || eb->start != start);
start += eb->len;
- clear_extent_buffer_dirty(eb);
+ btrfs_clear_buffer_dirty(eb);
free_extent_buffer(eb);
}
}
This is a mirror of the change I've done in the kernel, but in progs it's even more simply because clean_tree_block was just a wrapper around clear_extent_buffer_dirty. Change this to btrfs_clear_buffer_dirty, and then update all the callers to use this helper instead of clean_tree_block and clear_extent_buffer_dirty. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- cmds/rescue.c | 2 +- kernel-shared/ctree.c | 12 ++++++------ kernel-shared/disk-io.c | 7 +------ kernel-shared/extent-tree.c | 2 +- kernel-shared/extent_io.c | 2 +- kernel-shared/extent_io.h | 2 +- kernel-shared/transaction.c | 4 ++-- 7 files changed, 13 insertions(+), 18 deletions(-)