From patchwork Fri Nov 5 20:45:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 12605935 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 950B5C433FE for ; Fri, 5 Nov 2021 20:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F60D61372 for ; Fri, 5 Nov 2021 20:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233751AbhKEUsr (ORCPT ); Fri, 5 Nov 2021 16:48:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233724AbhKEUsp (ORCPT ); Fri, 5 Nov 2021 16:48:45 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C31EC061714 for ; Fri, 5 Nov 2021 13:46:05 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id bj27so8225450qkb.11 for ; Fri, 05 Nov 2021 13:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=f0HqbDC5KkXztO3gbBUEK9ah3Vq667HdnflXe5N1lqA=; b=O+xsYroj7UdGg87xsSoz1ySaNFrnyc6oFu9yIUhqTUpz4ob3SE53H8q4qXoBt/lvW5 bGy/9LdXlhIdcpdyFAnrw58g43wRO7SAJ8c3qPHIW9ZGnKA5IVQ5ZxhSIVVGFNZGXujs FX26BlUJJUEGO3xZskEA9IuoUvV8AOP5rge/Eamiso8lSeMy+OXEtFHGqKrv6r++TdUT nH8BWukjNUmMsFs/1CdpFd0FMIxp1zlvNIHpaMYcBYtXargsnXdouM20Z9xSRBzGeI43 LCtN3h3pK+Dn66OXmVt1vftMU4F24gxkae+RQEl25i5AQvgK804F56NOy0xioLDmeDyb UGJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f0HqbDC5KkXztO3gbBUEK9ah3Vq667HdnflXe5N1lqA=; b=Qz+EYkdHAsmojqpxbEZ3gN0GonYbQiQ2/hETXvrkOlyvkFxBMevGlf3dNba4OFL7hS SRdme4gq4k5j55OHloTWds0wfx2lvE0dqOKtiS0Dkit5NSSEGUKQMm6w1tYgXoaoYDfv K7gHfhazQcE8Zv1BvxVJ6/Wx3CiLAu88cVwLYeQ/eXcafEY6uSSLTVHdFWl/jYvAVtcG Tu8znX7FvWpW64ieRnsRTxvCCpFPO40Yik+NQeTe/MAF6/sRIXfmj/PWcQgeTQLh8SIf jMUTHVYvgKAcx7Wk42NOPB1BIUzFtjfF8AylDiNiifTZJZ40lreG9jD2HoWeM/C7I7mX QL2g== X-Gm-Message-State: AOAM531OSN2HrslZ0vDIpy2oVrftt42ipcHjAZCBSvdCrOqhx/ICrDDU SSGW8QumDIXC9ucgRvws7ngJkbdxR9bZ9g== X-Google-Smtp-Source: ABdhPJz5ZntxW5HVz4/+M/ZV2mWBm1Tw0zEK6CzdSBvcz729s4HZ4qmn1Jli1OlbyS7G8IGOvFTcFQ== X-Received: by 2002:a05:620a:280a:: with SMTP id f10mr48915060qkp.118.1636145164397; Fri, 05 Nov 2021 13:46:04 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id bq30sm6230673qkb.6.2021.11.05.13.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 13:46:03 -0700 (PDT) From: Josef Bacik To: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: [PATCH 08/25] btrfs: remove BUG_ON() in find_parent_nodes() Date: Fri, 5 Nov 2021 16:45:34 -0400 Message-Id: X-Mailer: git-send-email 2.26.3 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org We search for an extent entry with .offset = -1, which shouldn't be a thing, but corruption happens. Add an ASSERT() for the developers, return -EUCLEAN for mortals. Signed-off-by: Josef Bacik --- fs/btrfs/backref.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 12276ff08dd4..7d942f5d6443 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c @@ -1210,7 +1210,12 @@ static int find_parent_nodes(struct btrfs_trans_handle *trans, ret = btrfs_search_slot(NULL, root, &key, path, 0, 0); if (ret < 0) goto out; - BUG_ON(ret == 0); + if (ret == 0) { + /* This shouldn't happen, indicates a bug or fs corruption. */ + ASSERT(ret != 0); + ret = -EUCLEAN; + goto out; + } if (trans && likely(trans->type != __TRANS_DUMMY) && time_seq != BTRFS_SEQ_LAST) {