| Message ID | bebe0616-d23b-5110-90bb-d3cfaf330121@bluematt.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,btrfs] Add handling for RAID 1CN to, `btrfs_reduce_alloc_profile` | expand |
On 03/06/2023 03.57, Matt Corallo wrote: > Changes from v1: Reordered the preference list and rewrote the commit message to be more useful. > > Callers of `btrfs_reduce_alloc_profile` expect it to return exactly > one allocation profile flag, and failing to do so may ultimately > result in a WARN_ON and remount-ro when allocating new blocks, like > the below transaction abort on 6.1. > > `btrfs_reduce_alloc_profile` has two ways of determining the profile, > first it checks if a conversion balance is currently running and > uses the profile we're converting to. If no balance is currently > running, it returns the max-redundancy profile which at least one > block in the selected block group has. > > This works by simply checking each known allocation profile bit in > redundancy order. However, when RAID1C3/RAID1C4 handling was added, > `btrfs_reduce_alloc_profile` was not updated to check for the new > flags. > > Because of the way it checks, if we have blocks with different > profiles and at least one is known, that profile will be selected. > However, if none are known we may return a flag set with multiple > allocation profiles set. > > This is currently only possible when a balance from RAID1C* to the > other RAID1C* profile is canceled after allocating at least one > block using the new profile. I had to reread the code several times to understand your patch. I am not saying that your patch is wrong, the code is ugly and not easy to understand. However I have to point out that you treat the symptom than the real cause. The real cause was the code that assumes that the 'allowed' contains *only* one of BTRFS_BLOCK_GROUP_*. This was not true from a very long time but only in a very specific case it raised an error. My suggestion is to: - explicitly add all other missing case (DUP, SINGLE....) - add a further 'else' branch to signal an un-handled case, something like else { btrfs_error( /* error message */ ); allowed = /* safe default ??? */ } Or if you are brave enough, replace the if(s) with an iterate over the btrfs_raid_array[] taking the one with an highest priority (may be you need to add a "priority" field to array). Finally, but this is definitely outside the scope of your patch, I think that the logic used by btrfs is basically wrong: currently, when you interrupted a balancing in a less safe direction (e.g. raid1 -> single), the next block allocation is done in the opposite direction. More "strange" result would be if you does several interrupted balances with different profiles... And now reading the code it seems to me that if the default profile is RAID1C4, and only *one* disk is filled, then the system go to a SINGLE profile... Why doesn't try a RAID1C3 ? Better would be store explicitly somewhere the "default" profile (accessible via a sysfs filed) and their 2nd choices; eg if the user selects a RAID6 profile, the options should be: $ cat /sys/fs/btrfs/<uuid>/current_profile [raid6] raid5 single $ # if the user sets RAID1C4 $ cat /sys/fs/btrfs/<uuid>/current_profile [raid1c4] raid1c3 raid1 single $ # if the user sets DUP $ cat /sys/fs/btrfs/<uuid>/current_profile [dup] $ # the user sets RAID1C3, note that it is not listed anymore RAID1C4 $ # even if an interrupted balance leaved a RAID1C4 block-group $ cat /sys/fs/btrfs/<uuid>/current_profile [raid1c3] raid1 single TBD: after raid6, there is raid5, but then after raid5 which one would be better: DUP or SINGLE ? > > In that case, a transaction abort like the below will occur and the > filesystem will need to be mounted with -o skip_balance to get it > mounted rw again (but the balance cannot be resumed without a > similar abort). > > Signed-off-by: Matt Corallo <blnxfsl@bluematt.me> > > [1158770.648155] ------------[ cut here ]------------ > [1158770.648157] BTRFS: Transaction aborted (error -22) > [1158770.648205] WARNING: CPU: 43 PID: 1159593 at fs/btrfs/extent-tree.c:4122 find_free_extent+0x1d94/0x1e00 [btrfs] > [1158770.648242] Modules linked in: xt_tcpudp wireguard libchacha20poly1305 libcurve25519_generic libchacha libpoly1305 ip6_udp_tunnel udp_tunnel ipt_REJECT nf_reject_ipv4 veth nft_chain_nat xt_nat nf_nat xt_set xt_state xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nft_compat nf_tables crc32c_generic ip_set_hash_net ip_set_hash_ip ip_set nfnetlink bridge stp llc essiv authenc ast drm_vram_helper drm_ttm_helper ttm ofpart ipmi_powernv powernv_flash ipmi_devintf drm_kms_helper ipmi_msghandler mtd opal_prd syscopyarea sysfillrect sysimgblt fb_sys_fops i2c_algo_bit sg at24 regmap_i2c binfmt_misc drm fuse sunrpc drm_panel_orientation_quirks configfs ip_tables x_tables autofs4 xxhash_generic btrfs zstd_compress raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor hid_generic usbhid hid raid6_pq libcrc32c raid1 raid0 multipath linear md_mod usb_storage dm_crypt dm_mod algif_skcipher af_alg sd_mod xhci_pci xhci_hcd xts ecb ctr nvme vmx_crypto gf128mul > [1158770.648328] crc32c_vpmsum tg3 mpt3sas nvme_core t10_pi usbcore libphy crc64_rocksoft_generic crc64_rocksoft crc_t10dif crct10dif_generic raid_class crc64 crct10dif_common ptp pps_core usb_common scsi_transport_sas > [1158770.648348] CPU: 43 PID: 1159593 Comm: btrfs Tainted: G W 6.1.0-0.deb11.7-powerpc64le #1 Debian 6.1.20-2~bpo11+1a~test > [1158770.648353] Hardware name: T2P9D01 REV 1.00 POWER9 0x4e1202 opal:skiboot-bc106a0 PowerNV > [1158770.648354] NIP: c00800000f6784fc LR: c00800000f6784f8 CTR: c000000000d746c0 > [1158770.648357] REGS: c000200089afe9a0 TRAP: 0700 Tainted: G W (6.1.0-0.deb11.7-powerpc64le Debian 6.1.20-2~bpo11+1a~test) > [1158770.648359] MSR: 9000000002029033 <SF,HV,VEC,EE,ME,IR,DR,RI,LE> CR: 28848282 XER: 20040000 > [1158770.648370] CFAR: c000000000135110 IRQMASK: 0 > GPR00: c00800000f6784f8 c000200089afec40 c00800000f7ea800 0000000000000026 > GPR04: 00000001004820c2 c000200089afea00 c000200089afe9f8 0000000000000027 > GPR08: c000200ffbfe7f98 c000000002127f90 ffffffffffffffd8 0000000026d6a6e8 > GPR12: 0000000028848282 c000200fff7f3800 5deadbeef0000122 c00000002269d000 > GPR16: c0002008c7797c40 c000200089afef17 0000000000000000 0000000000000000 > GPR20: 0000000000000000 0000000000000001 c000200008bc5a98 0000000000000001 > GPR24: 0000000000000000 c0000003c73088d0 c000200089afef17 c000000016d3a800 > GPR28: c0000003c7308800 c00000002269d000 ffffffffffffffea 0000000000000001 > [1158770.648404] NIP [c00800000f6784fc] find_free_extent+0x1d94/0x1e00 [btrfs] > [1158770.648422] LR [c00800000f6784f8] find_free_extent+0x1d90/0x1e00 [btrfs] > [1158770.648438] Call Trace: > [1158770.648440] [c000200089afec40] [c00800000f6784f8] find_free_extent+0x1d90/0x1e00 [btrfs] (unreliable) > [1158770.648457] [c000200089afed30] [c00800000f681398] btrfs_reserve_extent+0x1a0/0x2f0 [btrfs] > [1158770.648476] [c000200089afeea0] [c00800000f681bf0] btrfs_alloc_tree_block+0x108/0x670 [btrfs] > [1158770.648493] [c000200089afeff0] [c00800000f66bd68] __btrfs_cow_block+0x170/0x850 [btrfs] > [1158770.648510] [c000200089aff100] [c00800000f66c58c] btrfs_cow_block+0x144/0x288 [btrfs] > [1158770.648526] [c000200089aff1b0] [c00800000f67113c] btrfs_search_slot+0x6b4/0xcb0 [btrfs] > [1158770.648542] [c000200089aff2a0] [c00800000f679f60] lookup_inline_extent_backref+0x128/0x7c0 [btrfs] > [1158770.648559] [c000200089aff3b0] [c00800000f67b338] lookup_extent_backref+0x70/0x190 [btrfs] > [1158770.648575] [c000200089aff470] [c00800000f67b54c] __btrfs_free_extent+0xf4/0x1490 [btrfs] > [1158770.648592] [c000200089aff5a0] [c00800000f67d770] __btrfs_run_delayed_refs+0x328/0x1530 [btrfs] > [1158770.648608] [c000200089aff740] [c00800000f67ea2c] btrfs_run_delayed_refs+0xb4/0x3e0 [btrfs] > [1158770.648625] [c000200089aff800] [c00800000f699aa4] btrfs_commit_transaction+0x8c/0x12b0 [btrfs] > [1158770.648645] [c000200089aff8f0] [c00800000f6dc628] reset_balance_state+0x1c0/0x290 [btrfs] > [1158770.648667] [c000200089aff9a0] [c00800000f6e2f7c] btrfs_balance+0x1164/0x1500 [btrfs] > [1158770.648688] [c000200089affb40] [c00800000f6f8e4c] btrfs_ioctl+0x2b54/0x3100 [btrfs] > [1158770.648710] [c000200089affc80] [c00000000053be14] sys_ioctl+0x794/0x1310 > [1158770.648717] [c000200089affd70] [c00000000002af98] system_call_exception+0x138/0x250 > [1158770.648723] [c000200089affe10] [c00000000000c654] system_call_common+0xf4/0x258 > [1158770.648728] --- interrupt: c00 at 0x7fff94126800 > [1158770.648731] NIP: 00007fff94126800 LR: 0000000107e0b594 CTR: 0000000000000000 > [1158770.648733] REGS: c000200089affe80 TRAP: 0c00 Tainted: G W (6.1.0-0.deb11.7-powerpc64le Debian 6.1.20-2~bpo11+1a~test) > [1158770.648735] MSR: 900000000000d033 <SF,HV,EE,PR,ME,IR,DR,RI,LE> CR: 24002848 XER: 00000000 > [1158770.648744] IRQMASK: 0 > GPR00: 0000000000000036 00007fffc9439da0 00007fff94217100 0000000000000003 > GPR04: 00000000c4009420 00007fffc9439ee8 0000000000000000 0000000000000000 > GPR08: 00000000803c7416 0000000000000000 0000000000000000 0000000000000000 > GPR12: 0000000000000000 00007fff9467d120 0000000107e64c9c 0000000107e64d0a > GPR16: 0000000107e64d06 0000000107e64cf1 0000000107e64cc4 0000000107e64c73 > GPR20: 0000000107e64c31 0000000107e64bf1 0000000107e64be7 0000000000000000 > GPR24: 0000000000000000 00007fffc9439ee0 0000000000000003 0000000000000001 > GPR28: 00007fffc943f713 0000000000000000 00007fffc9439ee8 0000000000000000 > [1158770.648777] NIP [00007fff94126800] 0x7fff94126800 > [1158770.648779] LR [0000000107e0b594] 0x107e0b594 > [1158770.648780] --- interrupt: c00 > [1158770.648782] Instruction dump: > [1158770.648784] 3b00ffe4 e8898828 481175f5 60000000 4bfff4fc 3be00000 4bfff570 3d220000 > [1158770.648791] 7fc4f378 e8698830 4811cd95 e8410018 <0fe00000> f9c10060 f9e10068 fa010070 > [1158770.648798] ---[ end trace 0000000000000000 ]--- > [1158770.648804] BTRFS: error (device dm-2: state A) in find_free_extent_update_loop:4122: errno=-22 unknown > [1158770.648830] BTRFS info (device dm-2: state EA): forced readonly > [1158770.648833] BTRFS: error (device dm-2: state EA) in __btrfs_free_extent:3070: errno=-22 unknown > [1158770.648869] BTRFS error (device dm-2: state EA): failed to run delayed ref for logical 17838685708288 num_bytes 24576 type 184 action 2 ref_mod 1: -22 > [1158770.648888] BTRFS: error (device dm-2: state EA) in btrfs_run_delayed_refs:2144: errno=-22 unknown > [1158770.648904] BTRFS: error (device dm-2: state EA) in reset_balance_state:3599: errno=-22 unknown > --- > fs/btrfs/block-group.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c > index 4b69945755e4..bfc6310ec143 100644 > --- a/fs/btrfs/block-group.c > +++ b/fs/btrfs/block-group.c > @@ -79,8 +79,13 @@ static u64 btrfs_reduce_alloc_profile(struct btrfs_fs_info *fs_info, u64 flags) > } > allowed &= flags; > > - if (allowed & BTRFS_BLOCK_GROUP_RAID6) > + /* Select the highest-redundancy RAID level */ > + if (allowed & BTRFS_BLOCK_GROUP_RAID1C4) > + allowed = BTRFS_BLOCK_GROUP_RAID1C4; > + else if (allowed & BTRFS_BLOCK_GROUP_RAID6) > allowed = BTRFS_BLOCK_GROUP_RAID6; > + else if (allowed & BTRFS_BLOCK_GROUP_RAID1C3) > + allowed = BTRFS_BLOCK_GROUP_RAID1C3; > else if (allowed & BTRFS_BLOCK_GROUP_RAID5) > allowed = BTRFS_BLOCK_GROUP_RAID5; > else if (allowed & BTRFS_BLOCK_GROUP_RAID10)
On 6/5/23 10:54 AM, Goffredo Baroncelli wrote: > On 03/06/2023 03.57, Matt Corallo wrote: >> Changes from v1: Reordered the preference list and rewrote the commit message to be more useful. >> >> Callers of `btrfs_reduce_alloc_profile` expect it to return exactly >> one allocation profile flag, and failing to do so may ultimately >> result in a WARN_ON and remount-ro when allocating new blocks, like >> the below transaction abort on 6.1. >> >> `btrfs_reduce_alloc_profile` has two ways of determining the profile, >> first it checks if a conversion balance is currently running and >> uses the profile we're converting to. If no balance is currently >> running, it returns the max-redundancy profile which at least one >> block in the selected block group has. >> >> This works by simply checking each known allocation profile bit in >> redundancy order. However, when RAID1C3/RAID1C4 handling was added, >> `btrfs_reduce_alloc_profile` was not updated to check for the new >> flags. >> >> Because of the way it checks, if we have blocks with different >> profiles and at least one is known, that profile will be selected. >> However, if none are known we may return a flag set with multiple >> allocation profiles set. >> >> This is currently only possible when a balance from RAID1C* to the >> other RAID1C* profile is canceled after allocating at least one >> block using the new profile. > > I had to reread the code several times to understand your patch. > I am not saying that your patch is wrong, the code is ugly and not easy > to understand. > > However I have to point out that you treat the symptom than the real > cause. > > The real cause was the code that assumes that the 'allowed' contains > *only* one of BTRFS_BLOCK_GROUP_*. This was not true from a very > long time but only in a very specific case it raised an error. I mean I wouldn't call that treating the symptom - the whole point of the if tree *is* to set only one of BTRFS_BLOCK_GROUP_* on `allowed` :). But, indeed, the code is awful and brittle, as this turned up. You make a good point about missing DUP - I assume, though haven't tested, that you'd get a similar WARN_ON and remount-ro if you were to convert to/from DUP to/from the RAID1C* profiles as well. > My suggestion is to: > - explicitly add all other missing case (DUP, SINGLE....) > - add a further 'else' branch to signal an un-handled case, something like > > else { > btrfs_error( /* error message */ ); > allowed = /* safe default ??? */ > } > > Or if you are brave enough, replace the if(s) with an iterate over the > btrfs_raid_array[] taking the one with an highest priority (may be you need > to add a "priority" field to array). Indeed, I'd thought about doing this but decided adding some additional flag wasn't really worth it. Will include the fall-through WARN_ON in a new patch. > Finally, but this is definitely outside the scope of your patch, I > think that the logic used by btrfs is basically wrong: currently, when you > interrupted a balancing in a less safe direction (e.g. raid1 -> single), > the next block allocation is done in the opposite direction. More "strange" > result would be if you does several interrupted balances with different profiles... Sure, but btrfs doesn't store old balance info anywhere, and it doesn't seem worth going. It's somewhat of an edge case - further up in `btrfs_reduce_alloc_profile` we *do* check if there's a pending balance and use the target there, interrupting a balance isn't really a common thing, and while its supported its expected that you move towards finishing it sooner rather than later (and the userspace tools shove warnings in your face to remind you to do so). > And now reading the code it seems to me that if the default profile is RAID1C4, > and only *one* disk is filled, then the system go to a SINGLE profile... Why doesn't > try a RAID1C3 ? It will use the highest redundancy profile which you have in use in the given block set. BTRFS shouldn't "make up" a profile that the user didn't set, that just adds yet another profile that the user will need to balance to get rid of and move to a consistent profile. > Better would be store explicitly somewhere the "default" profile (accessible via a > sysfs filed) and their 2nd choices; eg if the user selects a RAID6 profile, the > options should be: > > $ cat /sys/fs/btrfs/<uuid>/current_profile > [raid6] raid5 single > > $ # if the user sets RAID1C4 > $ cat /sys/fs/btrfs/<uuid>/current_profile > [raid1c4] raid1c3 raid1 single > > $ # if the user sets DUP > $ cat /sys/fs/btrfs/<uuid>/current_profile > [dup] > > $ # the user sets RAID1C3, note that it is not listed anymore RAID1C4 > $ # even if an interrupted balance leaved a RAID1C4 block-group > $ cat /sys/fs/btrfs/<uuid>/current_profile > [raid1c3] raid1 single > > > TBD: after raid6, there is raid5, but then after raid5 which one would > be better: DUP or SINGLE ? > >> >> In that case, a transaction abort like the below will occur and the >> filesystem will need to be mounted with -o skip_balance to get it >> mounted rw again (but the balance cannot be resumed without a >> similar abort). >> >> Signed-off-by: Matt Corallo <blnxfsl@bluematt.me> >> >> [1158770.648155] ------------[ cut here ]------------ >> [1158770.648157] BTRFS: Transaction aborted (error -22) >> [1158770.648205] WARNING: CPU: 43 PID: 1159593 at fs/btrfs/extent-tree.c:4122 >> find_free_extent+0x1d94/0x1e00 [btrfs] >> [1158770.648242] Modules linked in: xt_tcpudp wireguard libchacha20poly1305 libcurve25519_generic >> libchacha libpoly1305 ip6_udp_tunnel udp_tunnel ipt_REJECT nf_reject_ipv4 veth nft_chain_nat >> xt_nat nf_nat xt_set xt_state xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nft_compat >> nf_tables crc32c_generic ip_set_hash_net ip_set_hash_ip ip_set nfnetlink bridge stp llc essiv >> authenc ast drm_vram_helper drm_ttm_helper ttm ofpart ipmi_powernv powernv_flash ipmi_devintf >> drm_kms_helper ipmi_msghandler mtd opal_prd syscopyarea sysfillrect sysimgblt fb_sys_fops >> i2c_algo_bit sg at24 regmap_i2c binfmt_misc drm fuse sunrpc drm_panel_orientation_quirks configfs >> ip_tables x_tables autofs4 xxhash_generic btrfs zstd_compress raid10 raid456 async_raid6_recov >> async_memcpy async_pq async_xor async_tx xor hid_generic usbhid hid raid6_pq libcrc32c raid1 raid0 >> multipath linear md_mod usb_storage dm_crypt dm_mod algif_skcipher af_alg sd_mod xhci_pci xhci_hcd >> xts ecb ctr nvme vmx_crypto gf128mul >> [1158770.648328] crc32c_vpmsum tg3 mpt3sas nvme_core t10_pi usbcore libphy crc64_rocksoft_generic >> crc64_rocksoft crc_t10dif crct10dif_generic raid_class crc64 crct10dif_common ptp pps_core >> usb_common scsi_transport_sas >> [1158770.648348] CPU: 43 PID: 1159593 Comm: btrfs Tainted: G W 6.1.0-0.deb11.7-powerpc64le >> #1 Debian 6.1.20-2~bpo11+1a~test >> [1158770.648353] Hardware name: T2P9D01 REV 1.00 POWER9 0x4e1202 opal:skiboot-bc106a0 PowerNV >> [1158770.648354] NIP: c00800000f6784fc LR: c00800000f6784f8 CTR: c000000000d746c0 >> [1158770.648357] REGS: c000200089afe9a0 TRAP: 0700 Tainted: G W >> (6.1.0-0.deb11.7-powerpc64le Debian 6.1.20-2~bpo11+1a~test) >> [1158770.648359] MSR: 9000000002029033 <SF,HV,VEC,EE,ME,IR,DR,RI,LE> CR: 28848282 XER: 20040000 >> [1158770.648370] CFAR: c000000000135110 IRQMASK: 0 >> GPR00: c00800000f6784f8 c000200089afec40 c00800000f7ea800 0000000000000026 >> GPR04: 00000001004820c2 c000200089afea00 c000200089afe9f8 0000000000000027 >> GPR08: c000200ffbfe7f98 c000000002127f90 ffffffffffffffd8 0000000026d6a6e8 >> GPR12: 0000000028848282 c000200fff7f3800 5deadbeef0000122 c00000002269d000 >> GPR16: c0002008c7797c40 c000200089afef17 0000000000000000 0000000000000000 >> GPR20: 0000000000000000 0000000000000001 c000200008bc5a98 0000000000000001 >> GPR24: 0000000000000000 c0000003c73088d0 c000200089afef17 c000000016d3a800 >> GPR28: c0000003c7308800 c00000002269d000 ffffffffffffffea 0000000000000001 >> [1158770.648404] NIP [c00800000f6784fc] find_free_extent+0x1d94/0x1e00 [btrfs] >> [1158770.648422] LR [c00800000f6784f8] find_free_extent+0x1d90/0x1e00 [btrfs] >> [1158770.648438] Call Trace: >> [1158770.648440] [c000200089afec40] [c00800000f6784f8] find_free_extent+0x1d90/0x1e00 [btrfs] >> (unreliable) >> [1158770.648457] [c000200089afed30] [c00800000f681398] btrfs_reserve_extent+0x1a0/0x2f0 [btrfs] >> [1158770.648476] [c000200089afeea0] [c00800000f681bf0] btrfs_alloc_tree_block+0x108/0x670 [btrfs] >> [1158770.648493] [c000200089afeff0] [c00800000f66bd68] __btrfs_cow_block+0x170/0x850 [btrfs] >> [1158770.648510] [c000200089aff100] [c00800000f66c58c] btrfs_cow_block+0x144/0x288 [btrfs] >> [1158770.648526] [c000200089aff1b0] [c00800000f67113c] btrfs_search_slot+0x6b4/0xcb0 [btrfs] >> [1158770.648542] [c000200089aff2a0] [c00800000f679f60] lookup_inline_extent_backref+0x128/0x7c0 >> [btrfs] >> [1158770.648559] [c000200089aff3b0] [c00800000f67b338] lookup_extent_backref+0x70/0x190 [btrfs] >> [1158770.648575] [c000200089aff470] [c00800000f67b54c] __btrfs_free_extent+0xf4/0x1490 [btrfs] >> [1158770.648592] [c000200089aff5a0] [c00800000f67d770] __btrfs_run_delayed_refs+0x328/0x1530 [btrfs] >> [1158770.648608] [c000200089aff740] [c00800000f67ea2c] btrfs_run_delayed_refs+0xb4/0x3e0 [btrfs] >> [1158770.648625] [c000200089aff800] [c00800000f699aa4] btrfs_commit_transaction+0x8c/0x12b0 [btrfs] >> [1158770.648645] [c000200089aff8f0] [c00800000f6dc628] reset_balance_state+0x1c0/0x290 [btrfs] >> [1158770.648667] [c000200089aff9a0] [c00800000f6e2f7c] btrfs_balance+0x1164/0x1500 [btrfs] >> [1158770.648688] [c000200089affb40] [c00800000f6f8e4c] btrfs_ioctl+0x2b54/0x3100 [btrfs] >> [1158770.648710] [c000200089affc80] [c00000000053be14] sys_ioctl+0x794/0x1310 >> [1158770.648717] [c000200089affd70] [c00000000002af98] system_call_exception+0x138/0x250 >> [1158770.648723] [c000200089affe10] [c00000000000c654] system_call_common+0xf4/0x258 >> [1158770.648728] --- interrupt: c00 at 0x7fff94126800 >> [1158770.648731] NIP: 00007fff94126800 LR: 0000000107e0b594 CTR: 0000000000000000 >> [1158770.648733] REGS: c000200089affe80 TRAP: 0c00 Tainted: G W >> (6.1.0-0.deb11.7-powerpc64le Debian 6.1.20-2~bpo11+1a~test) >> [1158770.648735] MSR: 900000000000d033 <SF,HV,EE,PR,ME,IR,DR,RI,LE> CR: 24002848 XER: 00000000 >> [1158770.648744] IRQMASK: 0 >> GPR00: 0000000000000036 00007fffc9439da0 00007fff94217100 0000000000000003 >> GPR04: 00000000c4009420 00007fffc9439ee8 0000000000000000 0000000000000000 >> GPR08: 00000000803c7416 0000000000000000 0000000000000000 0000000000000000 >> GPR12: 0000000000000000 00007fff9467d120 0000000107e64c9c 0000000107e64d0a >> GPR16: 0000000107e64d06 0000000107e64cf1 0000000107e64cc4 0000000107e64c73 >> GPR20: 0000000107e64c31 0000000107e64bf1 0000000107e64be7 0000000000000000 >> GPR24: 0000000000000000 00007fffc9439ee0 0000000000000003 0000000000000001 >> GPR28: 00007fffc943f713 0000000000000000 00007fffc9439ee8 0000000000000000 >> [1158770.648777] NIP [00007fff94126800] 0x7fff94126800 >> [1158770.648779] LR [0000000107e0b594] 0x107e0b594 >> [1158770.648780] --- interrupt: c00 >> [1158770.648782] Instruction dump: >> [1158770.648784] 3b00ffe4 e8898828 481175f5 60000000 4bfff4fc 3be00000 4bfff570 3d220000 >> [1158770.648791] 7fc4f378 e8698830 4811cd95 e8410018 <0fe00000> f9c10060 f9e10068 fa010070 >> [1158770.648798] ---[ end trace 0000000000000000 ]--- >> [1158770.648804] BTRFS: error (device dm-2: state A) in find_free_extent_update_loop:4122: >> errno=-22 unknown >> [1158770.648830] BTRFS info (device dm-2: state EA): forced readonly >> [1158770.648833] BTRFS: error (device dm-2: state EA) in __btrfs_free_extent:3070: errno=-22 unknown >> [1158770.648869] BTRFS error (device dm-2: state EA): failed to run delayed ref for logical >> 17838685708288 num_bytes 24576 type 184 action 2 ref_mod 1: -22 >> [1158770.648888] BTRFS: error (device dm-2: state EA) in btrfs_run_delayed_refs:2144: errno=-22 >> unknown >> [1158770.648904] BTRFS: error (device dm-2: state EA) in reset_balance_state:3599: errno=-22 unknown >> --- >> fs/btrfs/block-group.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c >> index 4b69945755e4..bfc6310ec143 100644 >> --- a/fs/btrfs/block-group.c >> +++ b/fs/btrfs/block-group.c >> @@ -79,8 +79,13 @@ static u64 btrfs_reduce_alloc_profile(struct btrfs_fs_info *fs_info, u64 flags) >> } >> allowed &= flags; >> >> - if (allowed & BTRFS_BLOCK_GROUP_RAID6) >> + /* Select the highest-redundancy RAID level */ >> + if (allowed & BTRFS_BLOCK_GROUP_RAID1C4) >> + allowed = BTRFS_BLOCK_GROUP_RAID1C4; >> + else if (allowed & BTRFS_BLOCK_GROUP_RAID6) >> allowed = BTRFS_BLOCK_GROUP_RAID6; >> + else if (allowed & BTRFS_BLOCK_GROUP_RAID1C3) >> + allowed = BTRFS_BLOCK_GROUP_RAID1C3; >> else if (allowed & BTRFS_BLOCK_GROUP_RAID5) >> allowed = BTRFS_BLOCK_GROUP_RAID5; >> else if (allowed & BTRFS_BLOCK_GROUP_RAID10) >
diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c index 4b69945755e4..bfc6310ec143 100644 --- a/fs/btrfs/block-group.c +++ b/fs/btrfs/block-group.c @@ -79,8 +79,13 @@ static u64 btrfs_reduce_alloc_profile(struct btrfs_fs_info *fs_info, u64 flags) } allowed &= flags; - if (allowed & BTRFS_BLOCK_GROUP_RAID6) + /* Select the highest-redundancy RAID level */ + if (allowed & BTRFS_BLOCK_GROUP_RAID1C4) + allowed = BTRFS_BLOCK_GROUP_RAID1C4; + else if (allowed & BTRFS_BLOCK_GROUP_RAID6) allowed = BTRFS_BLOCK_GROUP_RAID6; + else if (allowed & BTRFS_BLOCK_GROUP_RAID1C3) + allowed = BTRFS_BLOCK_GROUP_RAID1C3; else if (allowed & BTRFS_BLOCK_GROUP_RAID5) allowed = BTRFS_BLOCK_GROUP_RAID5; else if (allowed & BTRFS_BLOCK_GROUP_RAID10)
Changes from v1: Reordered the preference list and rewrote the commit message to be more useful. Callers of `btrfs_reduce_alloc_profile` expect it to return exactly one allocation profile flag, and failing to do so may ultimately result in a WARN_ON and remount-ro when allocating new blocks, like the below transaction abort on 6.1. `btrfs_reduce_alloc_profile` has two ways of determining the profile, first it checks if a conversion balance is currently running and uses the profile we're converting to. If no balance is currently running, it returns the max-redundancy profile which at least one block in the selected block group has. This works by simply checking each known allocation profile bit in redundancy order. However, when RAID1C3/RAID1C4 handling was added, `btrfs_reduce_alloc_profile` was not updated to check for the new flags. Because of the way it checks, if we have blocks with different profiles and at least one is known, that profile will be selected. However, if none are known we may return a flag set with multiple allocation profiles set. This is currently only possible when a balance from RAID1C* to the other RAID1C* profile is canceled after allocating at least one block using the new profile. In that case, a transaction abort like the below will occur and the filesystem will need to be mounted with -o skip_balance to get it mounted rw again (but the balance cannot be resumed without a similar abort). Signed-off-by: Matt Corallo <blnxfsl@bluematt.me> [1158770.648155] ------------[ cut here ]------------ [1158770.648157] BTRFS: Transaction aborted (error -22) [1158770.648205] WARNING: CPU: 43 PID: 1159593 at fs/btrfs/extent-tree.c:4122 find_free_extent+0x1d94/0x1e00 [btrfs] [1158770.648242] Modules linked in: xt_tcpudp wireguard libchacha20poly1305 libcurve25519_generic libchacha libpoly1305 ip6_udp_tunnel udp_tunnel ipt_REJECT nf_reject_ipv4 veth nft_chain_nat xt_nat nf_nat xt_set xt_state xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nft_compat nf_tables crc32c_generic ip_set_hash_net ip_set_hash_ip ip_set nfnetlink bridge stp llc essiv authenc ast drm_vram_helper drm_ttm_helper ttm ofpart ipmi_powernv powernv_flash ipmi_devintf drm_kms_helper ipmi_msghandler mtd opal_prd syscopyarea sysfillrect sysimgblt fb_sys_fops i2c_algo_bit sg at24 regmap_i2c binfmt_misc drm fuse sunrpc drm_panel_orientation_quirks configfs ip_tables x_tables autofs4 xxhash_generic btrfs zstd_compress raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor hid_generic usbhid hid raid6_pq libcrc32c raid1 raid0 multipath linear md_mod usb_storage dm_crypt dm_mod algif_skcipher af_alg sd_mod xhci_pci xhci_hcd xts ecb ctr nvme vmx_crypto gf128mul [1158770.648328] crc32c_vpmsum tg3 mpt3sas nvme_core t10_pi usbcore libphy crc64_rocksoft_generic crc64_rocksoft crc_t10dif crct10dif_generic raid_class crc64 crct10dif_common ptp pps_core usb_common scsi_transport_sas [1158770.648348] CPU: 43 PID: 1159593 Comm: btrfs Tainted: G W 6.1.0-0.deb11.7-powerpc64le #1 Debian 6.1.20-2~bpo11+1a~test [1158770.648353] Hardware name: T2P9D01 REV 1.00 POWER9 0x4e1202 opal:skiboot-bc106a0 PowerNV [1158770.648354] NIP: c00800000f6784fc LR: c00800000f6784f8 CTR: c000000000d746c0 [1158770.648357] REGS: c000200089afe9a0 TRAP: 0700 Tainted: G W (6.1.0-0.deb11.7-powerpc64le Debian 6.1.20-2~bpo11+1a~test) [1158770.648359] MSR: 9000000002029033 <SF,HV,VEC,EE,ME,IR,DR,RI,LE> CR: 28848282 XER: 20040000 [1158770.648370] CFAR: c000000000135110 IRQMASK: 0 GPR00: c00800000f6784f8 c000200089afec40 c00800000f7ea800 0000000000000026 GPR04: 00000001004820c2 c000200089afea00 c000200089afe9f8 0000000000000027 GPR08: c000200ffbfe7f98 c000000002127f90 ffffffffffffffd8 0000000026d6a6e8 GPR12: 0000000028848282 c000200fff7f3800 5deadbeef0000122 c00000002269d000 GPR16: c0002008c7797c40 c000200089afef17 0000000000000000 0000000000000000 GPR20: 0000000000000000 0000000000000001 c000200008bc5a98 0000000000000001 GPR24: 0000000000000000 c0000003c73088d0 c000200089afef17 c000000016d3a800 GPR28: c0000003c7308800 c00000002269d000 ffffffffffffffea 0000000000000001 [1158770.648404] NIP [c00800000f6784fc] find_free_extent+0x1d94/0x1e00 [btrfs] [1158770.648422] LR [c00800000f6784f8] find_free_extent+0x1d90/0x1e00 [btrfs] [1158770.648438] Call Trace: [1158770.648440] [c000200089afec40] [c00800000f6784f8] find_free_extent+0x1d90/0x1e00 [btrfs] (unreliable) [1158770.648457] [c000200089afed30] [c00800000f681398] btrfs_reserve_extent+0x1a0/0x2f0 [btrfs] [1158770.648476] [c000200089afeea0] [c00800000f681bf0] btrfs_alloc_tree_block+0x108/0x670 [btrfs] [1158770.648493] [c000200089afeff0] [c00800000f66bd68] __btrfs_cow_block+0x170/0x850 [btrfs] [1158770.648510] [c000200089aff100] [c00800000f66c58c] btrfs_cow_block+0x144/0x288 [btrfs] [1158770.648526] [c000200089aff1b0] [c00800000f67113c] btrfs_search_slot+0x6b4/0xcb0 [btrfs] [1158770.648542] [c000200089aff2a0] [c00800000f679f60] lookup_inline_extent_backref+0x128/0x7c0 [btrfs] [1158770.648559] [c000200089aff3b0] [c00800000f67b338] lookup_extent_backref+0x70/0x190 [btrfs] [1158770.648575] [c000200089aff470] [c00800000f67b54c] __btrfs_free_extent+0xf4/0x1490 [btrfs] [1158770.648592] [c000200089aff5a0] [c00800000f67d770] __btrfs_run_delayed_refs+0x328/0x1530 [btrfs] [1158770.648608] [c000200089aff740] [c00800000f67ea2c] btrfs_run_delayed_refs+0xb4/0x3e0 [btrfs] [1158770.648625] [c000200089aff800] [c00800000f699aa4] btrfs_commit_transaction+0x8c/0x12b0 [btrfs] [1158770.648645] [c000200089aff8f0] [c00800000f6dc628] reset_balance_state+0x1c0/0x290 [btrfs] [1158770.648667] [c000200089aff9a0] [c00800000f6e2f7c] btrfs_balance+0x1164/0x1500 [btrfs] [1158770.648688] [c000200089affb40] [c00800000f6f8e4c] btrfs_ioctl+0x2b54/0x3100 [btrfs] [1158770.648710] [c000200089affc80] [c00000000053be14] sys_ioctl+0x794/0x1310 [1158770.648717] [c000200089affd70] [c00000000002af98] system_call_exception+0x138/0x250 [1158770.648723] [c000200089affe10] [c00000000000c654] system_call_common+0xf4/0x258 [1158770.648728] --- interrupt: c00 at 0x7fff94126800 [1158770.648731] NIP: 00007fff94126800 LR: 0000000107e0b594 CTR: 0000000000000000 [1158770.648733] REGS: c000200089affe80 TRAP: 0c00 Tainted: G W (6.1.0-0.deb11.7-powerpc64le Debian 6.1.20-2~bpo11+1a~test) [1158770.648735] MSR: 900000000000d033 <SF,HV,EE,PR,ME,IR,DR,RI,LE> CR: 24002848 XER: 00000000 [1158770.648744] IRQMASK: 0 GPR00: 0000000000000036 00007fffc9439da0 00007fff94217100 0000000000000003 GPR04: 00000000c4009420 00007fffc9439ee8 0000000000000000 0000000000000000 GPR08: 00000000803c7416 0000000000000000 0000000000000000 0000000000000000 GPR12: 0000000000000000 00007fff9467d120 0000000107e64c9c 0000000107e64d0a GPR16: 0000000107e64d06 0000000107e64cf1 0000000107e64cc4 0000000107e64c73 GPR20: 0000000107e64c31 0000000107e64bf1 0000000107e64be7 0000000000000000 GPR24: 0000000000000000 00007fffc9439ee0 0000000000000003 0000000000000001 GPR28: 00007fffc943f713 0000000000000000 00007fffc9439ee8 0000000000000000 [1158770.648777] NIP [00007fff94126800] 0x7fff94126800 [1158770.648779] LR [0000000107e0b594] 0x107e0b594 [1158770.648780] --- interrupt: c00 [1158770.648782] Instruction dump: [1158770.648784] 3b00ffe4 e8898828 481175f5 60000000 4bfff4fc 3be00000 4bfff570 3d220000 [1158770.648791] 7fc4f378 e8698830 4811cd95 e8410018 <0fe00000> f9c10060 f9e10068 fa010070 [1158770.648798] ---[ end trace 0000000000000000 ]--- [1158770.648804] BTRFS: error (device dm-2: state A) in find_free_extent_update_loop:4122: errno=-22 unknown [1158770.648830] BTRFS info (device dm-2: state EA): forced readonly [1158770.648833] BTRFS: error (device dm-2: state EA) in __btrfs_free_extent:3070: errno=-22 unknown [1158770.648869] BTRFS error (device dm-2: state EA): failed to run delayed ref for logical 17838685708288 num_bytes 24576 type 184 action 2 ref_mod 1: -22 [1158770.648888] BTRFS: error (device dm-2: state EA) in btrfs_run_delayed_refs:2144: errno=-22 unknown [1158770.648904] BTRFS: error (device dm-2: state EA) in reset_balance_state:3599: errno=-22 unknown --- fs/btrfs/block-group.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)