Message ID | cf522824a3a16e2186b43c5336b4d99cd0cd4d19.1606938211.git.josef@toxicpanda.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Cleanup error handling in relocation | expand |
On 2020/12/3 上午3:51, Josef Bacik wrote: > We need to validate that a data extent item does not have the > FULL_BACKREF flag set on it's flags. > > Signed-off-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: Qu Wenruo <wqu@suse.com> But an idea for new patch inlined below. > --- > fs/btrfs/tree-checker.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c > index 028e733e42f3..39714aeb9b36 100644 > --- a/fs/btrfs/tree-checker.c > +++ b/fs/btrfs/tree-checker.c > @@ -1283,6 +1283,11 @@ static int check_extent_item(struct extent_buffer *leaf, > key->offset, fs_info->sectorsize); > return -EUCLEAN; > } > + if (flags & BTRFS_BLOCK_FLAG_FULL_BACKREF) { > + extent_err(leaf, slot, > + "invalid extent flag, data has full backref set"); > + return -EUCLEAN; > + } Since we're already in tree-checker, another possible check is, to ensure COW tree only have one inline ref, and no keyed ref. Thanks, Qu > } > ptr = (unsigned long)(struct btrfs_extent_item *)(ei + 1); > >
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c index 028e733e42f3..39714aeb9b36 100644 --- a/fs/btrfs/tree-checker.c +++ b/fs/btrfs/tree-checker.c @@ -1283,6 +1283,11 @@ static int check_extent_item(struct extent_buffer *leaf, key->offset, fs_info->sectorsize); return -EUCLEAN; } + if (flags & BTRFS_BLOCK_FLAG_FULL_BACKREF) { + extent_err(leaf, slot, + "invalid extent flag, data has full backref set"); + return -EUCLEAN; + } } ptr = (unsigned long)(struct btrfs_extent_item *)(ei + 1);
We need to validate that a data extent item does not have the FULL_BACKREF flag set on it's flags. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- fs/btrfs/tree-checker.c | 5 +++++ 1 file changed, 5 insertions(+)