Message ID | cover.1637940049.git.dsterba@suse.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [GIT,PULL] Btrfs fixes for 5.16-rc3 | expand |
On Fri, Nov 26, 2021 at 7:42 AM David Sterba <dsterba@suse.com> wrote: > > one more fix to the lzo code, a missing put_page causing memory leaks > when some error branches are taken. > > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.16-rc2-tag Hmm. pr-tracker-bot didn't react to this one, and it wasn't obvious why. Until I started looking closer. You claim: > for you to fetch changes up to 504d851ab360dc00e2163acef2e200ea69ac800a: > > btrfs: fix the memory leak caused in lzo_compress_pages() (2021-11-26 14:32:40 +0100) but in fact it's commit daf87e953527, not as the pull request claims 504d851ab360.. And no, it's not the tag either, that was d0a295f521e2. The diffstat and the shortlog matched, so I had pulled it without noticing. But something went wrong in there in the pull request. Linus
On Fri, Nov 26, 2021 at 12:48:15PM -0800, Linus Torvalds wrote: > On Fri, Nov 26, 2021 at 7:42 AM David Sterba <dsterba@suse.com> wrote: > > > > one more fix to the lzo code, a missing put_page causing memory leaks > > when some error branches are taken. > > > > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.16-rc2-tag > > Hmm. > > pr-tracker-bot didn't react to this one, and it wasn't obvious why. > > Until I started looking closer. You claim: > > > for you to fetch changes up to 504d851ab360dc00e2163acef2e200ea69ac800a: > > > > btrfs: fix the memory leak caused in lzo_compress_pages() (2021-11-26 14:32:40 +0100) > > but in fact it's commit daf87e953527, not as the pull request claims > 504d851ab360.. > > And no, it's not the tag either, that was d0a295f521e2. > > The diffstat and the shortlog matched, so I had pulled it without > noticing. But something went wrong in there in the pull request. Possible explanation: I had problems pushing to k.org repo from work machine (ssh timeout, fetching worked) so I pushed it from a different one. The branch to pull was recreated from the same commit, with id daf87e953527b03c0b and pushed to k.org but I must have kept the previous for-5.16-rc2 branch without update when preparing the pull request mail.