| Message ID | de039f41ff596a5ccd7e65f5754af6dec1f57969.1629431777.git.anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: fix stale reference to __btrfs_alloc_chunk | expand |
On Fri, Aug 20, 2021 at 12:27:52PM +0800, Anand Jain wrote: > __btrfs_alloc_chunk() is renamed to btrfs_alloc_chunk() and then to > btrfs_create_chunk() in the commits 11c67b1a40b0 and ad6b24de1d50 > respectively. And left the stale reference to __btrfs_alloc_chunk(). > Fix them. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > > David/Nikolay, > > I commented about this earlier [1] > > [1] > https://patchwork.kernel.org/project/linux-btrfs/patch/20210705091643.3404691-1-nborisov@suse.com/ I missed that sorry and also expected that when a patch gets resent all the feedback is also incorporated. > I am fine if you want to rollup this patch to the patch (btrfs: rename > btrfs_alloc_chunk to btrfs_create_chunk) and add my RB, or add this patch > as a new one. I'll fold it into the patch plus RB, thanks.
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index f3a958a214ff..f915c1d6bb9b 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -4941,7 +4941,7 @@ static void check_raid1c34_incompat_flag(struct btrfs_fs_info *info, u64 type) } /* - * Structure used internally for __btrfs_alloc_chunk() function. + * Structure used internally for btrfs_create_chunk() function. * Wraps needed parameters. */ struct alloc_chunk_ctl { diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c index 47af1ab3bf12..90d9df131fc1 100644 --- a/fs/btrfs/zoned.c +++ b/fs/btrfs/zoned.c @@ -585,7 +585,7 @@ int btrfs_check_zoned_mode(struct btrfs_fs_info *fs_info) /* * stripe_size is always aligned to BTRFS_STRIPE_LEN in - * __btrfs_alloc_chunk(). Since we want stripe_len == zone_size, + * btrfs_create_chunk(). Since we want stripe_len == zone_size, * check the alignment here. */ if (!IS_ALIGNED(zone_size, BTRFS_STRIPE_LEN)) {
__btrfs_alloc_chunk() is renamed to btrfs_alloc_chunk() and then to btrfs_create_chunk() in the commits 11c67b1a40b0 and ad6b24de1d50 respectively. And left the stale reference to __btrfs_alloc_chunk(). Fix them. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- David/Nikolay, I commented about this earlier [1] [1] https://patchwork.kernel.org/project/linux-btrfs/patch/20210705091643.3404691-1-nborisov@suse.com/ I am fine if you want to rollup this patch to the patch (btrfs: rename btrfs_alloc_chunk to btrfs_create_chunk) and add my RB, or add this patch as a new one. Thx. fs/btrfs/volumes.c | 2 +- fs/btrfs/zoned.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)