diff mbox series

[02/17] btrfs: remove BTRFS_TOTAL_BYTES_PINNED_BATCH

Message ID e17fc6ac382df50bdc88a688274ac98dccd3144e.1663167823.git.josef@toxicpanda.com (mailing list archive)
State New, archived
Headers show
Series btrfs: initial ctree.h cleanups, simple stuff | expand

Commit Message

Josef Bacik Sept. 14, 2022, 3:06 p.m. UTC
This hasn't been used since

138a12d86574 ("btrfs: rip out btrfs_space_info::total_bytes_pinned")

so it is safe to remove.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 fs/btrfs/ctree.h | 8 --------
 1 file changed, 8 deletions(-)

Comments

Qu Wenruo Sept. 15, 2022, 9:03 a.m. UTC | #1
On 2022/9/14 23:06, Josef Bacik wrote:
> This hasn't been used since
> 
> 138a12d86574 ("btrfs: rip out btrfs_space_info::total_bytes_pinned")
> 
> so it is safe to remove.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>


Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/ctree.h | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index 0003ba925d93..3936bb95331d 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -87,14 +87,6 @@ struct btrfs_ioctl_encoded_io_args;
>   
>   #define BTRFS_DIRTY_METADATA_THRESH	SZ_32M
>   
> -/*
> - * Use large batch size to reduce overhead of metadata updates.  On the reader
> - * side, we only read it when we are close to ENOSPC and the read overhead is
> - * mostly related to the number of CPUs, so it is OK to use arbitrary large
> - * value here.
> - */
> -#define BTRFS_TOTAL_BYTES_PINNED_BATCH	SZ_128M
> -
>   #define BTRFS_MAX_EXTENT_SIZE SZ_128M
>   
>   /*
Johannes Thumshirn Sept. 15, 2022, 2:11 p.m. UTC | #2
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
diff mbox series

Patch

diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 0003ba925d93..3936bb95331d 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -87,14 +87,6 @@  struct btrfs_ioctl_encoded_io_args;
 
 #define BTRFS_DIRTY_METADATA_THRESH	SZ_32M
 
-/*
- * Use large batch size to reduce overhead of metadata updates.  On the reader
- * side, we only read it when we are close to ENOSPC and the read overhead is
- * mostly related to the number of CPUs, so it is OK to use arbitrary large
- * value here.
- */
-#define BTRFS_TOTAL_BYTES_PINNED_BATCH	SZ_128M
-
 #define BTRFS_MAX_EXTENT_SIZE SZ_128M
 
 /*