| Message ID | ee01c16f20f02230c3cfd0b266f06564fa211f62.1658812744.git.wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | U-boot: fs: add generic unaligned read offset handling | expand |
On Tue, Jul 26, 2022 at 01:22:09PM +0800, Qu Wenruo wrote: > That function is only utilized inside fat driver, unexport it. > > Signed-off-by: Qu Wenruo <wqu@suse.com> Unfortunately, the series fails CI: https://source.denx.de/u-boot/u-boot/-/jobs/478838
On 2022/8/6 05:14, Tom Rini wrote: > On Tue, Jul 26, 2022 at 01:22:09PM +0800, Qu Wenruo wrote: > >> That function is only utilized inside fat driver, unexport it. >> >> Signed-off-by: Qu Wenruo <wqu@suse.com> > > Unfortunately, the series fails CI: > https://source.denx.de/u-boot/u-boot/-/jobs/478838 > OK, it's a bug in the unsupported fses (which squashfs doesn't support) The actual read bytes is not updated. Sorry for the inconvenience. Any idea that how to run the full tests locally so I can prevent such problem? Thanks, Qu
On Sat, Aug 06, 2022 at 06:44:38AM +0800, Qu Wenruo wrote: > > > On 2022/8/6 05:14, Tom Rini wrote: > > On Tue, Jul 26, 2022 at 01:22:09PM +0800, Qu Wenruo wrote: > > > > > That function is only utilized inside fat driver, unexport it. > > > > > > Signed-off-by: Qu Wenruo <wqu@suse.com> > > > > Unfortunately, the series fails CI: > > https://source.denx.de/u-boot/u-boot/-/jobs/478838 > > > > OK, it's a bug in the unsupported fses (which squashfs doesn't support) > > The actual read bytes is not updated. > > Sorry for the inconvenience. > > Any idea that how to run the full tests locally so I can prevent such > problem? The steps in CI should be able to be followed in a regular shell. Also see doc/develop/testing.rst
diff --git a/fs/fat/fat.c b/fs/fat/fat.c index df9ea2c028fc..dcceccbcee0a 100644 --- a/fs/fat/fat.c +++ b/fs/fat/fat.c @@ -1243,8 +1243,8 @@ out_free_itr: return ret; } -int file_fat_read_at(const char *filename, loff_t pos, void *buffer, - loff_t maxsize, loff_t *actread) +static int file_fat_read_at(const char *filename, loff_t pos, void *buffer, + loff_t maxsize, loff_t *actread) { fsdata fsdata; fat_itr *itr; diff --git a/include/fat.h b/include/fat.h index bd8e450b33a3..a9756fb4cd1b 100644 --- a/include/fat.h +++ b/include/fat.h @@ -200,8 +200,6 @@ static inline u32 sect_to_clust(fsdata *fsdata, int sect) int file_fat_detectfs(void); int fat_exists(const char *filename); int fat_size(const char *filename, loff_t *size); -int file_fat_read_at(const char *filename, loff_t pos, void *buffer, - loff_t maxsize, loff_t *actread); int file_fat_read(const char *filename, void *buffer, int maxsize); int fat_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info); int fat_register_device(struct blk_desc *dev_desc, int part_no);
That function is only utilized inside fat driver, unexport it. Signed-off-by: Qu Wenruo <wqu@suse.com> --- fs/fat/fat.c | 4 ++-- include/fat.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-)