diff mbox series

[v2,2/2] btrfs/301: require_no_compress

Message ID f93722f124c528622e6f0717949a4df45738827b.1700514431.git.boris@bur.io (mailing list archive)
State New, archived
Headers show
Series btrfs/301: test fixes for squotas vs other features | expand

Commit Message

Boris Burkov Nov. 20, 2023, 9:10 p.m. UTC
btrfs/301 makes detailed size calculations to test squota edge cases
which rely on assumptions that break down with compression enabled.

Fix it by disabling the test with compression. Compression + squotas
still gets quite solid test coverage via squotas support in fsck and
normal compression enabled fstests runs.

Signed-off-by: Boris Burkov <boris@bur.io>
---
 tests/btrfs/301 | 1 +
 1 file changed, 1 insertion(+)

Comments

Filipe Manana Nov. 21, 2023, 10:50 a.m. UTC | #1
On Mon, Nov 20, 2023 at 9:10 PM Boris Burkov <boris@bur.io> wrote:
>
> btrfs/301 makes detailed size calculations to test squota edge cases
> which rely on assumptions that break down with compression enabled.
>
> Fix it by disabling the test with compression. Compression + squotas
> still gets quite solid test coverage via squotas support in fsck and
> normal compression enabled fstests runs.
>
> Signed-off-by: Boris Burkov <boris@bur.io>

Reviewed-by: Filipe Manana <fdmanana@suse.com>

> ---
>  tests/btrfs/301 | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/btrfs/301 b/tests/btrfs/301
> index dbc6d9aef..82363f717 100755
> --- a/tests/btrfs/301
> +++ b/tests/btrfs/301
> @@ -22,6 +22,7 @@ _require_cp_reflink
>  _require_btrfs_command inspect-internal dump-tree
>  _require_xfs_io_command "falloc"
>  _require_scratch_enable_simple_quota
> +_require_no_compress
>
>  subv=$SCRATCH_MNT/subv
>  nested=$SCRATCH_MNT/subv/nested
> --
> 2.42.0
>
>
diff mbox series

Patch

diff --git a/tests/btrfs/301 b/tests/btrfs/301
index dbc6d9aef..82363f717 100755
--- a/tests/btrfs/301
+++ b/tests/btrfs/301
@@ -22,6 +22,7 @@  _require_cp_reflink
 _require_btrfs_command inspect-internal dump-tree
 _require_xfs_io_command "falloc"
 _require_scratch_enable_simple_quota
+_require_no_compress
 
 subv=$SCRATCH_MNT/subv
 nested=$SCRATCH_MNT/subv/nested