Message ID | 1542200198-3017-1-git-send-email-aisheng.dong@nxp.com (mailing list archive) |
---|---|
Headers | show |
Series | clk: add imx7ulp clk support | expand |
Quoting A.s. Dong (2018-11-14 05:01:31) > This patch series intends to add imx7ulp clk support. > > i.MX7ULP Clock functions are under joint control of the System > Clock Generation (SCG) modules, Peripheral Clock Control (PCC) > modules, and Core Mode Controller (CMC)1 blocks > > The clocking scheme provides clear separation between M4 domain > and A7 domain. Except for a few clock sources shared between two > domains, such as the System Oscillator clock, the Slow IRC (SIRC), > and and the Fast IRC clock (FIRCLK), clock sources and clock > management are separated and contained within each domain. > > M4 clock management consists of SCG0, PCC0, PCC1, and CMC0 modules. > A7 clock management consists of SCG1, PCC2, PCC3, and CMC1 modules. > > Note: this series only adds A7 clock domain support as M4 clock > domain will be handled by M4 seperately. > I got: drivers/clk/imx/clk-pllv4.c:152:15: warning: symbol 'imx_clk_pllv4' was not declared. Should it be static? drivers/clk/imx/clk-pfdv2.c:166:15: warning: symbol 'imx_clk_pfdv2' was not declared. Should it be static? drivers/clk/imx/clk-divider-gate.c:174:15: warning: symbol 'imx_clk_divider_gate' was not declared. Should it be static? drivers/clk/imx/clk-composite-7ulp.c:22:15: warning: symbol 'imx7ulp_clk_composite' was not declared. Should it be static? which I can fix easily by throwing in clk.h into each file.
> -----Original Message----- > From: Stephen Boyd [mailto:sboyd@kernel.org] > Sent: Tuesday, December 4, 2018 3:32 AM > To: Aisheng DONG <aisheng.dong@nxp.com>; linux-clk@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > mturquette@baylibre.com; shawnguo@kernel.org; Anson Huang > <anson.huang@nxp.com>; Jacky Bai <ping.bai@nxp.com>; dl-linux-imx > <linux-imx@nxp.com>; Aisheng DONG <aisheng.dong@nxp.com> > Subject: Re: [PATCH V6 0/9] clk: add imx7ulp clk support > > Quoting A.s. Dong (2018-11-14 05:01:31) > > This patch series intends to add imx7ulp clk support. > > > > i.MX7ULP Clock functions are under joint control of the System Clock > > Generation (SCG) modules, Peripheral Clock Control (PCC) modules, and > > Core Mode Controller (CMC)1 blocks > > > > The clocking scheme provides clear separation between M4 domain and A7 > > domain. Except for a few clock sources shared between two domains, > > such as the System Oscillator clock, the Slow IRC (SIRC), and and the > > Fast IRC clock (FIRCLK), clock sources and clock management are > > separated and contained within each domain. > > > > M4 clock management consists of SCG0, PCC0, PCC1, and CMC0 modules. > > A7 clock management consists of SCG1, PCC2, PCC3, and CMC1 modules. > > > > Note: this series only adds A7 clock domain support as M4 clock domain > > will be handled by M4 seperately. > > > > I got: > > drivers/clk/imx/clk-pllv4.c:152:15: warning: symbol 'imx_clk_pllv4' was not > declared. Should it be static? > drivers/clk/imx/clk-pfdv2.c:166:15: warning: symbol 'imx_clk_pfdv2' was not > declared. Should it be static? > drivers/clk/imx/clk-divider-gate.c:174:15: warning: symbol > 'imx_clk_divider_gate' was not declared. Should it be static? > drivers/clk/imx/clk-composite-7ulp.c:22:15: warning: symbol > 'imx7ulp_clk_composite' was not declared. Should it be static? > > which I can fix easily by throwing in clk.h into each file. Thanks, I will double check it when I back to office. Regards Dong Aisheng
Quoting Aisheng DONG (2018-12-03 17:29:29) > > -----Original Message----- > > From: Stephen Boyd [mailto:sboyd@kernel.org] > > Sent: Tuesday, December 4, 2018 3:32 AM > > To: Aisheng DONG <aisheng.dong@nxp.com>; linux-clk@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > mturquette@baylibre.com; shawnguo@kernel.org; Anson Huang > > <anson.huang@nxp.com>; Jacky Bai <ping.bai@nxp.com>; dl-linux-imx > > <linux-imx@nxp.com>; Aisheng DONG <aisheng.dong@nxp.com> > > Subject: Re: [PATCH V6 0/9] clk: add imx7ulp clk support > > > > Quoting A.s. Dong (2018-11-14 05:01:31) > > > This patch series intends to add imx7ulp clk support. > > > > > > i.MX7ULP Clock functions are under joint control of the System Clock > > > Generation (SCG) modules, Peripheral Clock Control (PCC) modules, and > > > Core Mode Controller (CMC)1 blocks > > > > > > The clocking scheme provides clear separation between M4 domain and A7 > > > domain. Except for a few clock sources shared between two domains, > > > such as the System Oscillator clock, the Slow IRC (SIRC), and and the > > > Fast IRC clock (FIRCLK), clock sources and clock management are > > > separated and contained within each domain. > > > > > > M4 clock management consists of SCG0, PCC0, PCC1, and CMC0 modules. > > > A7 clock management consists of SCG1, PCC2, PCC3, and CMC1 modules. > > > > > > Note: this series only adds A7 clock domain support as M4 clock domain > > > will be handled by M4 seperately. > > > > > > > I got: > > > > drivers/clk/imx/clk-pllv4.c:152:15: warning: symbol 'imx_clk_pllv4' was not > > declared. Should it be static? > > drivers/clk/imx/clk-pfdv2.c:166:15: warning: symbol 'imx_clk_pfdv2' was not > > declared. Should it be static? > > drivers/clk/imx/clk-divider-gate.c:174:15: warning: symbol > > 'imx_clk_divider_gate' was not declared. Should it be static? > > drivers/clk/imx/clk-composite-7ulp.c:22:15: warning: symbol > > 'imx7ulp_clk_composite' was not declared. Should it be static? > > > > which I can fix easily by throwing in clk.h into each file. > > Thanks, I will double check it when I back to office. > No worries, I fixed it up and merged to clk-next.
On Wed, Dec 05, 2018 at 11:41:01AM -0800, Stephen Boyd wrote:
> No worries, I fixed it up and merged to clk-next.
Hi Stephen,
In order to send imx7ulp device tree for 4.21, I pulled branch
clk-imx7ulp into IMX tree to resolve the dependency on clock ID
definitions. So please keep the branch stable, thanks.
Shawn
Quoting Shawn Guo (2018-12-10 00:14:56) > On Wed, Dec 05, 2018 at 11:41:01AM -0800, Stephen Boyd wrote: > > No worries, I fixed it up and merged to clk-next. > > Hi Stephen, > > In order to send imx7ulp device tree for 4.21, I pulled branch > clk-imx7ulp into IMX tree to resolve the dependency on clock ID > definitions. So please keep the branch stable, thanks. > Ok. No problem. Thanks for letting me know.