Message ID | 1544715442-8902-1-git-send-email-aisheng.dong@nxp.com (mailing list archive) |
---|---|
Headers | show |
Series | clk: imx: add imx8qxp clock support | expand |
On Thu, Dec 13, 2018 at 03:42:46PM +0000, Aisheng Dong wrote: > This patch series adds i.MX8QXP clock support which is based > on the clock service provided by SCU firmware. > > Note: It depends on SCU driver which has already been merged by Shawn. > So this patch series could go through Shawn's tree as well. To be clear, I'm not going to take this via my tree, and it definitely needs to go through clk tree. If there is a dependency on my tree, you will likely need to wait for the dependency to land on mainline and then retry. Shawn
[...] > > Note: It depends on SCU driver which has already been merged by Shawn. > > So this patch series could go through Shawn's tree as well. > > To be clear, I'm not going to take this via my tree, and it definitely needs to go > through clk tree. If there is a dependency on my tree, you will likely need to > wait for the dependency to land on mainline and then retry. > Sorry, I should have corrected that comment. It's not depend on SCU driver which is already in the Stephen's tree. It actually depends on the resource ID definitions[1] and the centralized PM related service definitions headifle in in power domain series which is already in your tree. 1. https://patchwork.kernel.org/patch/10664125/ 2. https://patchwork.kernel.org/patch/10664137/ [2] can be fixed by defining them in clock driver. But [1] seems can't be fixed as resource ID is shared by power domain and possible many other SCU client drivers. Any suggestion? Regards Dong Aisheng > Shawn
On Fri, Dec 14, 2018 at 02:17:04AM +0000, Aisheng Dong wrote: > [...] > > > Note: It depends on SCU driver which has already been merged by Shawn. > > > So this patch series could go through Shawn's tree as well. > > > > To be clear, I'm not going to take this via my tree, and it definitely needs to go > > through clk tree. If there is a dependency on my tree, you will likely need to > > wait for the dependency to land on mainline and then retry. > > > > Sorry, I should have corrected that comment. > It's not depend on SCU driver which is already in the Stephen's tree. > It actually depends on the resource ID definitions[1] and the centralized PM > related service definitions headifle in in power domain series which is already > in your tree. > > 1. https://patchwork.kernel.org/patch/10664125/ > 2. https://patchwork.kernel.org/patch/10664137/ > > [2] can be fixed by defining them in clock driver. > But [1] seems can't be fixed as resource ID is shared by power domain > and possible many other SCU client drivers. > > Any suggestion? After [1] and [2] land on v4.21-rc1, you rebase the series on that. The dependency will be gone, right? This is what I suggested above. Shawn
> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > On Fri, Dec 14, 2018 at 02:17:04AM +0000, Aisheng Dong wrote: > > [...] > > > > Note: It depends on SCU driver which has already been merged by > Shawn. > > > > So this patch series could go through Shawn's tree as well. > > > > > > To be clear, I'm not going to take this via my tree, and it > > > definitely needs to go through clk tree. If there is a dependency > > > on my tree, you will likely need to wait for the dependency to land on > mainline and then retry. > > > > > > > Sorry, I should have corrected that comment. > > It's not depend on SCU driver which is already in the Stephen's tree. > > It actually depends on the resource ID definitions[1] and the > > centralized PM related service definitions headifle in in power domain > > series which is already in your tree. > > > > [2] can be fixed by defining them in clock driver. > > But [1] seems can't be fixed as resource ID is shared by power domain > > and possible many other SCU client drivers. > > > > Any suggestion? > > After [1] and [2] land on v4.21-rc1, you rebase the series on that. The > dependency will be gone, right? This is what I suggested above. > Okay, that may need a few more weeks. BTW, after v4.21-rc1 is out, can the mx8qxp CLK and DTS hit the final v4.21 release? As I understand, usually we don't receive new feature patch after the first RC, right? Regards Dong Aisheng > Shawn
On Fri, Dec 14, 2018 at 03:37:47AM +0000, Aisheng Dong wrote: > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > On Fri, Dec 14, 2018 at 02:17:04AM +0000, Aisheng Dong wrote: > > > [...] > > > > > Note: It depends on SCU driver which has already been merged by > > Shawn. > > > > > So this patch series could go through Shawn's tree as well. > > > > > > > > To be clear, I'm not going to take this via my tree, and it > > > > definitely needs to go through clk tree. If there is a dependency > > > > on my tree, you will likely need to wait for the dependency to land on > > mainline and then retry. > > > > > > > > > > Sorry, I should have corrected that comment. > > > It's not depend on SCU driver which is already in the Stephen's tree. > > > It actually depends on the resource ID definitions[1] and the > > > centralized PM related service definitions headifle in in power domain > > > series which is already in your tree. > > > > > > [2] can be fixed by defining them in clock driver. > > > But [1] seems can't be fixed as resource ID is shared by power domain > > > and possible many other SCU client drivers. > > > > > > Any suggestion? > > > > After [1] and [2] land on v4.21-rc1, you rebase the series on that. The > > dependency will be gone, right? This is what I suggested above. > > > > Okay, that may need a few more weeks. > BTW, after v4.21-rc1 is out, can the mx8qxp CLK and DTS hit the final v4.21 release? > As I understand, usually we don't receive new feature patch after the first RC, > right? Yes, they will have to land on 4.22 then. Shawn
> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > On Fri, Dec 14, 2018 at 03:37:47AM +0000, Aisheng Dong wrote: > > > -----Original Message----- > > > From: Shawn Guo [mailto:shawnguo@kernel.org] On Fri, Dec 14, 2018 at > > > 02:17:04AM +0000, Aisheng Dong wrote: > > > > [...] > > > > > > Note: It depends on SCU driver which has already been merged > > > > > > by > > > Shawn. > > > > > > So this patch series could go through Shawn's tree as well. > > > > > > > > > > To be clear, I'm not going to take this via my tree, and it > > > > > definitely needs to go through clk tree. If there is a > > > > > dependency on my tree, you will likely need to wait for the > > > > > dependency to land on > > > mainline and then retry. > > > > > > > > > > > > > Sorry, I should have corrected that comment. > > > > It's not depend on SCU driver which is already in the Stephen's tree. > > > > It actually depends on the resource ID definitions[1] and the > > > > centralized PM related service definitions headifle in in power > > > > domain series which is already in your tree. > > > > > > > > [2] can be fixed by defining them in clock driver. > > > > But [1] seems can't be fixed as resource ID is shared by power > > > > domain and possible many other SCU client drivers. > > > > > > > > Any suggestion? > > > > > > After [1] and [2] land on v4.21-rc1, you rebase the series on that. > > > The dependency will be gone, right? This is what I suggested above. > > > > > > > Okay, that may need a few more weeks. > > BTW, after v4.21-rc1 is out, can the mx8qxp CLK and DTS hit the final v4.21 > release? > > As I understand, usually we don't receive new feature patch after the > > first RC, right? > > Yes, they will have to land on 4.22 then. That's unfortunately and may need wait 3 more months. I really wish we can hit v4.21-rc1, then other modules driver can start their work based on it. Stephen, What's your option? Can we try the same way as Shawn did for arch and dts part? Regards Dong Aisheng > > Shawn
On Fri, Dec 14, 2018 at 04:57:46AM +0000, Aisheng Dong wrote: > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > On Fri, Dec 14, 2018 at 03:37:47AM +0000, Aisheng Dong wrote: > > > > -----Original Message----- > > > > From: Shawn Guo [mailto:shawnguo@kernel.org] On Fri, Dec 14, 2018 at > > > > 02:17:04AM +0000, Aisheng Dong wrote: > > > > > [...] > > > > > > > Note: It depends on SCU driver which has already been merged > > > > > > > by > > > > Shawn. > > > > > > > So this patch series could go through Shawn's tree as well. > > > > > > > > > > > > To be clear, I'm not going to take this via my tree, and it > > > > > > definitely needs to go through clk tree. If there is a > > > > > > dependency on my tree, you will likely need to wait for the > > > > > > dependency to land on > > > > mainline and then retry. > > > > > > > > > > > > > > > > Sorry, I should have corrected that comment. > > > > > It's not depend on SCU driver which is already in the Stephen's tree. > > > > > It actually depends on the resource ID definitions[1] and the > > > > > centralized PM related service definitions headifle in in power > > > > > domain series which is already in your tree. > > > > > > > > > > [2] can be fixed by defining them in clock driver. > > > > > But [1] seems can't be fixed as resource ID is shared by power > > > > > domain and possible many other SCU client drivers. > > > > > > > > > > Any suggestion? > > > > > > > > After [1] and [2] land on v4.21-rc1, you rebase the series on that. > > > > The dependency will be gone, right? This is what I suggested above. > > > > > > > > > > Okay, that may need a few more weeks. > > > BTW, after v4.21-rc1 is out, can the mx8qxp CLK and DTS hit the final v4.21 > > release? > > > As I understand, usually we don't receive new feature patch after the > > > first RC, right? > > > > Yes, they will have to land on 4.22 then. > > That's unfortunately and may need wait 3 more months. > I really wish we can hit v4.21-rc1, then other modules driver can start > their work based on it. You can not always expect all the pieces get in with one merge window. It's very usual in upstreaming process that the dependant parts lands in mainline with multiple release cycles. > Stephen, > What's your option? > > Can we try the same way as Shawn did for arch and dts part? In case Stephen is fine by pulling dependency from my tree, it's all on branch below, which has been pulled/queued by arm-soc folks for 4.21 merge window. git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/drivers Shawn
> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > On Fri, Dec 14, 2018 at 04:57:46AM +0000, Aisheng Dong wrote: > > > -----Original Message----- > > > From: Shawn Guo [mailto:shawnguo@kernel.org] On Fri, Dec 14, 2018 at > > > 03:37:47AM +0000, Aisheng Dong wrote: > > > > > -----Original Message----- > > > > > From: Shawn Guo [mailto:shawnguo@kernel.org] On Fri, Dec 14, > > > > > 2018 at 02:17:04AM +0000, Aisheng Dong wrote: > > > > > > [...] > > > > > > > > Note: It depends on SCU driver which has already been > > > > > > > > merged by > > > > > Shawn. > > > > > > > > So this patch series could go through Shawn's tree as well. > > > > > > > > > > > > > > To be clear, I'm not going to take this via my tree, and it > > > > > > > definitely needs to go through clk tree. If there is a > > > > > > > dependency on my tree, you will likely need to wait for the > > > > > > > dependency to land on > > > > > mainline and then retry. > > > > > > > > > > > > > > > > > > > Sorry, I should have corrected that comment. > > > > > > It's not depend on SCU driver which is already in the Stephen's tree. > > > > > > It actually depends on the resource ID definitions[1] and the > > > > > > centralized PM related service definitions headifle in in > > > > > > power domain series which is already in your tree. > > > > > > > > > > > > [2] can be fixed by defining them in clock driver. > > > > > > But [1] seems can't be fixed as resource ID is shared by power > > > > > > domain and possible many other SCU client drivers. > > > > > > > > > > > > Any suggestion? > > > > > > > > > > After [1] and [2] land on v4.21-rc1, you rebase the series on that. > > > > > The dependency will be gone, right? This is what I suggested above. > > > > > > > > > > > > > Okay, that may need a few more weeks. > > > > BTW, after v4.21-rc1 is out, can the mx8qxp CLK and DTS hit the > > > > final v4.21 > > > release? > > > > As I understand, usually we don't receive new feature patch after > > > > the first RC, right? > > > > > > Yes, they will have to land on 4.22 then. > > > > That's unfortunately and may need wait 3 more months. > > I really wish we can hit v4.21-rc1, then other modules driver can > > start their work based on it. > > You can not always expect all the pieces get in with one merge window. > It's very usual in upstreaming process that the dependant parts lands in > mainline with multiple release cycles. > Yes, i understand. Thanks for the clarification. > > Stephen, > > What's your option? > > > > Can we try the same way as Shawn did for arch and dts part? > > In case Stephen is fine by pulling dependency from my tree, it's all on branch > below, which has been pulled/queued by arm-soc folks for 4.21 merge window. > > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/drivers > Thanks Regards Dong Aisheng > Shawn
Quoting Aisheng Dong (2018-12-13 20:57:46) > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > On Fri, Dec 14, 2018 at 03:37:47AM +0000, Aisheng Dong wrote: > > > > -----Original Message----- > > > > From: Shawn Guo [mailto:shawnguo@kernel.org] On Fri, Dec 14, 2018 at > > > > 02:17:04AM +0000, Aisheng Dong wrote: > > > > > [...] > > > > > > > Note: It depends on SCU driver which has already been merged > > > > > > > by > > > > Shawn. > > > > > > > So this patch series could go through Shawn's tree as well. > > > > > > > > > > > > To be clear, I'm not going to take this via my tree, and it > > > > > > definitely needs to go through clk tree. If there is a > > > > > > dependency on my tree, you will likely need to wait for the > > > > > > dependency to land on > > > > mainline and then retry. > > > > > > > > > > > > > > > > Sorry, I should have corrected that comment. > > > > > It's not depend on SCU driver which is already in the Stephen's tree. > > > > > It actually depends on the resource ID definitions[1] and the > > > > > centralized PM related service definitions headifle in in power > > > > > domain series which is already in your tree. > > > > > > > > > > [2] can be fixed by defining them in clock driver. > > > > > But [1] seems can't be fixed as resource ID is shared by power > > > > > domain and possible many other SCU client drivers. > > > > > > > > > > Any suggestion? > > > > > > > > After [1] and [2] land on v4.21-rc1, you rebase the series on that. > > > > The dependency will be gone, right? This is what I suggested above. > > > > > > > > > > Okay, that may need a few more weeks. > > > BTW, after v4.21-rc1 is out, can the mx8qxp CLK and DTS hit the final v4.21 > > release? > > > As I understand, usually we don't receive new feature patch after the > > > first RC, right? > > > > Yes, they will have to land on 4.22 then. > > That's unfortunately and may need wait 3 more months. > I really wish we can hit v4.21-rc1, then other modules driver can start > their work based on it. > > Stephen, > What's your option? > > Can we try the same way as Shawn did for arch and dts part? > I see some options: 1. Shawn can provide the required header files in some signed tag that I can pull into clk tree and then apply these patches on top and merge it all up into clk-next. 2. I can pick any patches required for the header files the clk driver needs into clk tree and duplicate the commits in Shawn's tree. I don't see a big downside here, git manages just fine when it sees duplicate content on both sides of a merge so it's just more noise than anything else. 3. I apply the clk driver bits but nobody tries to enable the config option around it just yet. Instead, we wait for everything to meet up in linux-next via different trees and then enable compilation later. This is bad for compile testing drivers and makes it harder to bisect problems later. Probably not a big deal here for bringing in new hardware support but it might work out. 4. We all wait three months (happy new year!) but otherwise are sad that we can't figure this out.
Quoting Shawn Guo (2018-12-13 21:30:35) > > In case Stephen is fine by pulling dependency from my tree, it's all on > branch below, which has been pulled/queued by arm-soc folks for 4.21 > merge window. > > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/drivers > I can pull just the first patch from this branch and then everything will compile? That should be OK.
Quoting Stephen Boyd (2018-12-13 22:07:08) > Quoting Shawn Guo (2018-12-13 21:30:35) > > > > In case Stephen is fine by pulling dependency from my tree, it's all on > > branch below, which has been pulled/queued by arm-soc folks for 4.21 > > merge window. > > > > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/drivers > > > > I can pull just the first patch from this branch and then everything > will compile? That should be OK. > Hm.. turns out I need to pull up to 0a914a4948d4 firmware: imx: add pm svc headfile but then it all compiles fine. Ok I can do that.
> From: Stephen Boyd [mailto:sboyd@kernel.org] > Quoting Shawn Guo (2018-12-13 21:30:35) > > > > In case Stephen is fine by pulling dependency from my tree, it's all > > on branch below, which has been pulled/queued by arm-soc folks for > > 4.21 merge window. > > > > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > imx/drivers > > > > I can pull just the first patch from this branch and then everything will compile? > That should be OK. It also needs the 4th patch "firmware: imx: add pm svc headfile". But I can copy the required definitions into clk driver and clean up the original one later after merge if you think it's ok. Regards Dong Aisheng
> -----Original Message----- > From: Stephen Boyd [mailto:sboyd@kernel.org] > Quoting Stephen Boyd (2018-12-13 22:07:08) > > Quoting Shawn Guo (2018-12-13 21:30:35) > > > > > > In case Stephen is fine by pulling dependency from my tree, it's all > > > on branch below, which has been pulled/queued by arm-soc folks for > > > 4.21 merge window. > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > > imx/drivers > > > > > > > I can pull just the first patch from this branch and then everything > > will compile? That should be OK. > > > > Hm.. turns out I need to pull up to > > 0a914a4948d4 firmware: imx: add pm svc headfile > > but then it all compiles fine. Ok I can do that. Yes, it is. Really appreciate for your kind help. Regards Dong Aisheng