[v5,0/6] MSM8998 Multimedia Clock Controller

Message

Jeffrey Hugo June 12, 2019, 7:10 p.m. UTC

The multimedia clock controller (mmcc) is the main clock controller for
the multimedia subsystem and is required to enable things like display and
camera.

v5:
-handle the case where gcc uses rpmcc for xo, but the link is not specified in dt
-have gcc select rpmcc

v4:
-fix makefile to use correct config item
-pick up tags
-fix ordering of clocks and clock-names in dt
-drop MODULE_ALIAS
-wait for xo in mmcc since that was found to be useful in some debug configs

v3:
-Rebase onto linux-next to get the final version of the clk parent rewrite
series
-Moved the bindings header to the bindings patch per Rob
-Made xo manditory for GCC to work around the lack of clk orphan probe defer
to avoid the uart console glitch

v2:
-Rebased on the "Rewrite clk parent handling" series and updated to the clk init
mechanisms introduced there.
-Marked XO clk as CLK_IGNORE_UNUSED to avoid the concern about the XO going away
"incorrectly" during late init
-Corrected the name of the XO clock to "xo"
-Dropped the fake XO clock in GCC to prevent a namespace conflict
-Fully enumerated the external clocks (DSI PLLs, etc) in the DT binding
-Cleaned up the weird newlines in the added DT node
-Added DT header file to msm8998 DT for future clients

Jeffrey Hugo (6):
  dt-bindings: clock: Document external clocks for MSM8998 gcc
  arm64: dts: msm8998: Add xo clock to gcc node
  clk: qcom: smd: Add XO clock for MSM8998
  dt-bindings: clock: Add support for the MSM8998 mmcc
  clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver
  arm64: dts: qcom: msm8998: Add mmcc node

 .../devicetree/bindings/clock/qcom,gcc.txt    |   10 +
 .../devicetree/bindings/clock/qcom,mmcc.txt   |   21 +
 arch/arm64/boot/dts/qcom/msm8998.dtsi         |   16 +
 drivers/clk/qcom/Kconfig                      |    9 +
 drivers/clk/qcom/Makefile                     |    1 +
 drivers/clk/qcom/clk-smd-rpm.c                |   24 +-
 drivers/clk/qcom/gcc-msm8998.c                |   29 +-
 drivers/clk/qcom/mmcc-msm8998.c               | 2915 +++++++++++++++++
 include/dt-bindings/clock/qcom,mmcc-msm8998.h |  210 ++
 9 files changed, 3214 insertions(+), 21 deletions(-)
 create mode 100644 drivers/clk/qcom/mmcc-msm8998.c
 create mode 100644 include/dt-bindings/clock/qcom,mmcc-msm8998.h

Comments

Jeffrey Hugo June 19, 2019, 3:45 p.m. UTC | #1

On 6/12/2019 1:10 PM, Jeffrey Hugo wrote:
> The multimedia clock controller (mmcc) is the main clock controller for
> the multimedia subsystem and is required to enable things like display and
> camera.
> 
> v5:
> -handle the case where gcc uses rpmcc for xo, but the link is not specified in dt
> -have gcc select rpmcc
> 
> v4:
> -fix makefile to use correct config item
> -pick up tags
> -fix ordering of clocks and clock-names in dt
> -drop MODULE_ALIAS
> -wait for xo in mmcc since that was found to be useful in some debug configs
> 
> v3:
> -Rebase onto linux-next to get the final version of the clk parent rewrite
> series
> -Moved the bindings header to the bindings patch per Rob
> -Made xo manditory for GCC to work around the lack of clk orphan probe defer
> to avoid the uart console glitch
> 
> v2:
> -Rebased on the "Rewrite clk parent handling" series and updated to the clk init
> mechanisms introduced there.
> -Marked XO clk as CLK_IGNORE_UNUSED to avoid the concern about the XO going away
> "incorrectly" during late init
> -Corrected the name of the XO clock to "xo"
> -Dropped the fake XO clock in GCC to prevent a namespace conflict
> -Fully enumerated the external clocks (DSI PLLs, etc) in the DT binding
> -Cleaned up the weird newlines in the added DT node
> -Added DT header file to msm8998 DT for future clients
> 
> Jeffrey Hugo (6):
>    dt-bindings: clock: Document external clocks for MSM8998 gcc
>    arm64: dts: msm8998: Add xo clock to gcc node
>    clk: qcom: smd: Add XO clock for MSM8998
>    dt-bindings: clock: Add support for the MSM8998 mmcc
>    clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver
>    arm64: dts: qcom: msm8998: Add mmcc node
> 
>   .../devicetree/bindings/clock/qcom,gcc.txt    |   10 +
>   .../devicetree/bindings/clock/qcom,mmcc.txt   |   21 +
>   arch/arm64/boot/dts/qcom/msm8998.dtsi         |   16 +
>   drivers/clk/qcom/Kconfig                      |    9 +
>   drivers/clk/qcom/Makefile                     |    1 +
>   drivers/clk/qcom/clk-smd-rpm.c                |   24 +-
>   drivers/clk/qcom/gcc-msm8998.c                |   29 +-
>   drivers/clk/qcom/mmcc-msm8998.c               | 2915 +++++++++++++++++
>   include/dt-bindings/clock/qcom,mmcc-msm8998.h |  210 ++
>   9 files changed, 3214 insertions(+), 21 deletions(-)
>   create mode 100644 drivers/clk/qcom/mmcc-msm8998.c
>   create mode 100644 include/dt-bindings/clock/qcom,mmcc-msm8998.h
> 

Stephen, is there any chance for this series to make 5.3?