[0/5] clk: zynqmp: fix CLK_FRAC and various cleanups

Message

Michael Tretter March 12, 2019, 11 a.m. UTC

Hello,

These are various patches for the ZynqMP clock driver.

Patch 1 fixes an erroneous test for the CLK_FRAC flag.

Patch 2 fixes a wrong function name in the kernel-doc. However, I think most
of the kernel-doc for the static functions is pretty useless/misleading and
maybe instead of fixing, we should just remove it.

Patches 3 to 5 are cleanup and refactoring and make the macros that are used
to handle the responses from the firmware more consistent.

Michael

Michael Tretter (5):
  clk: zynqmp: fix check for fractional clock
  clk: zynqmp: fix doc of __zynqmp_clock_get_parents
  clk: zynqmp: do not export zynqmp_clk_register_mux
  clk: zynqmp: cleanup sizes of firmware responses
  clk: zynqmp: make field definitions of query responses consistent

 drivers/clk/zynqmp/clk-mux-zynqmp.c |  1 -
 drivers/clk/zynqmp/clk-zynqmp.h     |  6 ---
 drivers/clk/zynqmp/clkc.c           | 71 +++++++++++++++--------------
 drivers/clk/zynqmp/divider.c        |  2 +-
 4 files changed, 38 insertions(+), 42 deletions(-)

Comments

Michal Simek March 13, 2019, 2:49 p.m. UTC | #1

On 12. 03. 19 12:00, Michael Tretter wrote:
> Hello,
> 
> These are various patches for the ZynqMP clock driver.
> 
> Patch 1 fixes an erroneous test for the CLK_FRAC flag.
> 
> Patch 2 fixes a wrong function name in the kernel-doc. However, I think most
> of the kernel-doc for the static functions is pretty useless/misleading and
> maybe instead of fixing, we should just remove it.
> 
> Patches 3 to 5 are cleanup and refactoring and make the macros that are used
> to handle the responses from the firmware more consistent.
> 
> Michael
> 
> Michael Tretter (5):
>   clk: zynqmp: fix check for fractional clock
>   clk: zynqmp: fix doc of __zynqmp_clock_get_parents
>   clk: zynqmp: do not export zynqmp_clk_register_mux
>   clk: zynqmp: cleanup sizes of firmware responses
>   clk: zynqmp: make field definitions of query responses consistent
> 
>  drivers/clk/zynqmp/clk-mux-zynqmp.c |  1 -
>  drivers/clk/zynqmp/clk-zynqmp.h     |  6 ---
>  drivers/clk/zynqmp/clkc.c           | 71 +++++++++++++++--------------
>  drivers/clk/zynqmp/divider.c        |  2 +-
>  4 files changed, 38 insertions(+), 42 deletions(-)
> 

Jolly: Please take a look at these patches.

M