| Message ID | 20220602080344.208702-1-martin@kaiser.cx (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: imx25: print silicon revision, support 1.2 | expand |
Resurrect the unused function to print the imx25 silicon revision at startup. It's been a month since I sent v2. I'm resending the series, hoping to get a response this time. Thanks in advance. changes in v3: - rebase against today's linux-next changes in v2: - drop the patch about silicon revision 1.2. It has already been merged by Shawn Guo. - send the changeset to the clk maintainers Martin Kaiser (2): clk: imx25: print silicon revision during init clk: imx25: make __mx25_clocks_init return void drivers/clk/imx/clk-imx25.c | 5 +++-- include/soc/imx/revision.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-)
Resurrect the unused function to print the imx25 silicon revision at startup. Now that 6.0-rc1 is out, I hope that the clk maintainers have a moment to review this simple patch set ;-) changes in v4: - rebase against today's linux-next - add Fabio's Reviewed-by tags changes in v3: - rebase against today's linux-next changes in v2: - drop the patch about silicon revision 1.2. It has already been merged by Shawn Guo. - send the changeset to the clk maintainers Martin Kaiser (2): clk: imx25: print silicon revision during init clk: imx25: make __mx25_clocks_init return void drivers/clk/imx/clk-imx25.c | 5 +++-- include/soc/imx/revision.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-)
Resurrect the unused function to print the imx25 silicon revision at startup. This patchset has been mentioned in a discussion today. Let's bring it to the attention of the clk maintainers again. Thanks & best regards, Martin changes in v5: - rebase against today's linux-next changes in v4: - rebase against today's linux-next - add Fabio's Reviewed-by tags changes in v3: - rebase against today's linux-next changes in v2: - drop the patch about silicon revision 1.2. It has already been merged by Shawn Guo. - send the changeset to the clk maintainers Martin Kaiser (2): clk: imx25: print silicon revision during init clk: imx25: make __mx25_clocks_init return void drivers/clk/imx/clk-imx25.c | 5 +++-- include/soc/imx/revision.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-)
On Wed, May 17, 2023, at 17:39, Martin Kaiser wrote: > Resurrect the unused function to print the imx25 silicon revision at > startup. > > This patchset has been mentioned in a discussion today. Let's bring it to the > attention of the clk maintainers again. Looks good to me, and fixes the warning about the function having no prototype, so Acked-by: Arnd Bergmann <arnd@arndb.de>
Resurrect the unused function to print the imx25 silicon revision at startup. This patch set is blocking Arnd's work on enabling -Werror=missing-prototypes. I'd really appreciate a response from the clk maintainers if these (trivial) patches are ok. Thanks, Martin changes in v6: - rebase against today's linux-next - add Acked-by from Arnd changes in v5: - rebase against today's linux-next changes in v4: - rebase against today's linux-next - add Fabio's Reviewed-by tags changes in v3: - rebase against today's linux-next changes in v2: - drop the patch about silicon revision 1.2. It has already been merged by Shawn Guo. - send the changeset to the clk maintainers Martin Kaiser (2): clk: imx25: print silicon revision during init clk: imx25: make __mx25_clocks_init return void drivers/clk/imx/clk-imx25.c | 5 +++-- include/soc/imx/revision.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-)
Quoting Martin Kaiser (2023-07-30 09:39:26) > Resurrect the unused function to print the imx25 silicon revision at > startup. > > This patch set is blocking Arnd's work on enabling -Werror=missing-prototypes. > > I'd really appreciate a response from the clk maintainers if these (trivial) > patches are ok. You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has some filter that looks for linux-clk@vger and linux-imx. Also, please don't send series replies to previous rounds. It buries the patches deep in my MUA and my scripts don't work well to apply patches when they're sent like that. I presume that Abel will pick the patches up? Or do you want to land them through Arnd's tree? Either way feel free to add my acked-by Acked-by: Stephen Boyd <sboyd@kernel.org>
Stephen Boyd (sboyd@kernel.org) wrote: > You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has > some filter that looks for linux-clk@vger and linux-imx. > Also, please don't send series replies to previous rounds. It buries the > patches deep in my MUA and my scripts don't work well to apply patches > when they're sent like that. > I presume that Abel will pick the patches up? Or do you want to land > them through Arnd's tree? Either way feel free to add my acked-by > Acked-by: Stephen Boyd <sboyd@kernel.org> Thanks for responding, Stephen. Ok, understood. I'll resend with Cc linux-imx@nxp.com and without the reply to previous versions. Arnd, are you ok with taking these patches through your tree as suggested by Stephen? Thanks, Martin
On Wed, Aug 02, 2023 at 08:38:49PM +0200, Martin Kaiser wrote: > Stephen Boyd (sboyd@kernel.org) wrote: > > > You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has > > some filter that looks for linux-clk@vger and linux-imx. > > > Also, please don't send series replies to previous rounds. It buries the > > patches deep in my MUA and my scripts don't work well to apply patches > > when they're sent like that. > > > I presume that Abel will pick the patches up? Or do you want to land > > them through Arnd's tree? Either way feel free to add my acked-by > > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > Thanks for responding, Stephen. > > Ok, understood. I'll resend with Cc linux-imx@nxp.com and without the > reply to previous versions. > > Arnd, are you ok with taking these patches through your tree as > suggested by Stephen? I prefer to have Abel apply the patches through clk tree rather than arm-soc tree, unless there is a good reason for them to go via the latter. Shawn
Shawn Guo (shawnguo@kernel.org) wrote: > I prefer to have Abel apply the patches through clk tree rather than > arm-soc tree, unless there is a good reason for them to go via the > latter. ok with me. I'd be happy to get this sorted (one way or another) so that Arnd can enable -Werror=missing-prototypes for 6.6. Abel, could you pick up these patches? Thanks, Martin