From patchwork Fri Sep 9 19:26:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 12972079 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 424A9ECAAD3 for ; Fri, 9 Sep 2022 19:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbiIIT0b (ORCPT ); Fri, 9 Sep 2022 15:26:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbiIIT03 (ORCPT ); Fri, 9 Sep 2022 15:26:29 -0400 Received: from mail.baikalelectronics.com (mail.baikalelectronics.com [87.245.175.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 61A31F16F9; Fri, 9 Sep 2022 12:26:28 -0700 (PDT) Received: from mail (mail.baikal.int [192.168.51.25]) by mail.baikalelectronics.com (Postfix) with ESMTP id ACE5DDB9; Fri, 9 Sep 2022 22:30:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.com ACE5DDB9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1662751816; bh=g3tHAeUb2qE1+a07trhmVGDFh6ezzxiC7uRxZ8bTL4g=; h=From:To:CC:Subject:Date:From; b=btBSHX0HKbRFjMsKj69yQuloBdfrzPBwlUMg9TbrhHIU76VJwAx5pn4Supd2cWmSM NzKifO7a8uq6FTkYiKAOm0CVcL81FVMN8fqYbnVo9Y+jIVp9N/L1IC1w7uKzu1kd/J 4B0L8ZnwNpObhSEtrOpd7JCQGTrifWy2k2kjH/sg= Received: from localhost (192.168.168.10) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 9 Sep 2022 22:26:27 +0300 From: Serge Semin To: Stephen Boyd , Michael Turquette CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Philipp Zabel , Krzysztof Kozlowski , Krzysztof Kozlowski , Thomas Bogendoerfer , , , Subject: [PATCH RESEND v11 0/8] clk/resets: baikal-t1: Add DDR/PCIe resets and xGMAC/SATA fixes Date: Fri, 9 Sep 2022 22:26:08 +0300 Message-ID: <20220909192616.16542-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org @Stephen, @Michael It has been over seven months since the first series submission for review. Moreover the reset-part has already got @Philipp's ab tag. Please merge it in. Short summary regarding this patchset. The series starts from fixing of the clocks glitching cause by the Renesas 5P49V6901 chip in some circumstances. Afterwards a few more modifications are introduced to finally finish the Baikal-T1 CCU unit support up and prepare the code before adding the Baikal-T1 PCIe/xGMAC support. First of all it turned out I specified wrong DW xGMAC PTP reference clock divider in my initial patches. It must be 8, not 10. Secondly I was wrong to add a joint xGMAC Ref and PTP clock instead of having them separately defined. The SoC manual describes these clocks as separate fixed clock wrappers. Finally in order to close the SoC clock/reset support up we need to add the DDR and PCIe interfaces reset controls support. It's done in two steps. First I've moved the reset-controls-related code into a dedicated module. Then the DDR/PCIe reset-control functionality is added. As the series finalization we've decided to convert the Baikal-T1 clock/reset source drivers to mainly being the platform device driver and pre-initialize the basic clocks only at the early kernel boot stages. Link: https://lore.kernel.org/linux-pci/20220324010905.15589-1-Sergey.Semin@baikalelectronics.ru/ Changelog v2: - Resubmit the series with adding @Philipp to the list of the recipients. Link: https://lore.kernel.org/linux-pci/20220330144320.27039-1-Sergey.Semin@baikalelectronics.ru/ Changelog v3: - No comments. Just resend the series. - Rebased from v5.17 onto v5.18-rc3. Link: https://lore.kernel.org/linux-clk/20220503205722.24755-1-Sergey.Semin@baikalelectronics.ru/ Changelog v4: - Completely split the CCU Dividers and Resets functionality up. (@Stephen) - Add a new fixes patch: "clk: baikal-t1: Actually enable SATA internal ref clock". - Add a new fixes patch: "reset: Fix devm bulk optional exclusive control getter". - Add a new fixes patch: "clk: vc5: Fix 5P49V6901 outputs disabling when enabling FOD". - Add a new feagure patch: "clk: baikal-t1: Convert to platform device driver". - Change the internal clock ID to the XGMAC-referred name. - Rebase onto the kernel v5.18. Link: https://lore.kernel.org/lkml/20220610072124.8714-1-Sergey.Semin@baikalelectronics.ru/ Changelog v5: - Just resend. - Rebase onto the kernel v5.19-rcX. Link: https://lore.kernel.org/linux-clk/20220624141853.7417-1-Sergey.Semin@baikalelectronics.ru/ Changelog v6: - Drop the patch [PATCH RESEND v5 1/8] reset: Fix devm bulk optional exclusive control getter since it has already been accepted by @Philipp. - Refactor the reset-control code to support the linear reset IDs only. (@Philipp) - Combine the reset-related code into a single file. (@Philipp) - Drop CCU_DIV_RST_MAP() macro. It's no longer used. Link: https://lore.kernel.org/linux-clk/20220708192725.9501-1-Sergey.Semin@baikalelectronics.ru/ Changelog v7: - Fix "Alignment should match open parenthesis" warning for the pr_err() method invocations. (@Philipp) - Drop empty line from the sys_rst_info structure initialization block. (@Philipp) Link: https://lore.kernel.org/linux-clk/20220711154433.15415-1-Sergey.Semin@baikalelectronics.ru/ Changelog v8: - Fix "sef-deasserted" spelling in the CLK_BT1_CCU_RST config help text. (@Randy) Link: https://lore.kernel.org/linux-clk/20220712121505.5671-1-Sergey.Semin@baikalelectronics.ru Changelog v9: - Just resend. Link: https://lore.kernel.org/linux-clk/20220728105736.8266-1-Sergey.Semin@baikalelectronics.ru/ Changelog v10: - Just resend. - Rebase onto the kernel 6.0-rc2. - Drop the already merged in patch: [PATCH RESEND v5 1/8] reset: Fix devm bulk optional exclusive control getter Link: https://lore.kernel.org/linux-clk/20220822182934.23734-1-Sergey.Semin@baikalelectronics.ru/ Changelog v11: - Move the DT-related change to a separate patch: [PATCH v11 6/8] dt-bindings: clk: baikal-t1: Add DDR/PCIe reset IDs (@Krzysztof) - Just resend. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: Philipp Zabel Cc: Krzysztof Kozlowski Cc: Krzysztof Kozlowski Cc: Thomas Bogendoerfer Cc: linux-clk@vger.kernel.org Cc: linux-mips@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (8): clk: vc5: Fix 5P49V6901 outputs disabling when enabling FOD clk: baikal-t1: Fix invalid xGMAC PTP clock divider clk: baikal-t1: Add shared xGMAC ref/ptp clocks internal parent clk: baikal-t1: Add SATA internal ref clock buffer clk: baikal-t1: Move reset-controls code into a dedicated module dt-bindings: clk: baikal-t1: Add DDR/PCIe reset IDs clk: baikal-t1: Add DDR/PCIe directly controlled resets support clk: baikal-t1: Convert to platform device driver drivers/clk/baikal-t1/Kconfig | 12 +- drivers/clk/baikal-t1/Makefile | 1 + drivers/clk/baikal-t1/ccu-div.c | 84 +++++++-- drivers/clk/baikal-t1/ccu-div.h | 17 +- drivers/clk/baikal-t1/ccu-pll.h | 8 + drivers/clk/baikal-t1/ccu-rst.c | 217 +++++++++++++++++++++++ drivers/clk/baikal-t1/ccu-rst.h | 67 +++++++ drivers/clk/baikal-t1/clk-ccu-div.c | 264 ++++++++++++++++------------ drivers/clk/baikal-t1/clk-ccu-pll.c | 129 +++++++++++--- drivers/clk/clk-versaclock5.c | 2 +- include/dt-bindings/reset/bt1-ccu.h | 9 + 11 files changed, 649 insertions(+), 161 deletions(-) create mode 100644 drivers/clk/baikal-t1/ccu-rst.c create mode 100644 drivers/clk/baikal-t1/ccu-rst.h