mbox series

[v2,0/2] clk/mediatek: Adjustments for MSDC rate accuracy

Message ID 20230516135205.372951-1-angelogioacchino.delregno@collabora.com (mailing list archive)
Headers show
Series clk/mediatek: Adjustments for MSDC rate accuracy | expand

Message

AngeloGioacchino Del Regno May 16, 2023, 1:52 p.m. UTC
Changes in v2:
  - Extended the changes in this series to MT8365 clocks

This series stops unconditionally forcing CLK_SET_RATE_PARENT on
MediaTek muxes, as that should be set in the clock driver for each
clock requiring it, and removes CLK_SET_PARENT from all MSDC core
clocks to allow mtk-sd to select the right clock parent when doing
mclk setting, improving the rate accuracy and avoiding both under
and overclocks of the eMMC/SD/SDIO card, both improving performance
and stability of the attached storage.

This series was successfully tested on MT8173, MT8192, MT8195.

AngeloGioacchino Del Regno (2):
  clk: mediatek: mux: Stop forcing CLK_SET_RATE_PARENT flag
  clk: mediatek: Remove CLK_SET_PARENT from all MSDC core clocks

 drivers/clk/mediatek/clk-mt6765.c          | 20 +++++-----
 drivers/clk/mediatek/clk-mt6779.c          | 24 +++++------
 drivers/clk/mediatek/clk-mt7981-topckgen.c | 12 +++---
 drivers/clk/mediatek/clk-mt7986-topckgen.c | 12 +++---
 drivers/clk/mediatek/clk-mt8173-topckgen.c | 24 +++++------
 drivers/clk/mediatek/clk-mt8183.c          | 22 ++++++-----
 drivers/clk/mediatek/clk-mt8186-topckgen.c | 24 +++++------
 drivers/clk/mediatek/clk-mt8188-topckgen.c | 40 +++++++++++--------
 drivers/clk/mediatek/clk-mt8192.c          | 23 +++++------
 drivers/clk/mediatek/clk-mt8195-topckgen.c | 46 +++++++++++++---------
 drivers/clk/mediatek/clk-mt8365.c          | 38 +++++++++---------
 drivers/clk/mediatek/clk-mux.c             |  2 +-
 12 files changed, 155 insertions(+), 132 deletions(-)

Comments

Alexandre Mergnat May 17, 2023, 4:52 p.m. UTC | #1
On 16/05/2023 15:52, AngeloGioacchino Del Regno wrote:
> Changes in v2:
>    - Extended the changes in this series to MT8365 clocks
> 
> This series stops unconditionally forcing CLK_SET_RATE_PARENT on
> MediaTek muxes, as that should be set in the clock driver for each
> clock requiring it, and removes CLK_SET_PARENT from all MSDC core
> clocks to allow mtk-sd to select the right clock parent when doing
> mclk setting, improving the rate accuracy and avoiding both under
> and overclocks of the eMMC/SD/SDIO card, both improving performance
> and stability of the attached storage.
> 
> This series was successfully tested on MT8173, MT8192, MT8195.
> 
> AngeloGioacchino Del Regno (2):
>    clk: mediatek: mux: Stop forcing CLK_SET_RATE_PARENT flag
>    clk: mediatek: Remove CLK_SET_PARENT from all MSDC core clocks
> 
>   drivers/clk/mediatek/clk-mt6765.c          | 20 +++++-----
>   drivers/clk/mediatek/clk-mt6779.c          | 24 +++++------
>   drivers/clk/mediatek/clk-mt7981-topckgen.c | 12 +++---
>   drivers/clk/mediatek/clk-mt7986-topckgen.c | 12 +++---
>   drivers/clk/mediatek/clk-mt8173-topckgen.c | 24 +++++------
>   drivers/clk/mediatek/clk-mt8183.c          | 22 ++++++-----
>   drivers/clk/mediatek/clk-mt8186-topckgen.c | 24 +++++------
>   drivers/clk/mediatek/clk-mt8188-topckgen.c | 40 +++++++++++--------
>   drivers/clk/mediatek/clk-mt8192.c          | 23 +++++------
>   drivers/clk/mediatek/clk-mt8195-topckgen.c | 46 +++++++++++++---------
>   drivers/clk/mediatek/clk-mt8365.c          | 38 +++++++++---------
>   drivers/clk/mediatek/clk-mux.c             |  2 +-
>   12 files changed, 155 insertions(+), 132 deletions(-)
> 

I will try to test it next week on MT8365 SoC.