[RESEND,v6,0/7] Add PLL clocks driver and syscon for StarFive JH7110 SoC

Message

Xingyu Wu July 4, 2023, 6:46 a.m. UTC

[Resending because it has a error about examples in syscon bingdings
and has to be fixed.]

This patch serises are to add PLL clocks driver and providers by writing
and reading syscon registers for the StarFive JH7110 RISC-V SoC. And add 
documentation and nodes to describe StarFive System Controller(syscon)
Registers. This patch serises are based on Linux 6.4.

PLLs are high speed, low jitter frequency synthesizers in JH7110.
Each PLL clock works in integer mode or fraction mode by some dividers,
and the dividers are set in several syscon registers.
The formula for calculating frequency is: 
Fvco = Fref * (NI + NF) / M / Q1

The first patch adds docunmentation to describe PLL clock bindings,
and the second patch adds documentation to decribe syscon registers.
The patch 3 modifies the SYSCRG dibindings and adds PLL clock inputs.
The patch 4 adds driver to support PLL clocks for JH7110.
The patch 5 modifies the system clock driver and can select the PLL clock
source from PLL clocks driver. And the patch 6 adds the 
stg/sys/aon syscon nodes for JH7110 SoC. The last patch modifies the 
syscrg node in JH7110 dts file.

Changes since v5: 
- Rebased on Linux 6.4.
- Patch 1 fixed some grammatical mistake.
- Patch 2 added the selection about properties from different syscon
  modules and madethe example completed.
- Patch 3 dropped the 'optional' PLL clocks.

v5: https://lore.kernel.org/all/[e-mail]/

Changes since v4: 
- Rebased on Linux 6.4-rc6.
- Patch 2 dropped the example node about sys-syscon.
- Patch 3 used PLL clocks as one of optional items in SYSCRG bindings.
- Patch 4 used the patch instead about PLL clocks driver from Emil.
- Patch 5 retained the fixed factor PLL clocks as the optional source
  about PLL clocks in SYSCRG clock driver.
- Patch 6 added the child node clock-controller as the complete
  sys-syscon node and patch 7 dropped this part.

v4: https://lore.kernel.org/all/[e-mail]/

Changes since v3: 
- Rebased on Linux 6.4-rc1.
- Dropped the 'power-controller' property and used 'power-domain-cells'
  instead in syscon binding.
- Used the data by of_device_id to get the syscon registers'
  configuration include offset, mask and shift.

v3: https://lore.kernel.org/all/[e-mail]/

Changes since v2: 
- Rebased on latest JH7110 basic clock drivers.
- Added the complete documentation to describe syscon register.
- Added syscon node in JH7110 dts file.
- Modified the clock rate selection to match the closest rate in
  PLL driver when setting rate.

v2: https://lore.kernel.org/all/[e-mail]/

Changes since v1:
- Changed PLL clock node to be child of syscon node in dts.
- Modifed the definitions and names of function in PLL clock driver.
- Added commit to update syscon and syscrg dt-bindings.

v1: https://lore.kernel.org/all/[e-mail]/

William Qiu (2):
  dt-bindings: soc: starfive: Add StarFive syscon module
  riscv: dts: starfive: jh7110: Add syscon nodes

Xingyu Wu (5):
  dt-bindings: clock: Add StarFive JH7110 PLL clock generator
  dt-bindings: clock: jh7110-syscrg: Add PLL clock inputs
  clk: starfive: Add StarFive JH7110 PLL clock driver
  clk: starfive: jh7110-sys: Add PLL clocks source from DTS
  riscv: dts: starfive: jh7110: Add PLL clocks source in SYSCRG node

 .../bindings/clock/starfive,jh7110-pll.yaml   |  46 ++
 .../clock/starfive,jh7110-syscrg.yaml         |  18 +-
 .../soc/starfive/starfive,jh7110-syscon.yaml  |  93 ++++
 MAINTAINERS                                   |  13 +
 arch/riscv/boot/dts/starfive/jh7110.dtsi      |  30 +-
 drivers/clk/starfive/Kconfig                  |   9 +
 drivers/clk/starfive/Makefile                 |   1 +
 .../clk/starfive/clk-starfive-jh7110-pll.c    | 507 ++++++++++++++++++
 .../clk/starfive/clk-starfive-jh7110-sys.c    |  45 +-
 .../dt-bindings/clock/starfive,jh7110-crg.h   |   6 +
 10 files changed, 746 insertions(+), 22 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-pll.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
 create mode 100644 drivers/clk/starfive/clk-starfive-jh7110-pll.c

Comments

Conor Dooley July 4, 2023, 10:29 p.m. UTC | #1

Emil,

On Tue, Jul 04, 2023 at 02:46:03PM +0800, Xingyu Wu wrote:
> [Resending because it has a error about examples in syscon bingdings
> and has to be fixed.]
> 
> This patch serises are to add PLL clocks driver and providers by writing
> and reading syscon registers for the StarFive JH7110 RISC-V SoC. And add 
> documentation and nodes to describe StarFive System Controller(syscon)
> Registers. This patch serises are based on Linux 6.4.

Could you take a look at this series when you get a chance, please?
Would be good to finally get it merged since the syscon bits are a dep
for a few other things :)

Thanks!

Conor.

> William Qiu (2):
>   dt-bindings: soc: starfive: Add StarFive syscon module
>   riscv: dts: starfive: jh7110: Add syscon nodes
> 
> Xingyu Wu (5):
>   dt-bindings: clock: Add StarFive JH7110 PLL clock generator
>   dt-bindings: clock: jh7110-syscrg: Add PLL clock inputs
>   clk: starfive: Add StarFive JH7110 PLL clock driver
>   clk: starfive: jh7110-sys: Add PLL clocks source from DTS
>   riscv: dts: starfive: jh7110: Add PLL clocks source in SYSCRG node
> 
>  .../bindings/clock/starfive,jh7110-pll.yaml   |  46 ++
>  .../clock/starfive,jh7110-syscrg.yaml         |  18 +-
>  .../soc/starfive/starfive,jh7110-syscon.yaml  |  93 ++++
>  MAINTAINERS                                   |  13 +
>  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  30 +-
>  drivers/clk/starfive/Kconfig                  |   9 +
>  drivers/clk/starfive/Makefile                 |   1 +
>  .../clk/starfive/clk-starfive-jh7110-pll.c    | 507 ++++++++++++++++++
>  .../clk/starfive/clk-starfive-jh7110-sys.c    |  45 +-
>  .../dt-bindings/clock/starfive,jh7110-crg.h   |   6 +
>  10 files changed, 746 insertions(+), 22 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-pll.yaml
>  create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>  create mode 100644 drivers/clk/starfive/clk-starfive-jh7110-pll.c
> 
> -- 
> 2.25.1
>

Krzysztof Kozlowski July 5, 2023, 6:27 a.m. UTC | #2

On 04/07/2023 08:46, Xingyu Wu wrote:
> [Resending because it has a error about examples in syscon bingdings
> and has to be fixed.]

Resending means you sent the same version. If you did not change
anything, then it will fail, right? If you changed something, it is new
version.

Best regards,
Krzysztof

Xingyu Wu July 7, 2023, 7:41 a.m. UTC | #3

On 2023/7/5 14:27, Krzysztof Kozlowski wrote:
> On 04/07/2023 08:46, Xingyu Wu wrote:
>> [Resending because it has a error about examples in syscon bingdings
>> and has to be fixed.]
> 
> Resending means you sent the same version. If you did not change
> anything, then it will fail, right? If you changed something, it is new
> version.
> 

Okay, I will fix it in new version of these patches. I sorry to make these noise.

Best regards,
Xingyu Wu

Conor Dooley July 12, 2023, 4:09 p.m. UTC | #4

Stephen,

On Tue, Jul 04, 2023 at 11:29:15PM +0100, Conor Dooley wrote:
> On Tue, Jul 04, 2023 at 02:46:03PM +0800, Xingyu Wu wrote:
> > [Resending because it has a error about examples in syscon bingdings
> > and has to be fixed.]
> > 
> > This patch serises are to add PLL clocks driver and providers by writing
> > and reading syscon registers for the StarFive JH7110 RISC-V SoC. And add 
> > documentation and nodes to describe StarFive System Controller(syscon)
> > Registers. This patch serises are based on Linux 6.4.
> 
> Could you take a look at this series when you get a chance, please?
> Would be good to finally get it merged since the syscon bits are a dep
> for a few other things :)

When Emil has had a chance to look at this, my plan was to send you a PR
for the bindings & clock bits, like I did for the last round of StarFive
changes. Would that be okay with you?

Thanks,
Conor.

> > William Qiu (2):
> >   dt-bindings: soc: starfive: Add StarFive syscon module
> >   riscv: dts: starfive: jh7110: Add syscon nodes
> > 
> > Xingyu Wu (5):
> >   dt-bindings: clock: Add StarFive JH7110 PLL clock generator
> >   dt-bindings: clock: jh7110-syscrg: Add PLL clock inputs
> >   clk: starfive: Add StarFive JH7110 PLL clock driver
> >   clk: starfive: jh7110-sys: Add PLL clocks source from DTS
> >   riscv: dts: starfive: jh7110: Add PLL clocks source in SYSCRG node
> > 
> >  .../bindings/clock/starfive,jh7110-pll.yaml   |  46 ++
> >  .../clock/starfive,jh7110-syscrg.yaml         |  18 +-
> >  .../soc/starfive/starfive,jh7110-syscon.yaml  |  93 ++++
> >  MAINTAINERS                                   |  13 +
> >  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  30 +-
> >  drivers/clk/starfive/Kconfig                  |   9 +
> >  drivers/clk/starfive/Makefile                 |   1 +
> >  .../clk/starfive/clk-starfive-jh7110-pll.c    | 507 ++++++++++++++++++
> >  .../clk/starfive/clk-starfive-jh7110-sys.c    |  45 +-
> >  .../dt-bindings/clock/starfive,jh7110-crg.h   |   6 +
> >  10 files changed, 746 insertions(+), 22 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-pll.yaml
> >  create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
> >  create mode 100644 drivers/clk/starfive/clk-starfive-jh7110-pll.c
> > 
> > -- 
> > 2.25.1
> >