mbox series

[v3,0/2] firmware: arm_scmi: clock: support parents commands

Message ID 20231001-scmi-clock-v2-v3-0-898bd92d8939@nxp.com (mailing list archive)
Headers show
Series firmware: arm_scmi: clock: support parents commands | expand

Message

Peng Fan (OSS) Oct. 1, 2023, 4:38 a.m. UTC 
V2:
 Add determine_rate hooks

SCMI v3.2 spec adds parents commands, this patchset is to support them:
CLOCK_POSSIBLE_PARENTS_GET
CLOCK_PARENT_SET
CLOCK_PARENT_GET

Besides firmware api clock driver update, the clk_scmi driver also
updated to support set_parent and get_parent ops.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Changes in v3:
 Address Cristian's comments:
  - Drop SCMI_MAX_NUM_PARENTS, alloc memory dynamically
  - Check clk_id, parent_id
  - Add comment for parent_get/set
- Link to v2: https://lore.kernel.org/r/20230925-scmi-clock-v2-v2-0-2d4d7127ebc1@nxp.com

---
Peng Fan (2):
      firmware: arm_scmi: clock: support clock parents
      clk: scmi: add set/get_parent support

 drivers/clk/clk-scmi.c            |  50 ++++++++++-
 drivers/firmware/arm_scmi/clock.c | 182 ++++++++++++++++++++++++++++++++++++--
 include/linux/scmi_protocol.h     |   6 ++
 3 files changed, 231 insertions(+), 7 deletions(-)
---
base-commit: 8fff9184d1b5810dca5dd1a02726d4f844af88fc
change-id: 20230925-scmi-clock-v2-042cf8e5cb77

Best regards,

Comments

Cristian Marussi Oct. 2, 2023, 5:11 p.m. UTC | #1 
On Sun, Oct 01, 2023 at 12:38:42PM +0800, Peng Fan (OSS) wrote:
> V2:
>  Add determine_rate hooks
> 
> SCMI v3.2 spec adds parents commands, this patchset is to support them:
> CLOCK_POSSIBLE_PARENTS_GET
> CLOCK_PARENT_SET
> CLOCK_PARENT_GET
> 

Hi Peng,

thanks for your update.

The SCMI part looks good to me but I'll made a few notes on clk-scmi
driver

Thanks,
Cristian