mbox series

[v9,00/13] clk: hisilicon: Migrate devm APIs

Message ID 20240412051041.90376-2-mmyangfl@gmail.com (mailing list archive)
Headers show
Series clk: hisilicon: Migrate devm APIs | expand

Message

David Yang April 12, 2024, 5:10 a.m. UTC
Migrate devm APIs for HiSilicon clock drivers and remove redundant codes.

This series is a partial improvement of [1]

v2: fix test robot error
v3:
  * size_t for all these num types
  * hisi_clk_unregister() change into separate patch
  * keep relevant header inclusions
  * split driver files changes into separate patches
  * explain hisi_clk_register_fn() checkpatch warnings
  * not fixed: MODULE_LICENSE("GPL v2"), as stated in SPDX-License-Identifier
  * not fixed: "hisilicon,hip04-clock" un-documented, as none of dts files in
    arch/ use it, better to ask hisi people why they pushed this driver
v4:
  * typo: hisi_clocks_get_nr() should check clks->nr first
  * unexport hisi_clk_unregister_fn() as no one use them outside
v5: catch up with remove_new refactoring
v6: fix compilation error and expand macros
v7: rebase and use mod_devicetable.h instead
v8: rebase again
v9: add linux/platform_device.h include in patch 09 according to reviews

Links:
[1]: https://lore.kernel.org/r/20230322164201.2454771-1-mmyangfl@gmail.com
v1: https://lore.kernel.org/r/20230326052757.297551-1-mmyangfl@gmail.com
v2: https://lore.kernel.org/r/20230329075104.165176-1-mmyangfl@gmail.com
v3: https://lore.kernel.org/r/20230410110733.192151-1-mmyangfl@gmail.com
v4: https://lore.kernel.org/r/20230411174329.424763-1-mmyangfl@gmail.com
v5: https://lore.kernel.org/r/20230723162245.35033-1-mmyangfl@gmail.com
v6: https://lore.kernel.org/r/20230731121821.22242-1-mmyangfl@gmail.com
v7: https://lore.kernel.org/r/20240225065234.413687-1-mmyangfl@gmail.com
v8: https://lore.kernel.org/r/20240411070503.38093-2-mmyangfl@gmail.com

David Yang (13):
  clk: hisilicon: Add helper functions for platform driver
  clk: hisilicon: hi3516cv300: Use helper functions
  clk: hisilicon: hi3798cv200: Use helper functions
  clk: hisilicon: Remove hisi_crg_funcs
  clk: hisilicon: hi3519: Use helper functions
  clk: hisilicon: hi3559a: Use helper functions
  clk: hisilicon: hi3660: Convert into module
  clk: hisilicon: hi3670: Convert into module
  clk: hisilicon: hi3620: Convert into platform driver module
  clk: hisilicon: hi6220: Convert into platform driver module
  clk: hisilicon: hip04: Convert into platform driver module
  clk: hisilicon: hix5hd2: Convert into platform driver module
  clk: hisilicon: Migrate devm APIs

 drivers/clk/hisilicon/clk-hi3519.c        | 127 +-----
 drivers/clk/hisilicon/clk-hi3559a.c       | 251 +++---------
 drivers/clk/hisilicon/clk-hi3620.c        | 215 +++++-----
 drivers/clk/hisilicon/clk-hi3660.c        | 194 +++------
 drivers/clk/hisilicon/clk-hi3670.c        | 250 ++++--------
 drivers/clk/hisilicon/clk-hi6220-stub.c   |   9 +-
 drivers/clk/hisilicon/clk-hi6220.c        | 228 ++++++-----
 drivers/clk/hisilicon/clk-hip04.c         |  38 +-
 drivers/clk/hisilicon/clk-hisi-phase.c    |  13 +-
 drivers/clk/hisilicon/clk-hix5hd2.c       |  98 +++--
 drivers/clk/hisilicon/clk.c               | 457 +++++++++++-----------
 drivers/clk/hisilicon/clk.h               | 141 ++++---
 drivers/clk/hisilicon/clkdivider-hi6220.c |  24 +-
 drivers/clk/hisilicon/clkgate-separated.c |  26 +-
 drivers/clk/hisilicon/crg-hi3516cv300.c   | 171 +-------
 drivers/clk/hisilicon/crg-hi3798cv200.c   | 200 ++--------
 drivers/clk/hisilicon/crg.h               |  11 +-
 drivers/clk/hisilicon/reset.c             |  42 ++
 18 files changed, 945 insertions(+), 1550 deletions(-)


base-commit: 586b5dfb51b962c1b6c06495715e4c4f76a7fc5a

Comments

Stephen Boyd April 12, 2024, 5:59 a.m. UTC | #1
Quoting David Yang (2024-04-11 22:10:29)
> Migrate devm APIs for HiSilicon clock drivers and remove redundant codes.
> 
> This series is a partial improvement of [1]
> 
> v2: fix test robot error
> v3:
>   * size_t for all these num types
>   * hisi_clk_unregister() change into separate patch
>   * keep relevant header inclusions
>   * split driver files changes into separate patches
>   * explain hisi_clk_register_fn() checkpatch warnings
>   * not fixed: MODULE_LICENSE("GPL v2"), as stated in SPDX-License-Identifier
>   * not fixed: "hisilicon,hip04-clock" un-documented, as none of dts files in
>     arch/ use it, better to ask hisi people why they pushed this driver
> v4:
>   * typo: hisi_clocks_get_nr() should check clks->nr first
>   * unexport hisi_clk_unregister_fn() as no one use them outside
> v5: catch up with remove_new refactoring
> v6: fix compilation error and expand macros
> v7: rebase and use mod_devicetable.h instead
> v8: rebase again
> v9: add linux/platform_device.h include in patch 09 according to reviews

Still doesn't work. Please compile every file before sending again.
Hint:

	make path/to/file.o