mbox series

[0/2] clk: qcom: Add support for GCC on QCS8300

Message ID 20240820-qcs8300-gcc-v1-0-d81720517a82@quicinc.com (mailing list archive)
Headers show
Series clk: qcom: Add support for GCC on QCS8300 | expand

Message

Imran Shaik Aug. 20, 2024, 9:36 a.m. UTC
This series adds the dt-bindings and driver support for GCC on QCS8300 platform.

Please note that this series is dependent on [1] which adds support
for QCS8275/QCS8300 SoC ID.

[1] https://lore.kernel.org/all/20240814072806.4107079-1-quic_jingyw@quicinc.com/

Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com>
---
Imran Shaik (2):
      dt-bindings: clock: qcom: Add GCC clocks for QCS8300
      clk: qcom: Add support for Global Clock Controller on QCS8300

 .../bindings/clock/qcom,qcs8300-gcc.yaml           |   66 +
 drivers/clk/qcom/Kconfig                           |   10 +
 drivers/clk/qcom/Makefile                          |    1 +
 drivers/clk/qcom/gcc-qcs8300.c                     | 3640 ++++++++++++++++++++
 include/dt-bindings/clock/qcom,qcs8300-gcc.h       |  234 ++
 5 files changed, 3951 insertions(+)
---
base-commit: bb1b0acdcd66e0d8eedee3570d249e076b89ab32
change-id: 20240820-qcs8300-gcc-433023269b36

Best regards,

Comments

Krzysztof Kozlowski Aug. 20, 2024, 9:57 a.m. UTC | #1
On 20/08/2024 11:36, Imran Shaik wrote:
> This series adds the dt-bindings and driver support for GCC on QCS8300 platform.
> 
> Please note that this series is dependent on [1] which adds support
> for QCS8275/QCS8300 SoC ID.
> 
> [1] https://lore.kernel.org/all/20240814072806.4107079-1-quic_jingyw@quicinc.com/

How do the depend? What is exactly the dependency?

If so this cannot be merged...

Best regards,
Krzysztof
Imran Shaik Aug. 20, 2024, 10:08 a.m. UTC | #2
On 8/20/2024 3:27 PM, Krzysztof Kozlowski wrote:
> On 20/08/2024 11:36, Imran Shaik wrote:
>> This series adds the dt-bindings and driver support for GCC on QCS8300 platform.
>>
>> Please note that this series is dependent on [1] which adds support
>> for QCS8275/QCS8300 SoC ID.
>>
>> [1] https://lore.kernel.org/all/20240814072806.4107079-1-quic_jingyw@quicinc.com/
> 
> How do the depend? What is exactly the dependency?
> 
> If so this cannot be merged...
> 

They are not functionally dependent, but we want to ensure the base 
QCS8300 changes to merge first and then our GCC changes. Hence added the 
dependency.

Thanks,
Imran

> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Aug. 20, 2024, 11:02 a.m. UTC | #3
On Tue, Aug 20, 2024 at 03:38:39PM +0530, Imran Shaik wrote:
> 
> 
> On 8/20/2024 3:27 PM, Krzysztof Kozlowski wrote:
> > On 20/08/2024 11:36, Imran Shaik wrote:
> > > This series adds the dt-bindings and driver support for GCC on QCS8300 platform.
> > > 
> > > Please note that this series is dependent on [1] which adds support
> > > for QCS8275/QCS8300 SoC ID.
> > > 
> > > [1] https://lore.kernel.org/all/20240814072806.4107079-1-quic_jingyw@quicinc.com/
> > 
> > How do the depend? What is exactly the dependency?
> > 
> > If so this cannot be merged...
> > 
> 
> They are not functionally dependent, but we want to ensure the base QCS8300
> changes to merge first and then our GCC changes. Hence added the dependency.

This does not work like that, these are different trees, even if they go
via Bjorn.

Why do you insist on some specific workflow, different than every
upstreaming process? What is so special here?

If you keep insisting, I will keep disagreeing, because it is not
justified and just complicates things unnecessarily.
Imran Shaik Aug. 21, 2024, 4:39 a.m. UTC | #4
On 8/20/2024 4:32 PM, Krzysztof Kozlowski wrote:
> On Tue, Aug 20, 2024 at 03:38:39PM +0530, Imran Shaik wrote:
>>
>>
>> On 8/20/2024 3:27 PM, Krzysztof Kozlowski wrote:
>>> On 20/08/2024 11:36, Imran Shaik wrote:
>>>> This series adds the dt-bindings and driver support for GCC on QCS8300 platform.
>>>>
>>>> Please note that this series is dependent on [1] which adds support
>>>> for QCS8275/QCS8300 SoC ID.
>>>>
>>>> [1] https://lore.kernel.org/all/20240814072806.4107079-1-quic_jingyw@quicinc.com/
>>>
>>> How do the depend? What is exactly the dependency?
>>>
>>> If so this cannot be merged...
>>>
>>
>> They are not functionally dependent, but we want to ensure the base QCS8300
>> changes to merge first and then our GCC changes. Hence added the dependency.
> 
> This does not work like that, these are different trees, even if they go
> via Bjorn.
> 
> Why do you insist on some specific workflow, different than every
> upstreaming process? What is so special here?
> 
> If you keep insisting, I will keep disagreeing, because it is not
> justified and just complicates things unnecessarily.

My bad, there is no dependency for clock tree actually, just wanted to 
provide the info that these GCC changes are for the newly defined SoC in 
the given series link. I will drop the dependency tag in the next series.

Thanks,
Imran