mbox series

[v7,0/2] Add notifier for PLL0 clock and set it 1.5GHz on the JH7110 SoC

Message ID 20240826080430.179788-1-xingyu.wu@starfivetech.com (mailing list archive)
Headers show
Series Add notifier for PLL0 clock and set it 1.5GHz on the JH7110 SoC | expand

Message

Xingyu Wu Aug. 26, 2024, 8:04 a.m. UTC 
This patch is to add the notifier for PLL0 clock and set the PLL0 rate
to 1.5GHz to fix the lower rate of CPUfreq on the JH7110 SoC.

The first patch is to add the notifier for PLL0 clock. Setting the PLL0
rate need the son clock (cpu_root) to switch its parent clock to OSC 
clock and switch it back after setting PLL0 rate. It need to use the 
cpu_root clock from SYSCRG and register the notifier in the SYSCRG
driver.

The second patch is to set cpu_core rate to 500MHz and PLL0 rate to
1.5GHz to fix the problem about the lower rate of CPUfreq on the 
visionfive board. The cpu_core clock rate is set to 500MHz first to
ensure that the cpu frequency will not suddenly become high and the cpu 
voltage is not enough to cause a crash when the PLL0 is set to 1.5GHz.
The cpu voltage and frequency are then adjusted together by CPUfreq.

According to some tests, U-Boot can also run 1.5G so that the DTS from
kernel can be used on the U-Boot and could not cause any problems. So
the way of patch v5 works.

Changes since v6:
- Used the patch 1 from v5 and added the reviewed tag.
- Modified the patch 2 from v5 to fit the new jh7110-common.dtsi.

v6: https://lore.kernel.org/all/20240603020607.25122-1-xingyu.wu@starfivetech.com/

Changes since v5:
- Set the rate to 1.5G in the driver instead of DTS.

v5: https://lore.kernel.org/all/20240507065319.274976-1-xingyu.wu@starfivetech.com/

Changes since v4: 
- Fixed the wrong words.
- Added the Fixes tag in first patch.

v4: https://lore.kernel.org/all/20240410033148.213991-1-xingyu.wu@starfivetech.com/

Changes since v3: 
- Added the notifier for PLL0 clock.
- Set cpu_core rate in DTS 

v3: https://lore.kernel.org/all/20240402090920.11627-1-xingyu.wu@starfivetech.com/

Changes since v2: 
- Made the steps into the process into the process of setting PLL0 rate

v2: https://lore.kernel.org/all/20230821152915.208366-1-xingyu.wu@starfivetech.com/

Changes since v1: 
- Added the fixes tag in the commit.

v1: https://lore.kernel.org/all/20230811033631.160912-1-xingyu.wu@starfivetech.com/

Xingyu Wu (2):
  clk: starfive: jh7110-sys: Add notifier for PLL0 clock
  riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by
    setting PLL0 rate to 1.5GHz

 .../boot/dts/starfive/jh7110-common.dtsi      |  6 ++++
 .../clk/starfive/clk-starfive-jh7110-sys.c    | 31 ++++++++++++++++++-
 drivers/clk/starfive/clk-starfive-jh71x0.h    |  2 ++
 3 files changed, 38 insertions(+), 1 deletion(-)

Comments

Conor Dooley Sept. 9, 2024, 2:28 p.m. UTC | #1 
From: Conor Dooley <conor.dooley@microchip.com>

On Mon, 26 Aug 2024 16:04:28 +0800, Xingyu Wu wrote:
> This patch is to add the notifier for PLL0 clock and set the PLL0 rate
> to 1.5GHz to fix the lower rate of CPUfreq on the JH7110 SoC.
> 
> The first patch is to add the notifier for PLL0 clock. Setting the PLL0
> rate need the son clock (cpu_root) to switch its parent clock to OSC
> clock and switch it back after setting PLL0 rate. It need to use the
> cpu_root clock from SYSCRG and register the notifier in the SYSCRG
> driver.
> 
> [...]

Applied to riscv-soc-fixes, thanks!


[2/2] riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz
      https://git.kernel.org/conor/c/61f2e8a3a941

I applied this last night but forgot to send the ty email.