mbox series

[v2,0/3] add clocks support for exynosauto v920 SoC

Message ID 20241007071829.3042094-1-sunyeal.hong@samsung.com (mailing list archive)
Headers show
Series add clocks support for exynosauto v920 SoC | expand

Message

Sunyeal Hong Oct. 7, 2024, 7:18 a.m. UTC
This patchset adds the CMU block below to support exynosauto v920 SoC.
- CMU_PERIC1
- CMU_MISC
- CMU_HSI0/1

Changes in v2:
 - Rebase the patch to reflect the latest fixes

Sunyeal Hong (3):
  dt-bindings: clock: exynosautov920: add peric1, misc and hsi0/1 clock
    definitions
  clk: samsung: exynosautov920: add peric1, misc and hsi0/1 clock
    support
  arm64: dts: exynosautov920: add peric1, misc and hsi0/1 clock DT nodes

 .../arm64/boot/dts/exynos/exynosautov920.dtsi |  50 +++
 drivers/clk/samsung/clk-exynosautov920.c      | 290 ++++++++++++++++++
 .../clock/samsung,exynosautov920.h            |  47 +++
 3 files changed, 387 insertions(+)

Comments

Krzysztof Kozlowski Oct. 7, 2024, 7:20 a.m. UTC | #1
On 07/10/2024 09:18, Sunyeal Hong wrote:
> This patchset adds the CMU block below to support exynosauto v920 SoC.
> - CMU_PERIC1
> - CMU_MISC
> - CMU_HSI0/1
> 
> Changes in v2:
>  - Rebase the patch to reflect the latest fixes

Not much improved. Still blind rebase without addressing the issue I
pointed out.

Allow people to actually review your patches, instead of sending
multiple versions within 5 minutes.

One patchset per 24h.

Best regards,
Krzysztof
Sunyeal Hong Oct. 7, 2024, 7:30 a.m. UTC | #2
Hello Krzyszto,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, October 7, 2024 4:20 PM
> To: Sunyeal Hong <sunyeal.hong@samsung.com>; Sylwester Nawrocki
> <s.nawrocki@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>; Alim
> Akhtar <alim.akhtar@samsung.com>; Michael Turquette
> <mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; Rob Herring
> <robh@kernel.org>; Conor Dooley <conor+dt@kernel.org>
> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/3] add clocks support for exynosauto v920 SoC
> 
> On 07/10/2024 09:18, Sunyeal Hong wrote:
> > This patchset adds the CMU block below to support exynosauto v920 SoC.
> > - CMU_PERIC1
> > - CMU_MISC
> > - CMU_HSI0/1
> >
> > Changes in v2:
> >  - Rebase the patch to reflect the latest fixes
> 
> Not much improved. Still blind rebase without addressing the issue I
> pointed out.
> 
> Allow people to actually review your patches, instead of sending multiple
> versions within 5 minutes.
> 
> One patchset per 24h.
> 
I apologize for sending you the patch version incorrectly multiple times.
Could you elaborate a bit more on the "unrelated change" part you mentioned in the comment?
I don't think I understand your exact intention.

Best Regards,
sunyeal

> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Oct. 7, 2024, 7:48 a.m. UTC | #3
On 07/10/2024 09:30, sunyeal.hong wrote:
> Hello Krzyszto,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Monday, October 7, 2024 4:20 PM
>> To: Sunyeal Hong <sunyeal.hong@samsung.com>; Sylwester Nawrocki
>> <s.nawrocki@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>; Alim
>> Akhtar <alim.akhtar@samsung.com>; Michael Turquette
>> <mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; Rob Herring
>> <robh@kernel.org>; Conor Dooley <conor+dt@kernel.org>
>> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [PATCH v2 0/3] add clocks support for exynosauto v920 SoC
>>
>> On 07/10/2024 09:18, Sunyeal Hong wrote:
>>> This patchset adds the CMU block below to support exynosauto v920 SoC.
>>> - CMU_PERIC1
>>> - CMU_MISC
>>> - CMU_HSI0/1
>>>
>>> Changes in v2:
>>>  - Rebase the patch to reflect the latest fixes
>>
>> Not much improved. Still blind rebase without addressing the issue I
>> pointed out.
>>
>> Allow people to actually review your patches, instead of sending multiple
>> versions within 5 minutes.
>>
>> One patchset per 24h.
>>
> I apologize for sending you the patch version incorrectly multiple times.
> Could you elaborate a bit more on the "unrelated change" part you mentioned in the comment?
> I don't think I understand your exact intention.

I do not see above "unrelated change" quote. Please respond inline.

Best regards,
Krzysztof