| Message ID | 20241108-qcs615-mm-clockcontroller-v3-0-7d3b2d235fdf@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform | expand |
On Fri, Nov 08, 2024 at 09:39:17AM +0530, Taniya Das wrote: > Add support for multimedia clock controllers on Qualcomm QCS615 platform. > Update the defconfig to enable these clock controllers. > > Global clock controller support > https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@quicinc.com/ > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> Dropping this series from my queue, due to lack of response from author. Taniya, please answer questions/feedback from Dmitry, Vladimir and Bryan, and repose as necessary. Thanks, Bjorn > --- > Changes in v3: > - update PLL configs to use BIT and GENMASK for vco_val and vco_mask for all CCs [Bryan O'Donoghue] > - Link to v2: https://lore.kernel.org/r/20241101-qcs615-mm-clockcontroller-v2-0-d1a4870a4aed@quicinc.com > > Changes in v2: > - cleanups in clk_alpha_pll_slew_update and clk_alpha_pll_slew_enable functions [Christophe] > - update PLL configs for "vco_val = 0x0" shift(20) [Bryan O'Donoghue] > - update PLL configs to use lower case for L value [Dmitry] > - Link parents for IFE/IPE/BPS GDSCs as Titan Top GDSC [Bryan O'Donoghue, Dmitry] > - Remove DT_BI_TCXO_AO from camcc-qcs615 [Dmitry] > - Remove HW_CTRL_TRIGGER from camcc-qcs615 [Bryan O'Donoghue] > - Update platform name for default configuration [Dmitry] > - Link to v1: https://lore.kernel.org/r/20241019-qcs615-mm-clockcontroller-v1-0-4cfb96d779ae@quicinc.com > > --- > Taniya Das (11): > clk: qcom: Update the support for alpha mode configuration > clk: qcom: clk-alpha-pll: Add support for dynamic update for slewing PLLs > dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller > clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver > dt-bindings: clock: Add Qualcomm QCS615 Display clock controller > clk: qcom: dispcc-qcs615: Add QCS615 display clock controller driver > dt-bindings: clock: Add Qualcomm QCS615 Graphics clock controller > clk: qcom: gpucc-qcs615: Add QCS615 graphics clock controller driver > dt-bindings: clock: Add Qualcomm QCS615 Video clock controller > clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver > arm64: defconfig: Enable QCS615 clock controllers > > .../bindings/clock/qcom,qcs615-camcc.yaml | 60 + > .../bindings/clock/qcom,qcs615-dispcc.yaml | 73 + > .../bindings/clock/qcom,qcs615-gpucc.yaml | 66 + > .../bindings/clock/qcom,qcs615-videocc.yaml | 64 + > arch/arm64/configs/defconfig | 4 + > drivers/clk/qcom/Kconfig | 35 + > drivers/clk/qcom/Makefile | 4 + > drivers/clk/qcom/camcc-qcs615.c | 1591 ++++++++++++++++++++ > drivers/clk/qcom/clk-alpha-pll.c | 172 +++ > drivers/clk/qcom/clk-alpha-pll.h | 1 + > drivers/clk/qcom/dispcc-qcs615.c | 786 ++++++++++ > drivers/clk/qcom/gpucc-qcs615.c | 525 +++++++ > drivers/clk/qcom/videocc-qcs615.c | 332 ++++ > include/dt-bindings/clock/qcom,qcs615-camcc.h | 110 ++ > include/dt-bindings/clock/qcom,qcs615-dispcc.h | 52 + > include/dt-bindings/clock/qcom,qcs615-gpucc.h | 39 + > include/dt-bindings/clock/qcom,qcs615-videocc.h | 30 + > 17 files changed, 3944 insertions(+) > --- > base-commit: 15e7d45e786a62a211dd0098fee7c57f84f8c681 > change-id: 20241016-qcs615-mm-clockcontroller-cff9aea7a006 > > Best regards, > -- > Taniya Das <quic_tdas@quicinc.com> >
On 12/2/2024 9:55 AM, Bjorn Andersson wrote: > On Fri, Nov 08, 2024 at 09:39:17AM +0530, Taniya Das wrote: >> Add support for multimedia clock controllers on Qualcomm QCS615 platform. >> Update the defconfig to enable these clock controllers. >> >> Global clock controller support >> https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@quicinc.com/ >> >> Signed-off-by: Taniya Das<quic_tdas@quicinc.com> > Dropping this series from my queue, due to lack of response from author. > > Taniya, please answer questions/feedback from Dmitry, Vladimir and > Bryan, and repose as necessary. Sure, Bjorn, I had a dependency on the GCC patch. https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@quicinc.com/ I will fix the comments once the Global clock controller patch is picked.
On Mon, Dec 02, 2024 at 01:09:12PM +0530, Taniya Das wrote: > > > On 12/2/2024 9:55 AM, Bjorn Andersson wrote: > > On Fri, Nov 08, 2024 at 09:39:17AM +0530, Taniya Das wrote: > > > Add support for multimedia clock controllers on Qualcomm QCS615 platform. > > > Update the defconfig to enable these clock controllers. > > > > > > Global clock controller support > > > https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@quicinc.com/ > > > > > > Signed-off-by: Taniya Das<quic_tdas@quicinc.com> > > Dropping this series from my queue, due to lack of response from author. > > > > Taniya, please answer questions/feedback from Dmitry, Vladimir and > > Bryan, and repose as necessary. > > Sure, Bjorn, I had a dependency on the GCC patch. > > https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@quicinc.com/ > > I will fix the comments once the Global clock controller patch is picked. I think this makes a good generic feedback (I observe the antipattern in other engineer's behaviour too): please try responding to the comment after receiving it, not just before getting back to the series. For this particular case: there is no need to wait on GCC. Please stop using the external dt-bindings header and use <&gcc_foo_clock> instead. This is just an example, not a c&p from the platform's DT.
Add support for multimedia clock controllers on Qualcomm QCS615 platform. Update the defconfig to enable these clock controllers. Global clock controller support https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@quicinc.com/ Signed-off-by: Taniya Das <quic_tdas@quicinc.com> --- Changes in v3: - update PLL configs to use BIT and GENMASK for vco_val and vco_mask for all CCs [Bryan O'Donoghue] - Link to v2: https://lore.kernel.org/r/20241101-qcs615-mm-clockcontroller-v2-0-d1a4870a4aed@quicinc.com Changes in v2: - cleanups in clk_alpha_pll_slew_update and clk_alpha_pll_slew_enable functions [Christophe] - update PLL configs for "vco_val = 0x0" shift(20) [Bryan O'Donoghue] - update PLL configs to use lower case for L value [Dmitry] - Link parents for IFE/IPE/BPS GDSCs as Titan Top GDSC [Bryan O'Donoghue, Dmitry] - Remove DT_BI_TCXO_AO from camcc-qcs615 [Dmitry] - Remove HW_CTRL_TRIGGER from camcc-qcs615 [Bryan O'Donoghue] - Update platform name for default configuration [Dmitry] - Link to v1: https://lore.kernel.org/r/20241019-qcs615-mm-clockcontroller-v1-0-4cfb96d779ae@quicinc.com --- Taniya Das (11): clk: qcom: Update the support for alpha mode configuration clk: qcom: clk-alpha-pll: Add support for dynamic update for slewing PLLs dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver dt-bindings: clock: Add Qualcomm QCS615 Display clock controller clk: qcom: dispcc-qcs615: Add QCS615 display clock controller driver dt-bindings: clock: Add Qualcomm QCS615 Graphics clock controller clk: qcom: gpucc-qcs615: Add QCS615 graphics clock controller driver dt-bindings: clock: Add Qualcomm QCS615 Video clock controller clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver arm64: defconfig: Enable QCS615 clock controllers .../bindings/clock/qcom,qcs615-camcc.yaml | 60 + .../bindings/clock/qcom,qcs615-dispcc.yaml | 73 + .../bindings/clock/qcom,qcs615-gpucc.yaml | 66 + .../bindings/clock/qcom,qcs615-videocc.yaml | 64 + arch/arm64/configs/defconfig | 4 + drivers/clk/qcom/Kconfig | 35 + drivers/clk/qcom/Makefile | 4 + drivers/clk/qcom/camcc-qcs615.c | 1591 ++++++++++++++++++++ drivers/clk/qcom/clk-alpha-pll.c | 172 +++ drivers/clk/qcom/clk-alpha-pll.h | 1 + drivers/clk/qcom/dispcc-qcs615.c | 786 ++++++++++ drivers/clk/qcom/gpucc-qcs615.c | 525 +++++++ drivers/clk/qcom/videocc-qcs615.c | 332 ++++ include/dt-bindings/clock/qcom,qcs615-camcc.h | 110 ++ include/dt-bindings/clock/qcom,qcs615-dispcc.h | 52 + include/dt-bindings/clock/qcom,qcs615-gpucc.h | 39 + include/dt-bindings/clock/qcom,qcs615-videocc.h | 30 + 17 files changed, 3944 insertions(+) --- base-commit: 15e7d45e786a62a211dd0098fee7c57f84f8c681 change-id: 20241016-qcs615-mm-clockcontroller-cff9aea7a006 Best regards,