From patchwork Sun Dec 29 14:49:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 13922771 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F265C17B50A for ; Sun, 29 Dec 2024 14:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483834; cv=none; b=l5iNcKcKeV4uC5d/U8zfsAKXhsCvV9k2A6UBMAyD2eM8R88RYdE+N+jg+BFrJK3dSoIJXaVvjF4+ja+axh6cKXHDnTxTrpnvecYE60WQCp9ZY9FWTCkIYJwhl/JpDM7Q3EuImdssxVSHIRfMSr9e9fDPZZwII2YLuhlwrd/GwKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483834; c=relaxed/simple; bh=18hYRPMSK70eF4pL6rczXgkVi9mkxd0dsTX68W3EHSY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qwQAiOvCiHE+fwzIIL3kAf2K/+jyEQ0qmzlHpJtWxjueuzBQd6vVrzNgKGEfAAgvXbc/uCDlMr0/W0CQr5JTzKH2UoQpR4RYpH/EthsFR9WqjEbSg27k+HYrkVxrVLNkkxzGFOcsY4XGuDUho/Op8KPBpGrRgDm+OgVhF8GGosY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=hz1sl4qS; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="hz1sl4qS" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-aa689a37dd4so1278881566b.3 for ; Sun, 29 Dec 2024 06:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1735483831; x=1736088631; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=F6+f7jMoIATRyOE70ikq3cyEvYNf4urCVh8EzVTjWJY=; b=hz1sl4qSMf2eB4aGSe+ScIgWWeDOO9a9sGlScJnzlAwcTuvSWvW+Bohcv3frAob2PY 7LQNwkYXnhFP4MqLxBwT1QAsjun30XWN53PugjpqO9xwRu1mYvbwLZrscTuxpG0Xj+t3 QsZQz1kubHjvnwhTQow974aGiH6x/G3MGgx1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735483831; x=1736088631; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F6+f7jMoIATRyOE70ikq3cyEvYNf4urCVh8EzVTjWJY=; b=nYf4eqswxcVryqj1BGK25Z3kwXp7OR6L7TcOd/Q58Hr1pW6/lnv8gyezszAe8T/oIu ZFXBEW0svvCEkIEK9nRDgFLPmEilJIAT9+aweTzJesejtGOHXW1DQcj4hmENJX+fZpJM dXLYKt3ke3OHVqdLAeXBsAv0jRgRqO7BXpJm8Gy2B8cF01dO44hgL5cwK5mj+ulxjDIl 4Ii8o+f29i5Xhq8vnnnELolJI/8xyubOY/+CIFsMX4M+lNTjM70PFD+oKVjIThX3rxqT 8PgTJlXtnhBhtg2kzX+xeBIiMwFwdmUHP9vU6EeVVY6JfX7vHneXFtOEeKeONLBqkSxI 386w== X-Forwarded-Encrypted: i=1; AJvYcCXBpNTkxtYVU7u7d29rA0q3LSWbp7hxXtH89VU3EGob1iUVRD2IW2F3K5gpcjAfmrYJywieLA3B83k=@vger.kernel.org X-Gm-Message-State: AOJu0YwVBOPlzE2fcF3KnRffwvRkE4VKGhurRoIFtK5FB1Ni4pSEAoTn 0/ScW7c95PFDd41YYkPwxtPQ/bHXaWsWliPmc4bgqFLKXrROjoqIMJM7ZTYjYgw= X-Gm-Gg: ASbGncuxW9hvfXmaJzFk1ViyqxvOo7gtrveBqd1YuxcvKxCP93qyLxwMwOuCjkaEmdh ICoviwF/m8UaJ1L8OH/q8SUAnhA/dnpvWPzq6FX97PlJMcXHKkjGaNiqGqsmFU9hA3I1pTYrL// tjvliwq/4iKtGSTnp1xtzCt2F7OgnmqUMGQfDLsPPe5UOOVqkuwasajYrZ6nilJeLs7Ca5IFNo+ FrTm7daz1UkQGB3piRsCUvbRjbCCr5vCWrP5DvvyK7wwSDWJTzrJLq1cXNr6MFtEl/twmZ9QlNk UFrQFC/hvNVoVR6VDNqopQ== X-Google-Smtp-Source: AGHT+IGIDvR00Hc3XgVkeolGibSGC8tUB/z1f3sR2v4jZbZHlTnHgn1RaBqUHQyGAHVMOy56/9+qCw== X-Received: by 2002:a17:907:1c14:b0:aa6:a228:afaf with SMTP id a640c23a62f3a-aac3378d0b4mr2559257666b.52.1735483831243; Sun, 29 Dec 2024 06:50:31 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.43.175]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e895080sm1362084466b.47.2024.12.29.06.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Dec 2024 06:50:30 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Abel Vesa , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Michael Turquette , Peng Fan , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: [PATCH v8 00/18] Support spread spectrum clocking for i.MX8N PLLs Date: Sun, 29 Dec 2024 15:49:24 +0100 Message-ID: <20241229145027.3984542-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The series adds support for spread spectrum clocking for i.MX8MN PLLs (audio, video and DRAM). It has been tested for the video PLL on a board using i.MX8MN. The patches added in version 4, such as the dt-bindings and the driver for anatop, were inspired by the extensive email exchange from version 3: https://lore.kernel.org/imx/20241106090549.3684963-1-dario.binacchi@amarulasolutions.com/ The series added spectrum spread support for the imx8mn platform only, but in case it was merged, confirming that the directives and suggestions made by the maintainers were correctly understood and implemented, I will extend this support to the imx8mm and imx8mp platforms as well. Changes in v8: - Drop the patches added in version 7: - 10/23 dt-bindings: clock: imx8m-clock: add phandle to the anatop - 11/23 arm64: dts: imx8mm: add phandle to anatop within CCM - 12/23 arm64: dts: imx8mn: add phandle to anatop within CCM - 13/23 arm64: dts: imx8mp: add phandle to anatop within CCM - 14/23 arm64: dts: imx8mq: add phandle to anatop within CCM Changes in v7: - Add and manage fsl,anatop property as phandle to the anatop node with the new patches: - 10/23 dt-bindings: clock: imx8m-clock: add phandle to the anatop - 11/23 arm64: dts: imx8mm: add phandle to anatop within CCM - 12/23 arm64: dts: imx8mn: add phandle to anatop within CCM - 13/23 arm64: dts: imx8mp: add phandle to anatop within CCM - 14/23 arm64: dts: imx8mq: add phandle to anatop within CCM Changes in v6: - Merge patches: 10/20 dt-bindings: clock: imx8mm: add binding definitions for anatop 11/20 dt-bindings: clock: imx8mn: add binding definitions for anatop 12/20 dt-bindings: clock: imx8mp: add binding definitions for anatop to 05/20 dt-bindings: clock: imx8m-anatop: define clocks/clock-names now renamed 05/18 dt-bindings: clock: imx8m-anatop: add oscillators and PLLs - Split the patch 15/20 dt-bindings-clock-imx8m-clock-support-spread-spectru.patch into 12/18 dt-bindings: clock: imx8m-clock: add PLLs 16/18 dt-bindings: clock: imx8m-clock: support spread spectrum clocking Changes in v5: - Fix compilation errors. - Separate driver code from dt-bindings Changes in v4: - Add dt-bindings for anatop - Add anatop driver - Drop fsl,ssc-clocks from spread spectrum dt-bindings Changes in v3: - Patches 1/8 has been added in version 3. The dt-bindings have been moved from fsl,imx8m-anatop.yaml to imx8m-clock.yaml. The anatop device (fsl,imx8m-anatop.yaml) is indeed more or less a syscon, so it represents a memory area accessible by ccm (imx8m-clock.yaml) to setup the PLLs. - Patches {3,5}/8 have been added in version 3. - Patches {4,6,8}/8 use ccm device node instead of the anatop one. Changes in v2: - Add "allOf:" and place it after "required:" block, like in the example schema. - Move the properties definition to the top-level. - Drop unit types as requested by the "make dt_binding_check" command. Dario Binacchi (18): dt-bindings: clock: imx8mm: add VIDEO_PLL clocks clk: imx8mm: rename video_pll1 to video_pll dt-bindings: clock: imx8mp: add VIDEO_PLL clocks clk: imx8mp: rename video_pll1 to video_pll dt-bindings: clock: imx8m-anatop: add oscillators and PLLs arm64: dts: imx8mm: add anatop clocks arm64: dts: imx8mn: add anatop clocks arm64: dts: imx8mp: add anatop clocks arm64: dts: imx8mq: add anatop clocks clk: imx: add hw API imx_anatop_get_clk_hw clk: imx: add support for i.MX8MN anatop clock driver dt-bindings: clock: imx8m-clock: add PLLs arm64: dts: imx8mm: add PLLs to clock controller module (CCM) arm64: dts: imx8mn: add PLLs to clock controller module (CCM) arm64: dts: imx8mp: add PLLs to clock controller module (CCM) dt-bindings: clock: imx8m-clock: support spread spectrum clocking clk: imx: pll14xx: support spread spectrum clock generation clk: imx8mn: support spread spectrum clock generation .../bindings/clock/fsl,imx8m-anatop.yaml | 53 +++- .../bindings/clock/imx8m-clock.yaml | 74 ++++- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 11 +- arch/arm64/boot/dts/freescale/imx8mn.dtsi | 11 +- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 11 +- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 + drivers/clk/imx/Makefile | 2 +- drivers/clk/imx/clk-imx8mm.c | 102 +++---- drivers/clk/imx/clk-imx8mn-anatop.c | 283 ++++++++++++++++++ drivers/clk/imx/clk-imx8mn.c | 196 ++++++------ drivers/clk/imx/clk-imx8mp.c | 118 ++++---- drivers/clk/imx/clk-pll14xx.c | 134 +++++++++ drivers/clk/imx/clk.c | 15 + drivers/clk/imx/clk.h | 18 ++ include/dt-bindings/clock/imx8mm-clock.h | 76 ++++- include/dt-bindings/clock/imx8mn-clock.h | 64 ++++ include/dt-bindings/clock/imx8mp-clock.h | 80 ++++- 17 files changed, 1015 insertions(+), 235 deletions(-) create mode 100644 drivers/clk/imx/clk-imx8mn-anatop.c