From patchwork Fri Nov 22 21:44:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 11258475 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DD9B46C1 for ; Fri, 22 Nov 2019 21:45:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCAE12071B for ; Fri, 22 Nov 2019 21:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbfKVVp1 (ORCPT ); Fri, 22 Nov 2019 16:45:27 -0500 Received: from inva021.nxp.com ([92.121.34.21]:37590 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbfKVVp1 (ORCPT ); Fri, 22 Nov 2019 16:45:27 -0500 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 0B8322002C9; Fri, 22 Nov 2019 22:45:24 +0100 (CET) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id E8A89200277; Fri, 22 Nov 2019 22:45:23 +0100 (CET) Received: from fsr-ub1864-112.ea.freescale.net (fsr-ub1864-112.ea.freescale.net [10.171.82.98]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id D03E420465; Fri, 22 Nov 2019 22:45:22 +0100 (CET) From: Leonard Crestez To: Stephen Boyd , Chanwoo Choi , Rob Herring Cc: MyungJoo Ham , Kyungmin Park , "Rafael J. Wysocki" , Shawn Guo , Mark Rutland , Michael Turquette , =?utf-8?b?QXJ0dXIgxZp3aWdvxYQ=?= , Saravana Kannan , Angus Ainslie , Martin Kepplinger , Matthias Kaehlcke , Krzysztof Kozlowski , Alexandre Bailon , Georgi Djakov , Dong Aisheng , Abel Vesa , Jacky Bai , Anson Huang , Fabio Estevam , Viresh Kumar , Silvano di Ninno , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Date: Fri, 22 Nov 2019 23:44:59 +0200 Message-Id: X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree. DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration. This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will call clk_set_parent to ensure the parents in clock framework are up-to-date. This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip. Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately. This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A. Changes since v6: * Replace ARCH_MXC || COMPILE_TEST with ARCH_MXC && HAVE_ARM_SMCCC * Collect reviews Link to v6: https://patchwork.kernel.org/cover/11244283/ I'd rather not fix COMPILE_TEST with ifdefs for this driver, if anything that should be fixed in smccc header. ARCH_MXC doesn't imply SMCCC, it also covers some very old chips which don't have it. Resending full series because that's the standard method. Changes since v5: * Fix a dram_apb/dram_alt mixup in imx8m_ddrc_set_freq * Make clk_get_parent_by_index static (kbuild robot) * Adjust messages in imx8m_ddrc_set_freq * Use a for loop inside imx8m_ddrc_check_opps instead of while * More elaborate description in dt-bindings file. Link to v5: https://patchwork.kernel.org/cover/11240289/ Changes since v4: * Restore empty _get_dev_status: testing shows this is *NOT* optional. If absent then switching to simple_ondemand governor will trigger an Oops. * Keep clk registration on single-line in clk-imx8m* for consistency with rest of the file. * Drop explicit "select PM_OPP" * Check for NULL new_dram_core_parent * Rename "out_dis_" labels to out_disable_* * Use dev_warn on imx8m_ddrc_set_freq error paths after SMC call (where operation is not abandoned). * More elaborate error messages in imx8m_ddrc_target * More elaborate checks when fetching clks in imx8m_ddrc_set_freq * Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names Recommendation" * Defer perf support, it requires perf changes to fetch PMU by DT Link to v4: https://patchwork.kernel.org/cover/11235685/ Changes since v3: * Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm but soc integration is different. * Move dt bindings to /memory-controllers/fsl/ * Fix dt validation issues * Fix imx8mm.dtsi ddrc referencing ddrc_opp_table which is only defined in evk * Move opps to child of ddrc device node * Only add imx_ddrc_get_dev_status in perf patch. * Adjust print messages Link to v3: https://patchwork.kernel.org/cover/11221935/ Changes since v2: * Add support for entire imx8m family including imx8mq B0. * Also mark dram PLLs as CLK_GET_RATE_NO_CACHE (required for imx8mq b0 low OPP) * Explicitly update dram pll rate at the end of imx_ddrc_set_freq. * Use do_div in imx-ddrc (kbuild robot) * Improve explanations around adding CLK_GET_RATE_NO_CACHE to dram clks. (Stephen Boyd) * Handle ddrc devfreq-events earlier for fewer probe defers. * Validate DDRC opp tables versus firmware: supported OPPs depend on board and SOC revision. * Move DDRC opp tables to board dts because they can vary based on ram type on board. * Verify DDRC rate is changed in clk tree and otherwise report an error. * Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ in imx_ddrc_find_freq instead. * Split away from NOC scaling and interconnect support. Link to v2: https://patchwork.kernel.org/cover/11104113/ Changes since v1: * bindings: Stop using "contains" for "compatible" * bindings: Set "additionalProperties: false" and document missing stuff. * Remove (c) from NXP copyright notice * Fix various checkpatch issues * Remove unused dram_alt_root clk from imx-ddrc Link to v1: https://patchwork.kernel.org/cover/11090649/ Leonard Crestez (5): clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller arm64: dts: imx8m: Add ddr controller nodes .../memory-controllers/fsl/imx8m-ddrc.yaml | 72 +++ arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 + .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 + arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 + arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 + drivers/clk/imx/clk-imx8mm.c | 11 +- drivers/clk/imx/clk-imx8mn.c | 12 +- drivers/clk/imx/clk-imx8mq.c | 12 +- drivers/clk/imx/clk-pll14xx.c | 7 + drivers/clk/imx/clk.h | 1 + drivers/devfreq/Kconfig | 9 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml create mode 100644 drivers/devfreq/imx8m-ddrc.c