| Message ID | 1461851433-19365-1-git-send-email-vaishali.thakkar@oracle.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
On 04/28, Vaishali Thakkar wrote: > When sizeof is applied to a pointer typed expression, it gives > the size of the pointer. So, here do not use sizeof on pointer > type. Also, silent checkpatch.pl by using kmalloc_array over > kmalloc. > > Note that this has no effect on runtime because 'parent_names' > is a pointer to a pointer. > > Problem found using Coccinelle. > > Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> > --- Applied to clk-next
diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c index deaa7f9..526b0b0 100644 --- a/drivers/clk/bcm/clk-kona-setup.c +++ b/drivers/clk/bcm/clk-kona-setup.c @@ -577,7 +577,8 @@ static u32 *parent_process(const char *clocks[], * selector is not required, but we allocate space for the * array anyway to keep things simple. */ - parent_names = kmalloc(parent_count * sizeof(parent_names), GFP_KERNEL); + parent_names = kmalloc_array(parent_count, sizeof(*parent_names), + GFP_KERNEL); if (!parent_names) { pr_err("%s: error allocating %u parent names\n", __func__, parent_count);
When sizeof is applied to a pointer typed expression, it gives the size of the pointer. So, here do not use sizeof on pointer type. Also, silent checkpatch.pl by using kmalloc_array over kmalloc. Note that this has no effect on runtime because 'parent_names' is a pointer to a pointer. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> --- drivers/clk/bcm/clk-kona-setup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)