From patchwork Thu Jun 30 09:31:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 9207125 X-Patchwork-Delegate: sboyd@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0D5886075A for ; Thu, 30 Jun 2016 09:40:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F189F2845E for ; Thu, 30 Jun 2016 09:40:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E64FA2865A; Thu, 30 Jun 2016 09:40:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BCE2E2845E for ; Thu, 30 Jun 2016 09:40:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932067AbcF3Jid (ORCPT ); Thu, 30 Jun 2016 05:38:33 -0400 Received: from mail-bl2on0065.outbound.protection.outlook.com ([65.55.169.65]:55163 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752219AbcF3Ji3 (ORCPT ); Thu, 30 Jun 2016 05:38:29 -0400 Received: from BN3PR0301CA0040.namprd03.prod.outlook.com (10.160.180.178) by BY2PR03MB1927.namprd03.prod.outlook.com (10.164.114.31) with Microsoft SMTP Server (TLS) id 15.1.447.15; Thu, 30 Jun 2016 09:38:26 +0000 Received: from BN1BFFO11FD009.protection.gbl (2a01:111:f400:7c10::1:134) by BN3PR0301CA0040.outlook.office365.com (2a01:111:e400:4000::50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.528.16 via Frontend Transport; Thu, 30 Jun 2016 09:38:26 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD009.mail.protection.outlook.com (10.58.144.72) with Microsoft SMTP Server (TLS) id 15.1.523.9 via Frontend Transport; Thu, 30 Jun 2016 09:38:25 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5U9cDxH010090; Thu, 30 Jun 2016 02:38:22 -0700 From: Dong Aisheng To: CC: , , , , , , Subject: [PATCH V3 3/8] clk: core: support clocks which requires parents enable (part 1) Date: Thu, 30 Jun 2016 17:31:13 +0800 Message-ID: <1467279078-2330-4-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1467279078-2330-1-git-send-email-aisheng.dong@nxp.com> References: <1467279078-2330-1-git-send-email-aisheng.dong@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131117531056577845; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(76176999)(87936001)(50986999)(19580395003)(69596002)(2950100001)(8666005)(2351001)(105606002)(5003940100001)(48376002)(106466001)(97736004)(8936002)(110136002)(104016004)(50466002)(8676002)(47776003)(575784001)(81166006)(4326007)(81156014)(2906002)(19580405001)(50226002)(229853001)(86362001)(189998001)(11100500001)(6806005)(36756003)(33646002)(85426001)(7846002)(305945005)(68736007)(92566002)(77096005)(356003)(586003)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR03MB1927; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD009; 1:BOzNq3NyRpVzrY6Heffu/s2OUBS5WkJhxX0kKb7DkmWI8wldO/QjxmK+6aVP5ZtsdGhiUCWsgRg6eMAg0MBRFJWMlKrt81uJhxqyhAPStYQMaL9zNi62o0FUZ0Ryo3ZWYA8MMi0dI0mWFXPuqfZgj81ZxVN/tFZHmwpQbb7/VcJmI8CuSMsbekcl4Spj545Q4zMaH+4+uKbZBY9f/UgSHmDotzoKHDcwWoxP1Afk0r0DoXvT+tfoq8DJRaP4gkGXHL2FY2r+XKnidI7952LrQqguFTsqHiNnlOF8FjLnw/XXbvUtALwapaqWfg/TBeAeQDjkOVrUaVXw/bupAmjGq0BGnbqkZV8kE8PP16rxzVcvhu1WoXWcU0tOAGZpkjenNEDq9lFuujl50HYluySN/LNNao7XOJHDw4trd6fK7b62ejiVjJAYUFbk6pCvMlQzxvSKUXNTr3aObXD41ItvFEwSmwYOrYn+LJq8YCu/4EfZ0RCJtqZ/WuDGvfZ1p/tWg9MJ7IKZQPnaMbIVcp6LIPbjm4vC4egoPfqnCbice6n7A28jd5fYGU5/ty3fMx59KIs5qXDeAa8X88XkjSWSoOqBLEE2BnveHuzlbHykAoRsxP9IDZj+vqdgddx6q/HE/042ts8dcApfPnQjpX47T5X7ipxIBmvcHCfnImYVzwX3LwGnsmQIdDjsFyQMyztrFs1MWSUaiHZkemZglWIBqZISBhgrWURzw61cMIm/NPoGwy0CDOUB/h+xR7w62NKH MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5a59cdee-b675-421b-bbd8-08d3a0ca48e8 X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB1927; 2:h9nQmMEmPGtVRur47OIQjb+N6TQH1lF+wHATEIaLzLVeGHojGVDdZRZS6tXrmTXhGNXZrngt74gCsH0h4wxoDBBjv/2oV99GsQRJ9etl6Iyle/2TRXSUq3YBL8DAK17ZYw4J0J6XskPihJYRNp3dkruYavh9J7Y8jt03TnS5qRxBdrlYdA/gZL8fZkESpUlO; 3:1tVG5phhTwqkGndNSaIeTB/DMzXCZrxS6usitPMCcAlwqKTLOnrXwkJqg4bp5o5pk6Ylx30sag1QjEScCZKBuiQXOH/tDtFOhd4Z3H5Ox0w4zamYifeblIV3cgB2RW/C8xH3Tt5H3SI79qLNbiuUWQWsLdgeKryq//hU4YsOOV7WXPNMyusiAZKhiv8QCmwzB6mLPeRzycNPZgoVuMDVF/FHAiExlp7AFxgD9BmKuFk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB1927; X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB1927; 25:B4epIoZq+o7ssNbzHwGNYa9lr17K6U/hvTNDfT7NDRTe2ysXFlHLxk+mDOcCeJWCEgneqXFRbmmTQzUtQ/waZQ4QHC3AF0D0iQRpAArY2LMoP/m52g6x2jGjr3M1EXRW89hHOUp2pWmYjucKkCM9JfXwaSXPxPIls/DlEeOVsvo0wM6Qa9IQJuEI7c9/15r73oDmGJUh4SzBUX86z5FLbqOQ9E2h2GoWvQKXgff9wuQDGl2K8D9LYFNYDZUVmAZGu/ZXornSP1FoifUip0ju7QAyPzDi0UMOzCR1mUXiT8DahThGgKIpyKK4ituyVJY9RZoNUnf/HKeiRNJi7Wwz2OK0wEAvXzwiVZV/YqItmxgJ5xkGtFAKiH1fAROOgyZv56POf9wDTVkPcaXK4I/+LYpXqQ48W1c/UpydNjqt06qHY+T5jl5wRnGZMO2JeBp1Y5gxdZ9eaztXylMcetc+RwzdC/2WWc2dNi4wcpGkCbt4iy8lhfByikCTiv5CU53WI7G2w5hI4iO1G0GnKE76QjDG0SnzRhXNpZxwbwo7i9K6Cc3Gw+i4fccJq/9Y4x978WedvwtW/ZuiXz7xz+Qjdg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(13015025)(13018025)(13017025)(13024025)(13023025)(10201501046)(3002001)(6055026); SRVR:BY2PR03MB1927; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR03MB1927; X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB1927; 4:mW0SGDDeYHgcEdJMyeK41fPUGih1CaeZqJ/DCsYXkJVwN1WxeD73W/4M42G8I3TMMKdFsTmisJ3x2uD7YEflci4qlGX5bbw5RJoM57Vm8AP6FWnk2VDtq52iM8CAjME2VuHdIcavvNU0RzbU+EMFv+h3ndzZXSHMdPAKeJRTZoYSmKCj8FgY1CwRCzbJi8/V1sOTXKaIstHOCz8FfDKpKsPmGlRRnMDXn7ykNMRGDiQnWgmzl1PlA/if7z1ggxHlPV/Itd/EdwPUUB6xPzTiqD2JXQRvP3sTlMgdukXk0rXXPSFE+rzUojZCscqj5dfkCnF3sQ2S8Rd6+FTGoKH5gF7JNauHd2AVyzQ7AJk9ab4u/eZuDtepNC1M9XwKk7ZZtXhkpLVAfh7nXqAZcBwJ+1a6B2LscjC5hjNyekIFx0nl29Plvk50zt07QA/PQJRd3xKYt6oQ1OjDwDr8Iq0QJTh8bBlybsKFunA3Xbbs1Bediz2RwSQif2sPDpVDt3aGtyZTTtgT6EaLQoML2mz7UA== X-Forefront-PRVS: 0989A7979C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR03MB1927; 23:CGdIIk9cIjyY4SwPZZAgy2WbpQ2SfcNA/nM0G5oAE?= =?us-ascii?Q?iL9JDA9mwOl+IsmuJU9EMx0UIfOe2veKBt3zDGoAdOHir1nYkla/FNGT6Khc?= =?us-ascii?Q?6fYCRE+zlNStEEJmdV9sTa+IGWqVCB+kZ4EhblwTLVaIWiiH9WEST1NLI4ts?= =?us-ascii?Q?Ze2VplM/rvVz/d4HVX2F8lvN8JG1N7PT3oMTQoJY5vUF/CDaWQQ3gzopMR06?= =?us-ascii?Q?DXR1wvW8ayjVUqBsRBInzQGXvG7Dmrf5IdP02RY1kDPe5sRtCwe7ADiEYj05?= =?us-ascii?Q?DMFdAL08bQwQ7utUIEwsECuaYV38zxHY/05dlNjeyyGCLKzIsAmyvsimUDgy?= =?us-ascii?Q?xaKt/Mhu7F504malK8mKLfhGhngqDbMtZeqUlPABdi/83E5ROejcg/UQGX72?= =?us-ascii?Q?6Yj23vKRnhQhw+hGYfCr+2m6wixu5pgZkqmR0Ngg1bZefOA3d/VDOCJRfI/y?= =?us-ascii?Q?SsFPMrYfSvO6LHgXhb4ATYd1cv58UsBGB+d7IOOslRJyumdwi5EV5OgtkpR6?= =?us-ascii?Q?xb57uJ+yvxBuOVD8qE1YO0LtqtDlw2vGruuhK7hdK9axnHeX9ImQsJXadHqh?= =?us-ascii?Q?R/JaRlZkPZ93ImZk5AAn8s1nFK+/+IUuN+KYQMrogGCg9D6p+thnJLf+siXV?= =?us-ascii?Q?luWCFWBJr1mr8WsCY0nM6gGS1NeZcfEQiMadG32o2uRoQBb2/tzcWrjOKJ73?= =?us-ascii?Q?fHWzdNDExYp1ATJ2ArWtTNENwqbdEZAMncFk6fu7k9LDi2xTa+gWaMoPMwBY?= =?us-ascii?Q?eo91zl5R5fpV2TFgW/P1gf+DXjcBnTKl168hMnZ+8grS3k6S2ZAoQlSlDiCo?= =?us-ascii?Q?/M94N0wBpJPJjAZIEd8i53SoWf0rCdb0WPW5foF6XjkwDceavlhdU5fJnEPl?= =?us-ascii?Q?fPmIpYWB5ni2DNCR5uUYOnluYxhsedPuwghIjNpEnjPbcJ+dM579ZxITOaTr?= =?us-ascii?Q?9ZI6J7BMojnFfoOTDDMlN4bmkJE+t1iCrZJYOytlgl7owCfu6SE9g7ihi7k9?= =?us-ascii?Q?L2QQ3aw00jCBzE7UhxPpeMbiGCDQg0GOnObwnzGflhP9HSRhlY8nN3CmtvYf?= =?us-ascii?Q?YKVlYALxIzFP3dth8Xj0RJDMXjyooD3Yhw+u5+p1gyjDFYaSVrVE35asC6ek?= =?us-ascii?Q?6qSxua6UlihIQwkuO6gUN2SGxGIQSP6uoDRtJYtYPYA6NN9c4xSiEWx+dnTq?= =?us-ascii?Q?VtvsCHRL2G0nTNM8fYLxnlLAmAvIPMwgI0wMtYeIKNtvDkVVdZouF1lvw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB1927; 5:ALci+J20juD3RXJkup+biLjYBbcuoVDW/mCL9+0UADKTjeduX53xnmrBNF0QrZocsPUo/ABE2y8vG60gafULrUsbu2gJBopI/yBEiDqkuGF4/xq6LiwXkers8oPphoRbTEbb34d8SHh0cnnj7Bb6F/gchYVLFOcjDlIOStHabEQ=; 24:49LctOH2U56I9dFT8kxNx4FVE6ZtObBPb0nK887q3VrwWb2dHBMAuRe8H5GORzyfKifmeopwrGw9K+bNohHXafYI76nNUiatc04a7zXbXjI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2016 09:38:25.3925 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB1927 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Freescale i.MX7D platform, all clocks operations, including enable/disable, rate change and re-parent, requires its parent clock enable. Current clock core can not support it well. This patch introduce a new flag CLK_OPS_PARENT_ENABLE to handle this special case in clock core that enable its parent clock firstly for each operation and disable it later after operation complete. The patch part 1 fixes the possible disabling clocks while its parent is off during kernel booting phase in clk_disable_unused_subtree(). Before the completion of kernel booting, clock tree is still not built completely, there may be a case that the child clock is on but its parent is off which could be caused by either HW initial reset state or bootloader initialization. Taking bootloader as an example, we may enable all clocks in HW by default. And during kernel booting time, the parent clock could be disabled in its driver probe due to calling clk_prepare_enable and clk_disable_unprepare. Because it's child clock is only enabled in HW while its SW usecount in clock tree is still 0, so clk_disable of parent clock will gate the parent clock in both HW and SW usecount ultimately. Then there will be a child clock is still on in HW but its parent is already off. Later in clk_disable_unused(), this clock disable accessing while its parent off will cause system hang due to the limitation of HW which must require its parent on. This patch simply enables the parent clock first before disabling if flag CLK_OPS_PARENT_ENABLE is set in clk_disable_unused_subtree(). This is a simple solution and only affects booting time. After kernel booting up the clock tree is already created, there will be no case that child is off but its parent is off. So no need do this checking for normal clk_disable() later. Cc: Michael Turquette Cc: Stephen Boyd Cc: Shawn Guo Signed-off-by: Dong Aisheng --- drivers/clk/clk.c | 5 +++++ include/linux/clk-provider.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index e2e8f0c9f20a..e3bd28c9ef28 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -765,6 +765,9 @@ static void clk_disable_unused_subtree(struct clk_core *core) hlist_for_each_entry(child, &core->children, child_node) clk_disable_unused_subtree(child); + if (core->flags & CLK_OPS_PARENT_ENABLE) + clk_core_prepare_enable(core->parent); + flags = clk_enable_lock(); if (core->enable_count) @@ -789,6 +792,8 @@ static void clk_disable_unused_subtree(struct clk_core *core) unlock_out: clk_enable_unlock(flags); + if (core->flags & CLK_OPS_PARENT_ENABLE) + clk_core_disable_unprepare(core->parent); } static bool clk_ignore_unused; diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index fb39d5add173..d87837360254 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -33,6 +33,8 @@ #define CLK_RECALC_NEW_RATES BIT(9) /* recalc rates after notifications */ #define CLK_SET_RATE_UNGATE BIT(10) /* clock needs to run to set rate */ #define CLK_IS_CRITICAL BIT(11) /* do not gate, ever */ +/* parents need enable during gate/ungate, set rate and re-parent */ +#define CLK_OPS_PARENT_ENABLE BIT(12) struct clk; struct clk_hw;