diff mbox

clk: clk-conf: Fix error message when clock isn't found

Message ID 1467962078-30405-1-git-send-email-tomeu.vizoso@collabora.com (mailing list archive)
State Accepted, archived
Delegated to: Michael Turquette
Headers show

Commit Message

Tomeu Vizoso July 8, 2016, 7:14 a.m. UTC 
When failing to lookup the assigned clock for setting its parents, we
were previously printing a misleading error message that lead to think
that it was the parent clock what couldn't be found.

Change error message to make clear that it's the assigned clock what
couldn't be found in this case.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 drivers/clk/clk-conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Turquette July 8, 2016, 6:28 p.m. UTC | #1 
Quoting Tomeu Vizoso (2016-07-08 00:14:38)
> When failing to lookup the assigned clock for setting its parents, we
> were previously printing a misleading error message that lead to think
> that it was the parent clock what couldn't be found.
> 
> Change error message to make clear that it's the assigned clock what
> couldn't be found in this case.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

Applied.

Regards,
Mike

> ---
>  drivers/clk/clk-conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
> index 43a218f35b19..674785d968a3 100644
> --- a/drivers/clk/clk-conf.c
> +++ b/drivers/clk/clk-conf.c
> @@ -55,7 +55,7 @@ static int __set_clk_parents(struct device_node *node, bool clk_supplier)
>                 }
>                 clk = of_clk_get_from_provider(&clkspec);
>                 if (IS_ERR(clk)) {
> -                       pr_warn("clk: couldn't get parent clock %d for %s\n",
> +                       pr_warn("clk: couldn't get assigned clock %d for %s\n",
>                                 index, node->full_name);
>                         rc = PTR_ERR(clk);
>                         goto err;
> -- 
> 2.5.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
index 43a218f35b19..674785d968a3 100644
--- a/drivers/clk/clk-conf.c
+++ b/drivers/clk/clk-conf.c
@@ -55,7 +55,7 @@  static int __set_clk_parents(struct device_node *node, bool clk_supplier)
 		}
 		clk = of_clk_get_from_provider(&clkspec);
 		if (IS_ERR(clk)) {
-			pr_warn("clk: couldn't get parent clock %d for %s\n",
+			pr_warn("clk: couldn't get assigned clock %d for %s\n",
 				index, node->full_name);
 			rc = PTR_ERR(clk);
 			goto err;