| Message ID | 1472727108-18388-1-git-send-email-baoyou.xie@linaro.org (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
Hi, On Thu, Sep 01, 2016 at 06:51:48PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/clk/sunxi-ng/ccu_nk.c:17:6: warning: no previous prototype for 'ccu_nk_find_best' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> A similar patch has been merged already. Thanks! Maxime
diff --git a/drivers/clk/sunxi-ng/ccu_nk.c b/drivers/clk/sunxi-ng/ccu_nk.c index 4470ffc..2adb62e 100644 --- a/drivers/clk/sunxi-ng/ccu_nk.c +++ b/drivers/clk/sunxi-ng/ccu_nk.c @@ -14,7 +14,7 @@ #include "ccu_gate.h" #include "ccu_nk.h" -void ccu_nk_find_best(unsigned long parent, unsigned long rate, +static void ccu_nk_find_best(unsigned long parent, unsigned long rate, unsigned int max_n, unsigned int max_k, unsigned int *n, unsigned int *k) {
We get 1 warning when building kernel with W=1: drivers/clk/sunxi-ng/ccu_nk.c:17:6: warning: no previous prototype for 'ccu_nk_find_best' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks it 'static'. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/clk/sunxi-ng/ccu_nk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)