diff mbox

clk: rk808: Pass the right pointer as the get_hw context

Message ID 1473427506-28244-1-git-send-email-tomeu.vizoso@collabora.com (mailing list archive)
State Accepted, archived
Delegated to: Stephen Boyd
Headers show

Commit Message

Tomeu Vizoso Sept. 9, 2016, 1:25 p.m. UTC
Right now we are passing a pointer to a pointer to the structure that
will be used to fetch the clk hw, which gets casted later to a pointer
to the structure, thus getting garbage in the hw structs.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: a8b6e85db6a6 ("clk: rk808: Migrate to clk_hw based OF and
registration APIs")
---
 drivers/clk/clk-rk808.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Sept. 9, 2016, 6:07 p.m. UTC | #1
On 09/09, Tomeu Vizoso wrote:
> Right now we are passing a pointer to a pointer to the structure that
> will be used to fetch the clk hw, which gets casted later to a pointer
> to the structure, thus getting garbage in the hw structs.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Fixes: a8b6e85db6a6 ("clk: rk808: Migrate to clk_hw based OF and
> registration APIs")
> ---

Applied to clk-next
diff mbox

Patch

diff --git a/drivers/clk/clk-rk808.c b/drivers/clk/clk-rk808.c
index faa447e191ef..6461f2820a5b 100644
--- a/drivers/clk/clk-rk808.c
+++ b/drivers/clk/clk-rk808.c
@@ -138,7 +138,7 @@  static int rk808_clkout_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	return of_clk_add_hw_provider(node, of_clk_rk808_get, &rk808_clkout);
+	return of_clk_add_hw_provider(node, of_clk_rk808_get, rk808_clkout);
 }
 
 static int rk808_clkout_remove(struct platform_device *pdev)