| Message ID | 1474848223-19728-4-git-send-email-vz@mleia.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
Hello, On Mon, Sep 26, 2016 at 03:03:42AM +0300, Vladimir Zapolskiy wrote: > Function mx31_clocks_init() is called during clock intialization on > legacy boards with reference clock frequency passed as its input > argument, this can be verified by examination of the function > declaration found in arch/arm/mach-imx/common.h and actual function > users which include that header file. > > Inside CCF driver the function ignores its input argument, by chance > the used value in the function body is the same as input arguments on > side of all callers. > > Fixes: d9388c843237 ("clk: imx31: Do not call mxc_timer_init twice when booting with DT") > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On 09/26, Vladimir Zapolskiy wrote: > Function mx31_clocks_init() is called during clock intialization on > legacy boards with reference clock frequency passed as its input > argument, this can be verified by examination of the function > declaration found in arch/arm/mach-imx/common.h and actual function > users which include that header file. > > Inside CCF driver the function ignores its input argument, by chance > the used value in the function body is the same as input arguments on > side of all callers. > > Fixes: d9388c843237 ("clk: imx31: Do not call mxc_timer_init twice when booting with DT") > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> > --- Acked-by: Stephen Boyd <sboyd@codeaurora.org>
diff --git a/drivers/clk/imx/clk-imx31.c b/drivers/clk/imx/clk-imx31.c index 6a96414..6a49ba2 100644 --- a/drivers/clk/imx/clk-imx31.c +++ b/drivers/clk/imx/clk-imx31.c @@ -157,10 +157,8 @@ static void __init _mx31_clocks_init(unsigned long fref) } } -int __init mx31_clocks_init(void) +int __init mx31_clocks_init(unsigned long fref) { - u32 fref = 26000000; /* default */ - _mx31_clocks_init(fref); clk_register_clkdev(clk[gpt_gate], "per", "imx-gpt.0");
Function mx31_clocks_init() is called during clock intialization on legacy boards with reference clock frequency passed as its input argument, this can be verified by examination of the function declaration found in arch/arm/mach-imx/common.h and actual function users which include that header file. Inside CCF driver the function ignores its input argument, by chance the used value in the function body is the same as input arguments on side of all callers. Fixes: d9388c843237 ("clk: imx31: Do not call mxc_timer_init twice when booting with DT") Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> --- Changes from v1 to v2: * reworded commit message, thanks to Uwe for review drivers/clk/imx/clk-imx31.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)