| Message ID | 1475765999-14366-1-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
On Thu, Oct 06, 2016 at 11:59:59AM -0300, Javier Martinez Canillas wrote: > The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and > registration APIs") converted the driver to use the new provider API to > register clocks using clk_hw. > > But unfortunately, in the conversion it missed to set the num_clks value > which lead to the following error when trying to register a clk provider: > > [ 1.963782] of_clk_max77686_get: invalid index 0 > [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1) > [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock > > Fix it by correctly set the max77686_clk_driver_data num_clks member. > > Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs") > Reported-by: Markus Reichl <m.reichl@fivetechno.de> > Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > Tested-by: Markus Reichl <m.reichl@fivetechno.de> > > --- > > drivers/clk/clk-max77686.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Javier, On 2016년 10월 06일 23:59, Javier Martinez Canillas wrote: > The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and > registration APIs") converted the driver to use the new provider API to > register clocks using clk_hw. > > But unfortunately, in the conversion it missed to set the num_clks value > which lead to the following error when trying to register a clk provider: > > [ 1.963782] of_clk_max77686_get: invalid index 0 > [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1) > [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock > > Fix it by correctly set the max77686_clk_driver_data num_clks member. > > Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs") > Reported-by: Markus Reichl <m.reichl@fivetechno.de> > Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > Tested-by: Markus Reichl <m.reichl@fivetechno.de> > > --- > > drivers/clk/clk-max77686.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c > index b637f5979023..eb953d3b0b69 100644 > --- a/drivers/clk/clk-max77686.c > +++ b/drivers/clk/clk-max77686.c > @@ -216,6 +216,7 @@ static int max77686_clk_probe(struct platform_device *pdev) > return -EINVAL; > } > > + drv_data->num_clks = num_clks; > drv_data->max_clk_data = devm_kcalloc(dev, num_clks, > sizeof(*drv_data->max_clk_data), > GFP_KERNEL); > Looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
On 10/06, Javier Martinez Canillas wrote: > The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and > registration APIs") converted the driver to use the new provider API to > register clocks using clk_hw. > > But unfortunately, in the conversion it missed to set the num_clks value > which lead to the following error when trying to register a clk provider: > > [ 1.963782] of_clk_max77686_get: invalid index 0 > [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1) > [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock > > Fix it by correctly set the max77686_clk_driver_data num_clks member. > > Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs") > Reported-by: Markus Reichl <m.reichl@fivetechno.de> > Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > Tested-by: Markus Reichl <m.reichl@fivetechno.de> > > --- Applied to clk-fixes
diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c index b637f5979023..eb953d3b0b69 100644 --- a/drivers/clk/clk-max77686.c +++ b/drivers/clk/clk-max77686.c @@ -216,6 +216,7 @@ static int max77686_clk_probe(struct platform_device *pdev) return -EINVAL; } + drv_data->num_clks = num_clks; drv_data->max_clk_data = devm_kcalloc(dev, num_clks, sizeof(*drv_data->max_clk_data), GFP_KERNEL);
The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs") converted the driver to use the new provider API to register clocks using clk_hw. But unfortunately, in the conversion it missed to set the num_clks value which lead to the following error when trying to register a clk provider: [ 1.963782] of_clk_max77686_get: invalid index 0 [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1) [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock Fix it by correctly set the max77686_clk_driver_data num_clks member. Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs") Reported-by: Markus Reichl <m.reichl@fivetechno.de> Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Tested-by: Markus Reichl <m.reichl@fivetechno.de> --- drivers/clk/clk-max77686.c | 1 + 1 file changed, 1 insertion(+)