| Message ID | 1486436571-8682-2-git-send-email-baoyou.xie@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Feb 07, 2017 at 11:02:50AM +0800, Baoyou Xie wrote: > This patch documents the devicetree for the ZTE's zx296718 > I2S audio controller. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > Documentation/devicetree/bindings/sound/zte,zx-i2s.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt b/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt > index 7e5aa6f..c405561 100644 > --- a/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt > +++ b/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt > @@ -1,10 +1,12 @@ > ZTE ZX296702 I2S controller > > Required properties: > - - compatible : Must be "zte,zx296702-i2s" > + - compatible : Should include one of the following strings: > + "zte,zx296702-i2s","zte,zx296718-i2s". > - reg : Must contain I2S core's registers location and length > - clocks : Pairs of phandle and specifier referencing the controller's clocks. > - - clock-names: "tx" for the clock to the I2S interface. > + - clock-names: "tx" for the wclk, "pclk" for the pclk to the I2S interface. > + must contain pclk for zx296718 SoC. The 'pclk' is really required for zx296702-i2s as well. The driver may happen to work on zx296702 only because 'pclk' is already enabled by someone else before I2S driver starts working. Shawn > - dmas: Pairs of phandle and specifier for the DMA channel that is used by > the core. The core expects two dma channels for transmit. > - dma-names : Must be "tx" and "rx" > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 07, 2017 at 11:02:50AM +0800, Baoyou Xie wrote: > This patch documents the devicetree for the ZTE's zx296718 > I2S audio controller. Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing.
diff --git a/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt b/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt index 7e5aa6f..c405561 100644 --- a/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt +++ b/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt @@ -1,10 +1,12 @@ ZTE ZX296702 I2S controller Required properties: - - compatible : Must be "zte,zx296702-i2s" + - compatible : Should include one of the following strings: + "zte,zx296702-i2s","zte,zx296718-i2s". - reg : Must contain I2S core's registers location and length - clocks : Pairs of phandle and specifier referencing the controller's clocks. - - clock-names: "tx" for the clock to the I2S interface. + - clock-names: "tx" for the wclk, "pclk" for the pclk to the I2S interface. + must contain pclk for zx296718 SoC. - dmas: Pairs of phandle and specifier for the DMA channel that is used by the core. The core expects two dma channels for transmit. - dma-names : Must be "tx" and "rx"
This patch documents the devicetree for the ZTE's zx296718 I2S audio controller. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- Documentation/devicetree/bindings/sound/zte,zx-i2s.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)