diff mbox

clk: imx7d: Fix the DDR PLL enable bit

Message ID 1496763954-10981-1-git-send-email-fabio.estevam@nxp.com (mailing list archive)
State Accepted
Delegated to: Stephen Boyd
Headers show

Commit Message

Fabio Estevam June 6, 2017, 3:45 p.m. UTC
Commit ad14972422899b6 ("clk: imx7d: Fix the powerdown bit location
of PLL DDR") used the incorrect bit for the IMX_PLLV3_DDR_IMX7 case.

Fix it accordingly to avoid a kernel hang.

Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/clk/imx/clk-pllv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Agner June 6, 2017, 4:29 p.m. UTC | #1
On 2017-06-06 08:45, Fabio Estevam wrote:
> Commit ad14972422899b6 ("clk: imx7d: Fix the powerdown bit location
> of PLL DDR") used the incorrect bit for the IMX_PLLV3_DDR_IMX7 case.
> 
> Fix it accordingly to avoid a kernel hang.

Yeah that sneaked in with the rename of the define between v1 -> v2,
didn't saw that sorry.

FWIW,

Reviewed-by: Stefan Agner <stefan@agner.ch>

--
Stefan

> 
> Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/clk/imx/clk-pllv3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> index 0039b16..9af62ee 100644
> --- a/drivers/clk/imx/clk-pllv3.c
> +++ b/drivers/clk/imx/clk-pllv3.c
> @@ -453,7 +453,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type
> type, const char *name,
>  		ops = &clk_pllv3_enet_ops;
>  		break;
>  	case IMX_PLLV3_DDR_IMX7:
> -		pll->power_bit = IMX7_ENET_PLL_POWER;
> +		pll->power_bit = IMX7_DDR_PLL_POWER;
>  		ops = &clk_pllv3_av_ops;
>  		break;
>  	default:
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Boyd June 7, 2017, 12:42 a.m. UTC | #2
On 06/06, Fabio Estevam wrote:
> Commit ad14972422899b6 ("clk: imx7d: Fix the powerdown bit location
> of PLL DDR") used the incorrect bit for the IMX_PLLV3_DDR_IMX7 case.
> 
> Fix it accordingly to avoid a kernel hang.
> 
> Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---

Applied to clk-next
diff mbox

Patch

diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
index 0039b16..9af62ee 100644
--- a/drivers/clk/imx/clk-pllv3.c
+++ b/drivers/clk/imx/clk-pllv3.c
@@ -453,7 +453,7 @@  struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name,
 		ops = &clk_pllv3_enet_ops;
 		break;
 	case IMX_PLLV3_DDR_IMX7:
-		pll->power_bit = IMX7_ENET_PLL_POWER;
+		pll->power_bit = IMX7_DDR_PLL_POWER;
 		ops = &clk_pllv3_av_ops;
 		break;
 	default: