| Message ID | 1501017662-9239-1-git-send-email-sergej@taudac.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
On 07/25, Sergej Sawazki wrote: > This drivers probe fails due to a clock name collision if a clock named > 'plla' or 'pllb' is already registered when registering this drivers > internal plls. > > Fix it by renaming internal plls to avoid name collisions. > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Rabeeh Khoury <rabeeh@solid-run.com> > Signed-off-by: Sergej Sawazki <sergej@taudac.com> > --- Is this needed still? I was expecting Sebastian to review.
Am 13.10.2017 um 00:51 schrieb Stephen Boyd: > On 07/25, Sergej Sawazki wrote: >> This drivers probe fails due to a clock name collision if a clock named >> 'plla' or 'pllb' is already registered when registering this drivers >> internal plls. >> >> Fix it by renaming internal plls to avoid name collisions. > > Is this needed still? I was expecting Sebastian to review. > Yes, it is still needed. Can't use the driver on raspberry pi due to a name collision -- clock names "plla, pllb, plls, plld, pllh" already used. Sergej -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/25, Sergej Sawazki wrote: > This drivers probe fails due to a clock name collision if a clock named > 'plla' or 'pllb' is already registered when registering this drivers > internal plls. > > Fix it by renaming internal plls to avoid name collisions. > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Rabeeh Khoury <rabeeh@solid-run.com> > Signed-off-by: Sergej Sawazki <sergej@taudac.com> > --- Applied to clk-next
diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c index 6cca425..2866dcd 100644 --- a/drivers/clk/clk-si5351.c +++ b/drivers/clk/clk-si5351.c @@ -72,7 +72,7 @@ static const char * const si5351_input_names[] = { "xtal", "clkin" }; static const char * const si5351_pll_names[] = { - "plla", "pllb", "vxco" + "si5351_plla", "si5351_pllb", "si5351_vxco" }; static const char * const si5351_msynth_names[] = { "ms0", "ms1", "ms2", "ms3", "ms4", "ms5", "ms6", "ms7"
This drivers probe fails due to a clock name collision if a clock named 'plla' or 'pllb' is already registered when registering this drivers internal plls. Fix it by renaming internal plls to avoid name collisions. Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Cc: Rabeeh Khoury <rabeeh@solid-run.com> Signed-off-by: Sergej Sawazki <sergej@taudac.com> --- Issue observed on a RaspberryPi with kernel version 4.9.24-v7+, the clock tree contains clocks named 'plla' and 'pllb'. drivers/clk/clk-si5351.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)