diff mbox

usb: dwc3: of-simple: remove include of clk-provider.h

Message ID 1502634071-2266-1-git-send-email-shawnguo@kernel.org (mailing list archive)
State Awaiting Upstream, archived
Delegated to: Stephen Boyd
Headers show

Commit Message

Shawn Guo Aug. 13, 2017, 2:21 p.m. UTC 
From: Shawn Guo <shawn.guo@linaro.org>

The header clk-provider.h is there for clock drivers (providers) to
include, not client drivers (consumers).  That said,
of_clk_get_parent_count() is a helper function for clock providers, not
a clk API for consumers.

Let's replace of_clk_get_parent_count() with of_count_phandle_with_args()
call, so that we can remove the include of clk-provider.h.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 drivers/usb/dwc3/dwc3-of-simple.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Boyd Aug. 17, 2017, 9:06 p.m. UTC | #1 
On 08/13, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@linaro.org>
> 
> The header clk-provider.h is there for clock drivers (providers) to
> include, not client drivers (consumers).  That said,
> of_clk_get_parent_count() is a helper function for clock providers, not
> a clk API for consumers.
> 
> Let's replace of_clk_get_parent_count() with of_count_phandle_with_args()
> call, so that we can remove the include of clk-provider.h.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---

Acked-by: Stephen Boyd <sboyd@codeaurora.org>
diff mbox

Patch

diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index fe414e7a9c78..4cef7d4f9cd0 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -25,7 +25,6 @@ 
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
 #include <linux/clk.h>
-#include <linux/clk-provider.h>
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/pm_runtime.h>
@@ -96,7 +95,8 @@  static int dwc3_of_simple_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, simple);
 	simple->dev = dev;
 
-	ret = dwc3_of_simple_clk_init(simple, of_clk_get_parent_count(np));
+	ret = dwc3_of_simple_clk_init(simple, of_count_phandle_with_args(np,
+						"clocks", "#clock-cells"));
 	if (ret)
 		return ret;