From patchwork Sat Dec 30 01:12:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10137559 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B739E6037D for ; Sat, 30 Dec 2017 01:18:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA7432B551 for ; Sat, 30 Dec 2017 01:18:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9F1F52B55D; Sat, 30 Dec 2017 01:18:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FD9F2B55A for ; Sat, 30 Dec 2017 01:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751211AbdL3BSa (ORCPT ); Fri, 29 Dec 2017 20:18:30 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39316 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbdL3BNb (ORCPT ); Fri, 29 Dec 2017 20:13:31 -0500 Received: by mail-wm0-f67.google.com with SMTP id i11so50090654wmf.4 for ; Fri, 29 Dec 2017 17:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pPAXGXZ93QbOy5wG9swfXAxSE9h/zyfswFK5EBERFeA=; b=tRYAQSMO7EwjkRNQvcluL/k5eetYYD76yM7K0FrRfh8m+oQRCyrZK0IdcYFYQHMWhq tfnhngDbrcKGTSoaM+Ei1iq474DQJzADtIQnHFt+ogbqGFxx4vCRvSXq2kEf8keMM8n+ 6Pj97h3s56b8zTYrm4Au/NF2P6VL4dSUfDvmqGjrlwx0wYdRxrsig35DSvKgPgtQr0+K PkcGNhG6I7tNSPf9s0q5gt/DD9dyXcijaVDE+n+sFetffRlIkMoEMg8gILCQ5z3s2R3L r8BQp6z/W+RevO58yqzAKfnA+G1EiJMjVjHipBbxv9m4gb4MFdxoPUx9RPczs3gseJWt jnLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pPAXGXZ93QbOy5wG9swfXAxSE9h/zyfswFK5EBERFeA=; b=rKDBP1TjGtvRo+FarzKWjFUVKPbWYRqVPKk32DLwuie1bj82po3/rncN/vosGSvmcE 9pjVftO5acLenH5YlUgOU+X3V/ZOHwhqQboiA6nRVS6F28SvnQMBfuks0PNxmWd0itO/ e6bZYaNi3+oFJ6XOfVHVxToIuLO+pC/V7zEtYM+aW8Pf1s9/1JcegUPlExD4hBzuZ1ki fM0m6t4Jdv6pBDB2FS8MeOMXOhWZFSwxy80hveZogRsKyjvbTRYsdbCTgC3E9Vn/8ctN qadYFag2pNu5H46MPBTNfG3oToI73kng0yICDpQPjTpung+1RqIYKq38HuFyD7Mb85C+ qrEQ== X-Gm-Message-State: AKGB3mIcZpuBfjsPLduyVHSby8Tw9aOw8JDt0pRqu4mECuIWAWaZE7HZ GxSh1VDV1DjzsPXcuZWzphrVxw== X-Google-Smtp-Source: ACJfBoshIce/tfmG/G3GbS0gIbs4pV9B5ldrOf3t7fl/eaQG9GYxY3nLc89q2t+z0aWycRTQbxlcSw== X-Received: by 10.80.220.132 with SMTP id r4mr32891976edk.180.1514596409988; Fri, 29 Dec 2017 17:13:29 -0800 (PST) Received: from localhost.localdomain ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id h4sm29818268edb.16.2017.12.29.17.13.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Dec 2017 17:13:29 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: pure.logic@nexus-software.ie, Shawn Guo Subject: [PATCH 18/33] clk: mxs: change clk_frac_round_rate() return logic Date: Sat, 30 Dec 2017 01:12:57 +0000 Message-Id: <1514596392-22270-19-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie> References: <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Shawn Guo --- drivers/clk/mxs/clk-frac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mxs/clk-frac.c b/drivers/clk/mxs/clk-frac.c index f57281f..9debf86 100644 --- a/drivers/clk/mxs/clk-frac.c +++ b/drivers/clk/mxs/clk-frac.c @@ -59,7 +59,7 @@ static unsigned long clk_frac_round_rate(struct clk_hw *hw, unsigned long rate, u64 tmp, tmp_rate, result; if (rate > parent_rate) - return -EINVAL; + return 0; tmp = rate; tmp <<= frac->width; @@ -67,7 +67,7 @@ static unsigned long clk_frac_round_rate(struct clk_hw *hw, unsigned long rate, div = tmp; if (!div) - return -EINVAL; + return 0; tmp_rate = (u64)parent_rate * div; result = tmp_rate >> frac->width;