From patchwork Sat Dec 30 01:12:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10137609 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 12112603FA for ; Sat, 30 Dec 2017 01:21:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 02BC02D7A9 for ; Sat, 30 Dec 2017 01:21:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E8FCF2D7BB; Sat, 30 Dec 2017 01:21:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 908D62D7A9 for ; Sat, 30 Dec 2017 01:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750794AbdL3BUt (ORCPT ); Fri, 29 Dec 2017 20:20:49 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:45488 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdL3BNQ (ORCPT ); Fri, 29 Dec 2017 20:13:16 -0500 Received: by mail-wm0-f68.google.com with SMTP id 9so50432250wme.4 for ; Fri, 29 Dec 2017 17:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=quYEV7WVBM557n8sBg+B64GNpgz2/9llWnkNitw5Who=; b=C0lNxdyrLU95BAvfgcr0JnIvapSM/vcwnof3M7KTavspkcgaPlm6j3hBNJwmH3hlBY 9dh2rF5lxy9JZz8znVufsa7F4sccUvn2pv3bEWdzXwDy/JvTn3RGcmPPVfel0SbpLWb2 m4ERAC+B6e43qHzMOaFGN7K/6asJATgd5slA3MqcTc0N4Ht0XLGwxlwrY31ngG9rF5KG QWLQ991D9ZZJA7doAYArliOkWJeLKRnI+us7HIxF8MO1rHBoZntAi+h03e3mpx1t+uzL cJ/RoVsCUrMpXg/oM5m0wCxKvOSGSPeS3JQo9vNZdLld4xp9DXc9ErU4+sY9vw7vS2r4 CGbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=quYEV7WVBM557n8sBg+B64GNpgz2/9llWnkNitw5Who=; b=U9MnkoA6y4yvLqvSOPFu+kP7M1dSdOnalgfp6HATh92X24virC1+aA9k22uwVHsOx7 nxGJqovvkYjukL/iYK9n/5BRGtksxZ5nvE34KoPMJMejc5P9+65C4ZDqi5JRQ9qsnZSO DizBJC2buglZdYlxzRHHAImzxpA/BVJrHK3F+jlS0ylZFK25hqoH+Eo4NhHXxjxeSvzh FC/TZfatYckT5VMIpWbJIPDBuZ5UCio2oLcsD3xzhEkxMxOiICj/KYXViklLFYS/ZFf8 ylBXCHqy6MkZRzeQoDex90WuBMHUb4qmFoDDsoZS2VPfTKeoowslUp78fO4SJ5yVO7fl TcSw== X-Gm-Message-State: AKGB3mLRbW5jCV9jXDhp+QCXpNy/fdZ8X3u36tO9JpwsB+oKYRfopfGY TyBPmzxrONRWOBUJABJEjhJgzzSo X-Google-Smtp-Source: ACJfBouC1abwVVCAY9x0I9YVd+PQrKxhx61ft0ngAfh4+4Wa5h1CsK/IJXesyAffxPd6T+9AuHWqhw== X-Received: by 10.80.181.49 with SMTP id y46mr46117549edd.29.1514596395138; Fri, 29 Dec 2017 17:13:15 -0800 (PST) Received: from localhost.localdomain ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id h4sm29818268edb.16.2017.12.29.17.13.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Dec 2017 17:13:14 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: pure.logic@nexus-software.ie Subject: [PATCH 02/33] clk: core: update divider_round_rate functions to return unsigned long Date: Sat, 30 Dec 2017 01:12:41 +0000 Message-Id: <1514596392-22270-3-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie> References: <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Returning a long from round_rate() class functions is rooted in the notion that we will propagate a negative number on some class of failure to round a clock rate; however this approach does not scale to 32 bit systems which legitimately round a clock over LONG_MAX as the returned clock rate is indistinguishable from an error number. A better approach is to return zero when we cannot round a clock and non-zero when we can - thus supporting the full range of the unsigned long rate input value to round_rate() functions. Update the signature of divider_round_rate functions to do this now. Signed-off-by: Bryan O'Donoghue Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/clk-divider.c | 10 ++++++---- include/linux/clk-provider.h | 19 +++++++++++-------- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index a26ec7c..e827304 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -332,10 +332,12 @@ static int clk_divider_bestdiv(struct clk_hw *hw, struct clk_hw *parent, return bestdiv; } -long divider_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, - unsigned long rate, unsigned long *prate, - const struct clk_div_table *table, - u8 width, unsigned long flags) +unsigned long divider_round_rate_parent(struct clk_hw *hw, + struct clk_hw *parent, + unsigned long rate, + unsigned long *prate, + const struct clk_div_table *table, + u8 width, unsigned long flags) { int div; diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index 79b1d6e..e763d94 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -413,10 +413,12 @@ extern const struct clk_ops clk_divider_ro_ops; unsigned long divider_recalc_rate(struct clk_hw *hw, unsigned long parent_rate, unsigned int val, const struct clk_div_table *table, unsigned long flags); -long divider_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, - unsigned long rate, unsigned long *prate, - const struct clk_div_table *table, - u8 width, unsigned long flags); +unsigned long divider_round_rate_parent(struct clk_hw *hw, + struct clk_hw *parent, + unsigned long rate, + unsigned long *prate, + const struct clk_div_table *table, + u8 width, unsigned long flags); int divider_get_val(unsigned long rate, unsigned long parent_rate, const struct clk_div_table *table, u8 width, unsigned long flags); @@ -762,10 +764,11 @@ static inline void __clk_hw_set_clk(struct clk_hw *dst, struct clk_hw *src) dst->core = src->core; } -static inline long divider_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate, - const struct clk_div_table *table, - u8 width, unsigned long flags) +static inline unsigned long divider_round_rate(struct clk_hw *hw, + unsigned long rate, + unsigned long *prate, + const struct clk_div_table *table, + u8 width, unsigned long flags) { return divider_round_rate_parent(hw, clk_hw_get_parent(hw), rate, prate, table, width, flags);