From patchwork Sat Dec 30 01:13:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10137469 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BECB96037D for ; Sat, 30 Dec 2017 01:14:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B20D82D23A for ; Sat, 30 Dec 2017 01:14:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A6B082D245; Sat, 30 Dec 2017 01:14:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 46C8A2D23A for ; Sat, 30 Dec 2017 01:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751318AbdL3BNr (ORCPT ); Fri, 29 Dec 2017 20:13:47 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:41185 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdL3BNo (ORCPT ); Fri, 29 Dec 2017 20:13:44 -0500 Received: by mail-wm0-f67.google.com with SMTP id g75so50745133wme.0 for ; Fri, 29 Dec 2017 17:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dR18/oejCALiWSgbOvjO7r98++P30n5JOrS/EjAfWjE=; b=OcQbTkoCdsMf46GywM6se6pLlllmh7qJbIKn0EvaaBe2Kn7or7wMki6EGBMknIWRpS Xeba5xG/AXdeFc4WccokSwrnFqzVpok5yzY3JfqrzjXYXLd2udWwhY+AerOi3dHQCiFN z3x1TDpCgw65ISSh8QnuSeF2S5SSyMmlpAgSwkBUzrYohXCA94Hcj8FhybDQUZuXzfzz YXfs/ckUM1ve/vj0Ce8/55aA6+uAX28B/Iy6P5COsxC2GGtmAUVE7eVGaAtjmmzrQaMY yD+kIZ34xN+G5Msk88aMtmVCgySIpc2haR7yNTfkgf1B5vO8CKnouHFocbdonx+tPi3K AfDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dR18/oejCALiWSgbOvjO7r98++P30n5JOrS/EjAfWjE=; b=VCErcJVYJsAg6Z9Bcxs9AUcuKb0HDMJ0KOHztx141ZfJfQF5fWlus69CIzxbUEAI3K rVm/YzAQBQPik2FR+a1U79xFFEE+2J9QGg/t+k/R0mFCU/z5U/ai9qauFX2kZf8OCGmJ p6Ld8G8R7ZEXWEWYJyYnPTM4nC8HeT3zDr3GJuURdd/ynSQL+nWEcxJItxTgAj86z/8N k5lbVE2IkJ12MuTEZP7l2Yg1kAvngQ/eNMZTRtHM3u9FSO8Q1u8byISsVgq9NTlTqKGG HShegW+TfPUl2ZKUgT1/Xx1mFE9vxGGA7pDbE69+uvSX/Y77l2d71BV1meUoTJpevDXq OU8w== X-Gm-Message-State: AKGB3mK/QXbAQ36qPyY8qprZpVFN3oBHMKKcsOOUMLl7acpwNXvEBKBX 57TZqd3qMoqO/EBb3K9yqfyY5Q== X-Google-Smtp-Source: ACJfBouVBk5O8n/Tlbfqwcm/GAZEIem6wyycGEG2SDJIe+kpXXMZP8kcvjqima4hzTesMdN/GERN6w== X-Received: by 10.80.240.200 with SMTP id a8mr46591725edm.288.1514596423421; Fri, 29 Dec 2017 17:13:43 -0800 (PST) Received: from localhost.localdomain ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id h4sm29818268edb.16.2017.12.29.17.13.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Dec 2017 17:13:42 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: pure.logic@nexus-software.ie, Vladimir Zapolskiy , Sylvain Lemieux , Gabriel Fernandez , linux-arm-kernel@lists.infradead.org Subject: [PATCH 32/33] clk: lpc32xx: change round_rate() return logic Date: Sat, 30 Dec 2017 01:13:11 +0000 Message-Id: <1514596392-22270-33-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie> References: <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Michael Turquette Cc: Stephen Boyd Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Gabriel Fernandez Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/nxp/clk-lpc32xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c index 76c17f4..0e0d258 100644 --- a/drivers/clk/nxp/clk-lpc32xx.c +++ b/drivers/clk/nxp/clk-lpc32xx.c @@ -664,17 +664,17 @@ static unsigned long clk_usb_pll_round_rate(struct clk_hw *hw, * USB divider, USB PLL N and M parameters. */ if (rate != 48000000) - return -EINVAL; + return 0; /* USB divider clock */ usb_div_hw = clk_hw_get_parent_by_index(hw, 0); if (!usb_div_hw) - return -EINVAL; + return 0; /* Main oscillator clock */ osc_hw = clk_hw_get_parent_by_index(usb_div_hw, 0); if (!osc_hw) - return -EINVAL; + return 0; o = clk_hw_get_rate(osc_hw); /* must be in range 1..20 MHz */ /* Check if valid USB divider and USB PLL parameters exists */ @@ -697,7 +697,7 @@ static unsigned long clk_usb_pll_round_rate(struct clk_hw *hw, } } - return -EINVAL; + return 0; } #define LPC32XX_DEFINE_PLL_OPS(_name, _rc, _sr, _rr) \