From patchwork Mon Jan 1 19:43:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10139469 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 45D4560362 for ; Mon, 1 Jan 2018 19:47:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 377BF286FB for ; Mon, 1 Jan 2018 19:47:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C89B286FE; Mon, 1 Jan 2018 19:47:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7388286FB for ; Mon, 1 Jan 2018 19:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850AbeAATq4 (ORCPT ); Mon, 1 Jan 2018 14:46:56 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:41585 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932121AbeAATni (ORCPT ); Mon, 1 Jan 2018 14:43:38 -0500 Received: by mail-wm0-f68.google.com with SMTP id g75so58610683wme.0 for ; Mon, 01 Jan 2018 11:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xpd3kXaXigbGNzIi+9t6Q4zL9FYAiazRrWc0MtR9zps=; b=l+RJCMciY6Rx/Pe+jlsjXJqNnxjNpge9CfPhxXLvE/IYog4M+ix3IEOiqqMuwmwSED 4Ik6gsp52846eCIgSWf1o/UHMUYO2Wg1k38C4BGIF0KNUsjH+0DHAmQWgGzZTrtroIx+ 2HFHjzis+5132YUD/paRHR+Rnep0TggqM0psrI6ZuFSBJGymPlulhJQqsdbfW9qevtWI ihFdmtXhDVCn/DkLyl87dptrWbTi0rzLbSmDp35EEzbtfLu2qzr8cDjNZkpODLdItY4X /AR5wZbjik8aX2SyIDolHrriuGKaBT146qEQQ3QM7nIWjeEyLckwY+te6LwMQdySZvVB xvaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xpd3kXaXigbGNzIi+9t6Q4zL9FYAiazRrWc0MtR9zps=; b=ZfP1RpQwQmRVn7QF+kOUyFDwZxLY89s5Fnnc7A6HYCgvlsiAZS/nY9O1Rd2DN9rYAT TIHxQGzuU5AY8mu7M6M5jX/0AqPyL2yGjkZAwZKuheLHtkIPCWTDLsMsrT7kezZXc9tV GyMOolCT95LUB7LCz8oibkewFOSJ5cmtxML+ynK60tXRZnNUGjtXB5IYICE9rXaBsztW nTlWww02Q5GxTmiP+2lQDOhfkfw1+fCgT1Os8Dez52RmtygIfYNGKlYFEsRmLeMPZLSB oAQOd/alyL4ahqKopM/sbldqr38VdWpUpTHID/hSFjOBaxTDuHY6RLCNsXBMSL1iT8Hi FjOw== X-Gm-Message-State: AKGB3mJH/qNoeGeQUz6X76SrgueWju4tJSyJ5M13L/7wZDyh7qLjmvgL hw3j7VgtkuGIBlsD4IFqvtH/hg== X-Google-Smtp-Source: ACJfBovq3WGfrjPN1ITDqnGnRuTcCBq9ucW+YMIucc5C/RSTkj3gMI/JZislmRptiH6SRmMKR+zWWA== X-Received: by 10.80.137.9 with SMTP id e9mr59086629ede.199.1514835817110; Mon, 01 Jan 2018 11:43:37 -0800 (PST) Received: from localhost.localdomain (D4CCACC7.cm-2.dynamic.ziggo.nl. [212.204.172.199]) by smtp.gmail.com with ESMTPSA id w2sm39361075edb.4.2018.01.01.11.43.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Jan 2018 11:43:36 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Sylvain Lemieux , Gabriel Fernandez , linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 21/34] clk: lpc32xx: change clk_hclk_pll_round_rate() return logic Date: Mon, 1 Jan 2018 19:43:00 +0000 Message-Id: <1514835793-1104-22-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> References: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Michael Turquette Cc: Stephen Boyd Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Gabriel Fernandez Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/nxp/clk-lpc32xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c index 81ab57d..76c17f4 100644 --- a/drivers/clk/nxp/clk-lpc32xx.c +++ b/drivers/clk/nxp/clk-lpc32xx.c @@ -595,7 +595,7 @@ static unsigned long clk_hclk_pll_round_rate(struct clk_hw *hw, pr_debug("%s: %lu/%lu\n", clk_hw_get_name(hw), *parent_rate, rate); if (rate > 266500000) - return -EINVAL; + return 0; /* Have to check all 20 possibilities to find the minimal M */ for (p_i = 4; p_i >= 0; p_i--) { @@ -622,7 +622,7 @@ static unsigned long clk_hclk_pll_round_rate(struct clk_hw *hw, if (d == (u64)rate << 6) { pr_err("%s: %lu: no valid PLL parameters are found\n", clk_hw_get_name(hw), rate); - return -EINVAL; + return 0; } clk->m_div = m;