From patchwork Tue Mar 20 16:56:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 10297501 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8266260349 for ; Tue, 20 Mar 2018 16:56:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7308128BE1 for ; Tue, 20 Mar 2018 16:56:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 673102925F; Tue, 20 Mar 2018 16:56:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D54E28BE1 for ; Tue, 20 Mar 2018 16:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbeCTQ44 convert rfc822-to-8bit (ORCPT ); Tue, 20 Mar 2018 12:56:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:47174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbeCTQ4z (ORCPT ); Tue, 20 Mar 2018 12:56:55 -0400 Received: from localhost (unknown [104.132.1.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59C9921770; Tue, 20 Mar 2018 16:56:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59C9921770 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sboyd@kernel.org MIME-Version: 1.0 To: David Lechner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org From: Stephen Boyd In-Reply-To: <1521168778-27236-3-git-send-email-david@lechnology.com> Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Sekhar Nori , Kevin Hilman , Bartosz Golaszewski , Adam Ford , linux-kernel@vger.kernel.org, David Lechner References: <1521168778-27236-1-git-send-email-david@lechnology.com> <1521168778-27236-3-git-send-email-david@lechnology.com> Message-ID: <152156501473.183971.10164660837276962553@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v8 02/42] clk: davinci: New driver for davinci PLL clocks Date: Tue, 20 Mar 2018 09:56:54 -0700 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Quoting David Lechner (2018-03-15 19:52:18) > + > +static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry) > +{ > + struct davinci_pll_clk *pll = to_davinci_pll_clk(hw); > + struct debugfs_regset32 *regset; > + struct dentry *d; > + > + regset = kzalloc(sizeof(regset), GFP_KERNEL); Should be sizeof(*regset)? I squashed this in: --- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c index 588a48927436..89d30bf95102 100644 --- a/drivers/clk/davinci/pll.c +++ b/drivers/clk/davinci/pll.c @@ -882,7 +882,7 @@ static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry) struct debugfs_regset32 *regset; struct dentry *d; - regset = kzalloc(sizeof(regset), GFP_KERNEL); + regset = kzalloc(sizeof(*regset), GFP_KERNEL); if (!regset) return -ENOMEM;