| Message ID | 1534834341-18345-1-git-send-email-akshu.agrawal@amd.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: x86: Set default parent to 48Mhz | expand |
On Tue, Aug 21, 2018 at 12:53 AM Akshu Agrawal <akshu.agrawal@amd.com> wrote: > > System clk provided in ST soc can be set to: > 48Mhz, non-spread > 25Mhz, spread > To get accurate rate, we need it to set it at non-spread > option which is 48Mhz. > > Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> > --- > drivers/clk/x86/clk-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c > index fb62f39..3a0996f 100644 > --- a/drivers/clk/x86/clk-st.c > +++ b/drivers/clk/x86/clk-st.c > @@ -46,7 +46,7 @@ static int st_clk_probe(struct platform_device *pdev) > clk_oscout1_parents, ARRAY_SIZE(clk_oscout1_parents), > 0, st_data->base + CLKDRVSTR2, OSCOUT1CLK25MHZ, 3, 0, NULL); > > - clk_set_parent(hws[ST_CLK_MUX]->clk, hws[ST_CLK_25M]->clk); > + clk_set_parent(hws[ST_CLK_MUX]->clk, hws[ST_CLK_48M]->clk); > > hws[ST_CLK_GATE] = clk_hw_register_gate(NULL, "oscout1", "oscout1_mux", > 0, st_data->base + MISCCLKCNTL1, OSCCLKENB, > -- > 1.9.1 >
Quoting Akshu Agrawal (2018-08-20 23:51:57) > System clk provided in ST soc can be set to: > 48Mhz, non-spread > 25Mhz, spread > To get accurate rate, we need it to set it at non-spread > option which is 48Mhz. > > Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> Does this need to go to 4.18 stable trees? I don't see a fixes tag so I'm trying to understand merge priority of this patch.
On 8/29/2018 3:59 AM, Stephen Boyd wrote: > Quoting Akshu Agrawal (2018-08-20 23:51:57) >> System clk provided in ST soc can be set to: >> 48Mhz, non-spread >> 25Mhz, spread >> To get accurate rate, we need it to set it at non-spread >> option which is 48Mhz. >> >> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> > > Does this need to go to 4.18 stable trees? I don't see a fixes tag so > I'm trying to understand merge priority of this patch. > Yes, and its a fix, as it fixes the in accuracy in the bclk which is derived from this clk. Thanks, Akshu
Quoting Akshu Agrawal (2018-08-20 23:51:57) > System clk provided in ST soc can be set to: > 48Mhz, non-spread > 25Mhz, spread > To get accurate rate, we need it to set it at non-spread > option which is 48Mhz. > > Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> > --- Applied to clk-fixes
diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c index fb62f39..3a0996f 100644 --- a/drivers/clk/x86/clk-st.c +++ b/drivers/clk/x86/clk-st.c @@ -46,7 +46,7 @@ static int st_clk_probe(struct platform_device *pdev) clk_oscout1_parents, ARRAY_SIZE(clk_oscout1_parents), 0, st_data->base + CLKDRVSTR2, OSCOUT1CLK25MHZ, 3, 0, NULL); - clk_set_parent(hws[ST_CLK_MUX]->clk, hws[ST_CLK_25M]->clk); + clk_set_parent(hws[ST_CLK_MUX]->clk, hws[ST_CLK_48M]->clk); hws[ST_CLK_GATE] = clk_hw_register_gate(NULL, "oscout1", "oscout1_mux", 0, st_data->base + MISCCLKCNTL1, OSCCLKENB,
System clk provided in ST soc can be set to: 48Mhz, non-spread 25Mhz, spread To get accurate rate, we need it to set it at non-spread option which is 48Mhz. Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> --- drivers/clk/x86/clk-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)