| Message ID | 1572591791-11280-3-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | clk: renesas: rcar-usb2-clock-sel: Fix clks/resets handling | expand |
Hi Shimoda-san, On Fri, Nov 1, 2019 at 8:03 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > This patch adds missing required properties of power-domains and resets. > Fortunately, no one has this device node for now, so that we don't > need to think of backward compatibility. > > Fixes: 311accb64570 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Rob Herring <robh@kernel.org> Thanks for your patch! > --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > @@ -43,6 +43,9 @@ Required properties: > - The USB_EXTAL clock pin must be "usb_extal" > - The USB_XTAL clock pin must be "usb_xtal" > - #clock-cells: Must be 0 > +- power-domains: A phandle and symbolic PM domain specifier. > + See power/renesas,rcar-sysc.txt. > +- resets: A list of phandles and specifier pairs. Since there is more than one, I think it would be good to specify reset-names, too ("ehci_ohci" and "hs-usb-if"). The rest looks good to me. > Example (R-Car H3): > > @@ -54,4 +57,6 @@ Example (R-Car H3): > <&usb_extal>, <&usb_xtal>; > clock-names = "ehci_ohci", "hs-usb-if", "usb_extal", "usb_xtal"; > #clock-cells = <0>; > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > + resets = <&cpg 703>, <&cpg 704>; > }; Gr{oetje,eeting}s, Geert
Hi Geert-san, Thank you for your review and I completely overlooked this email... > From: Geert Uytterhoeven, Sent: Monday, November 18, 2019 7:12 PM > > Hi Shimoda-san, > > On Fri, Nov 1, 2019 at 8:03 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > This patch adds missing required properties of power-domains and resets. > > Fortunately, no one has this device node for now, so that we don't > > need to think of backward compatibility. > > > > Fixes: 311accb64570 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY") > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > > +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > > @@ -43,6 +43,9 @@ Required properties: > > - The USB_EXTAL clock pin must be "usb_extal" > > - The USB_XTAL clock pin must be "usb_xtal" > > - #clock-cells: Must be 0 > > +- power-domains: A phandle and symbolic PM domain specifier. > > + See power/renesas,rcar-sysc.txt. > > +- resets: A list of phandles and specifier pairs. > > Since there is more than one, I think it would be good to specify > reset-names, too ("ehci_ohci" and "hs-usb-if"). I got it. I'll add reset-names. Best regards, Yoshihiro Shimoda > The rest looks good to me. > > > Example (R-Car H3): > > > > @@ -54,4 +57,6 @@ Example (R-Car H3): > > <&usb_extal>, <&usb_xtal>; > > clock-names = "ehci_ohci", "hs-usb-if", "usb_extal", "usb_xtal"; > > #clock-cells = <0>; > > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > + resets = <&cpg 703>, <&cpg 704>; > > }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt index 5c1903f..8e96640 100644 --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt @@ -43,6 +43,9 @@ Required properties: - The USB_EXTAL clock pin must be "usb_extal" - The USB_XTAL clock pin must be "usb_xtal" - #clock-cells: Must be 0 +- power-domains: A phandle and symbolic PM domain specifier. + See power/renesas,rcar-sysc.txt. +- resets: A list of phandles and specifier pairs. Example (R-Car H3): @@ -54,4 +57,6 @@ Example (R-Car H3): <&usb_extal>, <&usb_xtal>; clock-names = "ehci_ohci", "hs-usb-if", "usb_extal", "usb_xtal"; #clock-cells = <0>; + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; + resets = <&cpg 703>, <&cpg 704>; };
This patch adds missing required properties of power-domains and resets. Fortunately, no one has this device node for now, so that we don't need to think of backward compatibility. Fixes: 311accb64570 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt | 5 +++++ 1 file changed, 5 insertions(+)