| Message ID | 1576667390-29449-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | clock: renesas: cpg-mssr: Fix the typo | expand |
On 18.12.2019 14:09, Biju Das wrote: > This patch fixes the typo %s/r8a774a1/r8a774b1/. > > Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 SHA1 should have at least 12 digits. > binding") And never break up the tag lines please. > Signed-off-by: Biju Das <biju.das@bp.renesas.com> [...] MBR, Sergei
Hi Sergei, Thanks for the feedback. > Subject: Re: [PATCH] clock: renesas: cpg-mssr: Fix the typo > > On 18.12.2019 14:09, Biju Das wrote: > > > This patch fixes the typo %s/r8a774a1/r8a774b1/. > > > > Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 > > SHA1 should have at least 12 digits. > Ok will do. > > binding") > > And never break up the tag lines please. Do you mean , do the changes like below and ignore check patch warnings? Is it acceptable to everyone? Fixes: 10003938a0c64c2f0d89 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 binding") > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > [...] > > MBR, Sergei
On 12/18/2019 03:49 PM, Biju Das wrote: >> Subject: Re: [PATCH] clock: renesas: cpg-mssr: Fix the typo >> >> On 18.12.2019 14:09, Biju Das wrote: >> >>> This patch fixes the typo %s/r8a774a1/r8a774b1/. >>> >>> Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 >> >> SHA1 should have at least 12 digits. >> > Ok will do. > >>> binding") >> >> And never break up the tag lines please. > > Do you mean , do the changes like below and ignore check patch warnings? checkpatch.pl doesn't complain to me, even about short SHA1... > Is it acceptable to everyone? I remember e.g. Dave Miller complaining about breaking up the "Fixes:" tag -- I think it breaks patchwork. Looking at Documentation/process/submitting-patches.rst, this format is even codified... > Fixes: 10003938a0c64c2f0d89 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 binding") > >>> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> [...] MBR, Sergei
diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt index c7674d0..f4d153f 100644 --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt @@ -19,7 +19,7 @@ Required Properties: - "renesas,r8a7745-cpg-mssr" for the r8a7745 SoC (RZ/G1E) - "renesas,r8a77470-cpg-mssr" for the r8a77470 SoC (RZ/G1C) - "renesas,r8a774a1-cpg-mssr" for the r8a774a1 SoC (RZ/G2M) - - "renesas,r8a774b1-cpg-mssr" for the r8a774a1 SoC (RZ/G2N) + - "renesas,r8a774b1-cpg-mssr" for the r8a774b1 SoC (RZ/G2N) - "renesas,r8a774c0-cpg-mssr" for the r8a774c0 SoC (RZ/G2E) - "renesas,r8a7790-cpg-mssr" for the r8a7790 SoC (R-Car H2) - "renesas,r8a7791-cpg-mssr" for the r8a7791 SoC (R-Car M2-W)
This patch fixes the typo %s/r8a774a1/r8a774b1/. Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 binding") Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)