diff mbox series

dt-bindings: clock: renesas,rcar-usb2-clock-sel: add r8a77961 support

Message ID 1585117204-8469-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive)
State Awaiting Upstream, archived
Headers show
Series dt-bindings: clock: renesas,rcar-usb2-clock-sel: add r8a77961 support | expand

Commit Message

Yoshihiro Shimoda March 25, 2020, 6:20 a.m. UTC
This patch adds support for r8a77961 (R-Car M3-W+).

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven March 25, 2020, 1:12 p.m. UTC | #1
Hi Shimoda-san,

On Wed, Mar 25, 2020 at 7:20 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This patch adds support for r8a77961 (R-Car M3-W+).
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> @@ -28,6 +28,8 @@ Required properties:
>               an R8A7795 SoC.
>               "renesas,r8a7796-rcar-usb2-clock-sel" if the device if a part of
>               an R8A7796 SoC.

While at it, you may want to update "R8A7796 SoC" to "R8A77960 SoC", to
avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).

> +             "renesas,r8a77961-rcar-usb2-clock-sel" if the device if a part of
> +             an R8A77961 SoC.
>               "renesas,rcar-gen3-usb2-clock-sel" for a generic R-Car Gen3
>               compatible device.

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Yoshihiro Shimoda March 26, 2020, 2:21 a.m. UTC | #2
Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Wednesday, March 25, 2020 10:13 PM
<snip>
> > --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> > +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> > @@ -28,6 +28,8 @@ Required properties:
> >               an R8A7795 SoC.
> >               "renesas,r8a7796-rcar-usb2-clock-sel" if the device if a part of
> >               an R8A7796 SoC.
> 
> While at it, you may want to update "R8A7796 SoC" to "R8A77960 SoC", to
> avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).

I got it. I'll fix it.

> > +             "renesas,r8a77961-rcar-usb2-clock-sel" if the device if a part of
> > +             an R8A77961 SoC.
> >               "renesas,rcar-gen3-usb2-clock-sel" for a generic R-Car Gen3
> >               compatible device.
> 
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks!

Best regards,
Yoshihiro Shimoda
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
index 4bf6f53..cf9221e 100644
--- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
+++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
@@ -28,6 +28,8 @@  Required properties:
 	      an R8A7795 SoC.
 	      "renesas,r8a7796-rcar-usb2-clock-sel" if the device if a part of
 	      an R8A7796 SoC.
+	      "renesas,r8a77961-rcar-usb2-clock-sel" if the device if a part of
+	      an R8A77961 SoC.
 	      "renesas,rcar-gen3-usb2-clock-sel" for a generic R-Car Gen3
 	      compatible device.